Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA00C2D0A3 for ; Wed, 4 Nov 2020 09:38:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E453A221F8 for ; Wed, 4 Nov 2020 09:38:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="vwl02Uat" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E453A221F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.18946.44072 (Exim 4.92) (envelope-from ) id 1kaFFF-0000vO-Mp; Wed, 04 Nov 2020 09:38:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 18946.44072; Wed, 04 Nov 2020 09:38:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kaFFF-0000vH-Jp; Wed, 04 Nov 2020 09:38:21 +0000 Received: by outflank-mailman (input) for mailman id 18946; Wed, 04 Nov 2020 09:38:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kaFFE-0000vC-9Y for xen-devel@lists.xenproject.org; Wed, 04 Nov 2020 09:38:20 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06bfd912-67c2-401c-9cf5-db3581bc9792; Wed, 04 Nov 2020 09:38:19 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kaFFB-00012z-8E; Wed, 04 Nov 2020 09:38:17 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kaFFB-0001gp-0t; Wed, 04 Nov 2020 09:38:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kaFFE-0000vC-9Y for xen-devel@lists.xenproject.org; Wed, 04 Nov 2020 09:38:20 +0000 X-Inumbo-ID: 06bfd912-67c2-401c-9cf5-db3581bc9792 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06bfd912-67c2-401c-9cf5-db3581bc9792; Wed, 04 Nov 2020 09:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=gZf0BTVhX+vIA3VdG7OBgsKPbP8EWYIWiotMMRtLN/8=; b=vwl02Uat5R48voil+73l6kqrrH XslAY/zx+H0sg4qmo8YJT/epqdNIs+6KNQlm8qHGMmP8xOVu9jcI++snJCjUAaSNqxlYSBvW9sIK0 dpaTNFLJ7rbpOO8JGnOhPkgIHgWiEG8FtYHQT/HSEZPcJxEHAzVl+JLaRRhOpHKhgTyQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kaFFB-00012z-8E; Wed, 04 Nov 2020 09:38:17 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kaFFB-0001gp-0t; Wed, 04 Nov 2020 09:38:17 +0000 Subject: Re: [PATCH v3 2/3] xen/locking: harmonize spinlocks and rwlocks regarding preemption To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20201104081549.3712-1-jgross@suse.com> <20201104081549.3712-3-jgross@suse.com> From: Julien Grall Message-ID: <7adebd65-af5c-a265-cb4e-7dbddf790c3f@xen.org> Date: Wed, 4 Nov 2020 09:38:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201104081549.3712-3-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Juergen, On 04/11/2020 08:15, Juergen Gross wrote: > Spinlocks and rwlocks behave differently in the try variants regarding > preemption: rwlocks are switching preemption off before testing the > lock, while spinlocks do so only after the first check. > > Modify _spin_trylock() to disable preemption before testing the lock > to be held in order to be preemption-ready. > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall