Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0427C47404 for ; Mon, 7 Oct 2019 12:06:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B3020867 for ; Mon, 7 Oct 2019 12:06:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B3020867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHRmd-0008Db-LR for qemu-devel@archiver.kernel.org; Mon, 07 Oct 2019 08:06:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47216) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHRls-0007ia-Ou for qemu-devel@nongnu.org; Mon, 07 Oct 2019 08:05:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHRlr-0001HO-RF for qemu-devel@nongnu.org; Mon, 07 Oct 2019 08:05:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHRlo-0001DP-KJ; Mon, 07 Oct 2019 08:05:44 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D57F34628B; Mon, 7 Oct 2019 12:05:43 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.196]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABCE760C18; Mon, 7 Oct 2019 12:05:42 +0000 (UTC) Subject: Re: [PATCH 1/2] tests: Make iotest 223 easier to edit To: Eric Blake , qemu-devel@nongnu.org References: <20190924143522.22902-1-eblake@redhat.com> <20190924143522.22902-2-eblake@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <7aea45cd-bada-4e90-9ee9-1bac19e3c7df@redhat.com> Date: Mon, 7 Oct 2019 14:05:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190924143522.22902-2-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ihfFaT0pZ2cNs5g1Nka1EC9LQ0nWIj4xe" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 07 Oct 2019 12:05:43 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nsoffer@redhat.com, Kevin Wolf , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ihfFaT0pZ2cNs5g1Nka1EC9LQ0nWIj4xe Content-Type: multipart/mixed; boundary="iH6zEtxFwtL2BH9n29FvFrSvGkj1cUrws" --iH6zEtxFwtL2BH9n29FvFrSvGkj1cUrws Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 24.09.19 16:35, Eric Blake wrote: > Log the QMP input to qemu, not just the QMP output. Why not just add this functionality to _send_qemu_cmd directly? (Like silent already does for replies, although it=E2=80=99s inverted.) (Although I=E2=80=99m not quite sold on the indentation for commands, bec= ause (1) we don=E2=80=99t do that in other tests, (2) I=E2=80=99d prefer some = prefix like ->/<-, and (3) there is generally no need because commands start with =E2=80=9Cexecute=E2=80=9D and replies start with =E2=80=9Creturn=E2=80=9D= , =E2=80=9Cerror=E2=80=9D, or =E2=80=9Cevent=E2=80=9D, so they already have clear prefixes to distinguish the two classes.) Max > Signed-off-by: Eric Blake > --- > tests/qemu-iotests/223 | 48 +++++++++++++++++++++-----------------= > tests/qemu-iotests/223.out | 40 +++++++++++++++++++++++++++++++ > 2 files changed, 67 insertions(+), 21 deletions(-) --iH6zEtxFwtL2BH9n29FvFrSvGkj1cUrws-- --ihfFaT0pZ2cNs5g1Nka1EC9LQ0nWIj4xe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl2bKhUACgkQ9AfbAGHV z0CP9gf+LHHsmj0+Kb4Z/N14ocC69zp6Mal3bjeLMqtKHetW5tmknLf5dnTSjPWQ slyW3takCWuV8TzjD/7SMxxD8m6oa/Vf+sb7e110LxIzUTVTAaikoli7ZIaOEVRA D2TOJKdDmgKtjEHsQrZFbLKUo0S7ySiVK3EZ6jRZC5QenW7kXXIS3PaLXjPc3BqU Q3QkNW6m6r8oo3gtvrWzXoA4AHzMNiD1ya71x02TEX6NOx5KzJqES5NDzCsz39GR C0U1RHvUheYg3T+We8uS2b0czxynAZ+LVMojahoR3Q+61uFruc5WVo2megRl1YLv C83Ejf6WXvwsvhggXTmn68jrq0l1IQ== =tHcJ -----END PGP SIGNATURE----- --ihfFaT0pZ2cNs5g1Nka1EC9LQ0nWIj4xe--