Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2CC0EB64DC for ; Tue, 18 Jul 2023 14:00:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A0E9086713; Tue, 18 Jul 2023 15:59:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=kernel-space.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel-space.org header.i=@kernel-space.org header.b="tfjPgkfP"; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=kernel-space.org header.i=@kernel-space.org header.b="B4Heca1A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BBAAC866B2; Tue, 18 Jul 2023 15:58:40 +0200 (CEST) Received: from mail.kernel-space.org (unknown [IPv6:2a01:4f8:c2c:5a84::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DD306866B2 for ; Tue, 18 Jul 2023 15:58:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel-space.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angelo@kernel-space.org Received: from ziongate (localhost [127.0.0.1]) by ziongate (OpenSMTPD) with ESMTP id 5a909350; Tue, 18 Jul 2023 13:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=kernel-space.org; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=default; bh=Ha/hLndycSTlGY1hyqLJIYNYoG8=; b=tfjPgkfPvCGiypJcgDkdGyDCmW4d 4IjRcLpnFpuLDL9Bg+SKjs8mpeU2099Dgoi2xPgc2A77PNQxJjKGWFs5l2n/3vR0 iTTPdLEvhWxho1igNhfjOoWXPnTyiki3qE+Ujk4nOrsZyIK+VnzSwp2Mkeux8DBY uoGbNAsC8jwW2rc= DomainKey-Signature: a=rsa-sha1; c=simple; d=kernel-space.org; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=rmcJ3Pok2kIHBJd1epdrkRUAER9KZBqDC17X+37/+t8EPPIDuBotT sBgBJ7apZ3ZGkWmPXphmVSlELeA7OE1Ykh9alE47mU/o1zHSoD36Kwbb8c9vabkK S0aJpHKQ+61dHf3LQ7R3zyKpLMKry/uI+Pqb0vQumhmk0+AzLt6ZFA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-space.org; s=20190913; t=1689688715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwj/A0x8ykoFNvMT4MBc/gKSfVJB8eckHqTmwCu9qcI=; b=B4Heca1ArXdQg7r1QUqy6lTWxshTtCNfu0CFyhEtK5hZTAsr7Bt9MUXP8A/b/kIany6J/M PYwkxPzSwJiAPzYRvuja+H5S4th/p52D4RrUzl6b7dkREPcOAH6PBbOx7qtxWVPJGBivLA Wr20pG5E7PiV+QPWWR4DxmLbRreI1gc= Received: from [192.168.0.2] (host-80-182-57-72.pool80182.interbusiness.it [80.182.57.72]) by ziongate (OpenSMTPD) with ESMTPSA id 93c18e66 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 18 Jul 2023 13:58:35 +0000 (UTC) Message-ID: <7b554118-a36f-68d2-96e5-2f60667243aa@kernel-space.org> Date: Tue, 18 Jul 2023 15:58:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Betterbird/102.11.0 Subject: Re: [PATCH 3/5] m68k: dts: add watchdog node To: Stefan Roese , trini@konsulko.com Cc: u-boot@lists.denx.de References: <20230625193521.981846-1-angelo@kernel-space.org> <20230625193521.981846-4-angelo@kernel-space.org> <42008163-971d-6a05-261e-64c8bb343112@denx.de> Content-Language: en-US From: Angelo Dureghello In-Reply-To: <42008163-971d-6a05-261e-64c8bb343112@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, On 18/07/23 2:26 PM, Stefan Roese wrote: > On 6/25/23 21:35, Angelo Dureghello wrote: >> Add watchdog node for the implemented mcf_wdt driver. >> >> Signed-off-by: Angelo Dureghello >> --- >>   arch/m68k/dts/M5208EVBE.dts | 5 +++++ >>   arch/m68k/dts/mcf5208.dtsi  | 7 +++++++ >>   arch/m68k/dts/mcf523x.dtsi  | 7 +++++++ >>   arch/m68k/dts/mcf5271.dtsi  | 7 +++++++ >>   arch/m68k/dts/mcf5275.dtsi  | 7 +++++++ >>   arch/m68k/dts/mcf5282.dtsi  | 7 +++++++ >>   arch/m68k/dts/mcf5329.dtsi  | 7 +++++++ >>   arch/m68k/dts/mcf537x.dtsi  | 7 +++++++ >>   8 files changed, 54 insertions(+) >> >> diff --git a/arch/m68k/dts/M5208EVBE.dts b/arch/m68k/dts/M5208EVBE.dts >> index 1c32718af4..ec203e8b69 100644 >> --- a/arch/m68k/dts/M5208EVBE.dts >> +++ b/arch/m68k/dts/M5208EVBE.dts >> @@ -15,6 +15,11 @@ >>       }; >>   }; >> +&wdog0 { >> +    timeout-sec = <32>; >> +    status = "okay"; >> +}; >> + >>   &uart0 { >>       bootph-all; >>       status = "okay"; >> diff --git a/arch/m68k/dts/mcf5208.dtsi b/arch/m68k/dts/mcf5208.dtsi >> index 9392facfa8..b06dc4bb26 100644 >> --- a/arch/m68k/dts/mcf5208.dtsi >> +++ b/arch/m68k/dts/mcf5208.dtsi >> @@ -16,6 +16,13 @@ >>           #address-cells = <1>; >>           #size-cells = <1>; >> +        wdog0: watchdog@fc08c000 { >> +            compatible = "fsl,mcf5208-wdt"; >> +            reg = <0xfc08c000 0x10>; >> +            big-endian; >> +            status = "disabled"; >> +        }; > > I was not able to find this compatible property in the Linux Kernel > source tree. Is this the official version of the Coldfire WDT DT node? > Just checking.. > there is no fdt support for m68k in Linux, after discussing the need in u-boot, i implemented fdt here the best i could. > Thanks, > Stefan > >> + >>           uart0: uart@fc060000 { >>               compatible = "fsl,mcf-uart"; >>               reg = <0xfc060000 0x40>; >> diff --git a/arch/m68k/dts/mcf523x.dtsi b/arch/m68k/dts/mcf523x.dtsi >> index 41c7b9b2d1..fb5a4cdc21 100644 >> --- a/arch/m68k/dts/mcf523x.dtsi >> +++ b/arch/m68k/dts/mcf523x.dtsi >> @@ -23,6 +23,13 @@ >>               ranges = <0x00000000 0x40000000 0x40000000>; >>               reg = <0x40000000 0x40000000>; >> +            wdog0: watchdog@140000 { >> +                compatible = "fsl,mcf5208-wdt"; >> +                reg = <0x140000 0x10>; >> +                big-endian; >> +                status = "disabled"; >> +            }; >> + >>               uart0: uart@200 { >>                   compatible = "fsl,mcf-uart"; >>                   reg = <0x200 0x40>; >> diff --git a/arch/m68k/dts/mcf5271.dtsi b/arch/m68k/dts/mcf5271.dtsi >> index fc82bd3c24..0884c13ab1 100644 >> --- a/arch/m68k/dts/mcf5271.dtsi >> +++ b/arch/m68k/dts/mcf5271.dtsi >> @@ -23,6 +23,13 @@ >>               ranges = <0x00000000 0x40000000 0x40000000>; >>               reg = <0x40000000 0x40000000>; >> +            wdog0: watchdog@140000 { >> +                compatible = "fsl,mcf5208-wdt"; >> +                reg = <0x140000 0x10>; >> +                big-endian; >> +                status = "disabled"; >> +            }; >> + >>               uart0: uart@200 { >>                   compatible = "fsl,mcf-uart"; >>                   reg = <0x200 0x40>; >> diff --git a/arch/m68k/dts/mcf5275.dtsi b/arch/m68k/dts/mcf5275.dtsi >> index 402517cdec..78210569da 100644 >> --- a/arch/m68k/dts/mcf5275.dtsi >> +++ b/arch/m68k/dts/mcf5275.dtsi >> @@ -24,6 +24,13 @@ >>               ranges = <0x00000000 0x40000000 0x40000000>; >>               reg = <0x40000000 0x40000000>; >> +            wdog0: watchdog@140000 { >> +                compatible = "fsl,mcf5208-wdt"; >> +                reg = <0x140000 0x10>; >> +                big-endian; >> +                status = "disabled"; >> +            }; >> + >>               uart0: uart@200 { >>                   compatible = "fsl,mcf-uart"; >>                   reg = <0x200 0x40>; >> diff --git a/arch/m68k/dts/mcf5282.dtsi b/arch/m68k/dts/mcf5282.dtsi >> index 883c0d0324..40704c5202 100644 >> --- a/arch/m68k/dts/mcf5282.dtsi >> +++ b/arch/m68k/dts/mcf5282.dtsi >> @@ -23,6 +23,13 @@ >>               ranges = <0x00000000 0x40000000 0x40000000>; >>               reg = <0x40000000 0x40000000>; >> +            wdog0: watchdog@140000 { >> +                compatible = "fsl,mcf5282-wdt"; >> +                reg = <0x140000 0x10>; >> +                big-endian; >> +                status = "disabled"; >> +            }; >> + >>               uart0: uart@200 { >>                   compatible = "fsl,mcf-uart"; >>                   reg = <0x200 0x40>; >> diff --git a/arch/m68k/dts/mcf5329.dtsi b/arch/m68k/dts/mcf5329.dtsi >> index 7501cc4b01..50ff73bca7 100644 >> --- a/arch/m68k/dts/mcf5329.dtsi >> +++ b/arch/m68k/dts/mcf5329.dtsi >> @@ -16,6 +16,13 @@ >>           #address-cells = <1>; >>           #size-cells = <1>; >> +        wdog0: watchdog@fc098000 { >> +            compatible = "fsl,mcf5208-wdt"; >> +            reg = <0xfc08c000 0x10>; >> +            big-endian; >> +            status = "disabled"; >> +        }; >> + >>           uart0: uart@fc060000 { >>               compatible = "fsl,mcf-uart"; >>               reg = <0xfc060000 0x40>; >> diff --git a/arch/m68k/dts/mcf537x.dtsi b/arch/m68k/dts/mcf537x.dtsi >> index 338b8b4583..23c3754df0 100644 >> --- a/arch/m68k/dts/mcf537x.dtsi >> +++ b/arch/m68k/dts/mcf537x.dtsi >> @@ -16,6 +16,13 @@ >>           #address-cells = <1>; >>           #size-cells = <1>; >> +        wdog0: watchdog@fc098000 { >> +            compatible = "fsl,mcf5208-wdt"; >> +            reg = <0xfc08c000 0x10>; >> +            big-endian; >> +            status = "disabled"; >> +        }; >> + >>           uart0: uart@fc060000 { >>               compatible = "fsl,mcf-uart"; >>               reg = <0xfc060000 0x40>; > > Viele Grüße, > Stefan Roese > Regards, angelo