Received: from eggs.gnu.org ([209.51.188.92]:56761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghXl1-0000B9-QN for qemu-devel@nongnu.org; Thu, 10 Jan 2019 05:40:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghXl0-0004Eg-9h for qemu-devel@nongnu.org; Thu, 10 Jan 2019 05:40:15 -0500 From: Vladimir Sementsov-Ogievskiy Date: Thu, 10 Jan 2019 10:40:06 +0000 Message-ID: <7bead05e-672a-fdc2-6291-e72090defb66@virtuozzo.com> References: <20190110071330.28136-1-eblake@redhat.com> <20190110071330.28136-3-eblake@redhat.com> In-Reply-To: <20190110071330.28136-3-eblake@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "qemu-devel@nongnu.org" Cc: "jsnow@redhat.com" , "qemu-block@nongnu.org" , Kevin Wolf , Max Reitz MTAuMDEuMjAxOSAxMDoxMywgRXJpYyBCbGFrZSB3cm90ZToNCj4gVGhlIGV4aXN0aW5nIE5CRCBj b2RlIGhhZCBhIHdlaXJkIHNwbGl0IHdoZXJlIG5iZF9leHBvcnRfbmV3KCkNCj4gY3JlYXRlZCBh biBleHBvcnQgYnV0IGRpZCBub3QgYWRkIGl0IHRvIHRoZSBsaXN0IG9mIGV4cG9ydGVkDQo+IG5h bWVzIHVudGlsIGEgbGF0ZXIgbmJkX2V4cG9ydF9zZXRfbmFtZSgpIGNhbWUgYWxvbmcgYW5kIGdy YWJiZWQNCj4gYSBzZWNvbmQgcmVmZXJlbmNlIG9uIHRoZSBvYmplY3Q7IGxhdGVyLCBuYmRfZXhw b3J0X2Nsb3NlKCkNCj4gZHJvcHMgdGhlIHNlY29uZCByZWZlcmVuY2UuICBCdXQgc2luY2Ugd2Ug bmV2ZXIgY2hhbmdlIHRoZQ0KPiBuYW1lIG9mIGFuIE5CRCBleHBvcnQgd2hpbGUgaXQgaXMgZXhw b3NlZCwgaXQgaXMgZWFzaWVyIHRvIGp1c3QNCj4gaW5saW5lIHRoZSBwcm9jZXNzIG9mIHNldHRp bmcgdGhlIG5hbWUgYXMgcGFydCBvZiBjcmVhdGluZyB0aGUNCj4gZXhwb3J0Lg0KPiANCj4gSW5s aW5lIHRoZSBjb250ZW50cyBvZiBuYmRfZXhwb3J0X3NldF9uYW1lKCkgYW5kDQo+IG5iZF9leHBv cnRfc2V0X2Rlc2NyaXB0aW9uKCkgaW50byB0aGUgdHdvIHBvaW50cyBpbiBhbiBleHBvcnQNCj4g bGlmZWN5Y2xlIHdoZXJlIHRoZXkgbWF0dGVyLCB0aGVuIGFkanVzdCBib3RoIGNhbGxlcnMgdG8g cGFzcw0KPiB0aGUgbmFtZSB1cCBmcm9udC4gIE5vdGUgdGhhdCBhbGwgY2FsbGVycyBwYXNzIGEg bm9uLU5VTEwgbmFtZSwNCj4gKHBhc3NpbmcgTlVMTCBhdCBjcmVhdGlvbiB3YXMgZm9yIG9sZCBz dHlsZSBzZXJ2ZXJzLCBidXQgd2UNCj4gcmVtb3ZlZCBzdXBwb3J0IGZvciB0aGF0IGluIGNvbW1p dCA3ZjdkZmUyYSkuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBFcmljIEJsYWtlIDxlYmxha2VAcmVk aGF0LmNvbT4NCj4gLS0tDQo+ICAgaW5jbHVkZS9ibG9jay9uYmQuaCB8ICAzICstLQ0KPiAgIGJs b2NrZGV2LW5iZC5jICAgICAgfCAgNSArKy0tLQ0KPiAgIG5iZC9zZXJ2ZXIuYyAgICAgICAgfCA0 NSArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gICBxZW11 LW5iZC5jICAgICAgICAgIHwgIDUgKystLS0NCj4gICA0IGZpbGVzIGNoYW5nZWQsIDIxIGluc2Vy dGlvbnMoKyksIDM3IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvYmxv Y2svbmJkLmggYi9pbmNsdWRlL2Jsb2NrL25iZC5oDQo+IGluZGV4IDY1NDAyZDMzOTY0Li4yZjlh MmFlYjczYyAxMDA2NDQNCj4gLS0tIGEvaW5jbHVkZS9ibG9jay9uYmQuaA0KPiArKysgYi9pbmNs dWRlL2Jsb2NrL25iZC5oDQo+IEBAIC0yOTUsNiArMjk1LDcgQEAgdHlwZWRlZiBzdHJ1Y3QgTkJE RXhwb3J0IE5CREV4cG9ydDsNCj4gICB0eXBlZGVmIHN0cnVjdCBOQkRDbGllbnQgTkJEQ2xpZW50 Ow0KPiANCj4gICBOQkRFeHBvcnQgKm5iZF9leHBvcnRfbmV3KEJsb2NrRHJpdmVyU3RhdGUgKmJz LCBvZmZfdCBkZXZfb2Zmc2V0LCBvZmZfdCBzaXplLA0KPiArICAgICAgICAgICAgICAgICAgICAg ICAgICBjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICpkZXNjcmlwdGlvbiwNCj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVpbnQxNl90IG5iZGZsYWdzLCB2b2lkICgqY2xvc2UpKE5C REV4cG9ydCAqKSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgd3JpdGV0aHJv dWdoLCBCbG9ja0JhY2tlbmQgKm9uX2VqZWN0X2JsaywNCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEVycm9yICoqZXJycCk7DQo+IEBAIC0zMDYsOCArMzA3LDYgQEAgdm9pZCBuYmRfZXhw b3J0X3B1dChOQkRFeHBvcnQgKmV4cCk7DQo+ICAgQmxvY2tCYWNrZW5kICpuYmRfZXhwb3J0X2dl dF9ibG9ja2RldihOQkRFeHBvcnQgKmV4cCk7DQo+IA0KPiAgIE5CREV4cG9ydCAqbmJkX2V4cG9y dF9maW5kKGNvbnN0IGNoYXIgKm5hbWUpOw0KPiAtdm9pZCBuYmRfZXhwb3J0X3NldF9uYW1lKE5C REV4cG9ydCAqZXhwLCBjb25zdCBjaGFyICpuYW1lKTsNCj4gLXZvaWQgbmJkX2V4cG9ydF9zZXRf ZGVzY3JpcHRpb24oTkJERXhwb3J0ICpleHAsIGNvbnN0IGNoYXIgKmRlc2NyaXB0aW9uKTsNCj4g ICB2b2lkIG5iZF9leHBvcnRfY2xvc2VfYWxsKHZvaWQpOw0KPiANCj4gICB2b2lkIG5iZF9jbGll bnRfbmV3KFFJT0NoYW5uZWxTb2NrZXQgKnNpb2MsDQo+IGRpZmYgLS1naXQgYS9ibG9ja2Rldi1u YmQuYyBiL2Jsb2NrZGV2LW5iZC5jDQo+IGluZGV4IDFkMTcwYzgwYjgyLi5mNWVkYmMyN2Q4OCAx MDA2NDQNCj4gLS0tIGEvYmxvY2tkZXYtbmJkLmMNCj4gKysrIGIvYmxvY2tkZXYtbmJkLmMNCj4g QEAgLTE3NCwxNCArMTc0LDEzIEBAIHZvaWQgcW1wX25iZF9zZXJ2ZXJfYWRkKGNvbnN0IGNoYXIg KmRldmljZSwgYm9vbCBoYXNfbmFtZSwgY29uc3QgY2hhciAqbmFtZSwNCj4gICAgICAgICAgIHdy aXRhYmxlID0gZmFsc2U7DQo+ICAgICAgIH0NCj4gDQo+IC0gICAgZXhwID0gbmJkX2V4cG9ydF9u ZXcoYnMsIDAsIC0xLCB3cml0YWJsZSA/IDAgOiBOQkRfRkxBR19SRUFEX09OTFksDQo+ICsgICAg ZXhwID0gbmJkX2V4cG9ydF9uZXcoYnMsIDAsIC0xLCBuYW1lLCBOVUxMLA0KPiArICAgICAgICAg ICAgICAgICAgICAgICAgIHdyaXRhYmxlID8gMCA6IE5CRF9GTEFHX1JFQURfT05MWSwNCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgZmFsc2UsIG9uX2VqZWN0X2JsaywgZXJycCk7 DQo+ICAgICAgIGlmICghZXhwKSB7DQo+ICAgICAgICAgICByZXR1cm47DQo+ICAgICAgIH0NCj4g DQo+IC0gICAgbmJkX2V4cG9ydF9zZXRfbmFtZShleHAsIG5hbWUpOw0KPiAtDQo+ICAgICAgIC8q IFRoZSBsaXN0IG9mIG5hbWVkIGV4cG9ydHMgaGFzIGEgc3Ryb25nIHJlZmVyZW5jZSB0byB0aGlz IGV4cG9ydCBub3cgYW5kDQo+ICAgICAgICAqIG91ciBvbmx5IHdheSBvZiBhY2Nlc3NpbmcgaXQg aXMgdGhyb3VnaCBuYmRfZXhwb3J0X2ZpbmQoKSwgc28gd2UgY2FuIGRyb3ANCj4gICAgICAgICog dGhlIHN0cm9uZyByZWZlcmVuY2UgdGhhdCBpcyBAZXhwLiAqLw0KPiBkaWZmIC0tZ2l0IGEvbmJk L3NlcnZlci5jIGIvbmJkL3NlcnZlci5jDQo+IGluZGV4IDk4MzI3MDg4Y2I0Li42NzZmYjQ4ODZk MCAxMDA2NDQNCj4gLS0tIGEvbmJkL3NlcnZlci5jDQo+ICsrKyBiL25iZC9zZXJ2ZXIuYw0KPiBA QCAtMTQ1Niw2ICsxNDU2LDcgQEAgc3RhdGljIHZvaWQgbmJkX2VqZWN0X25vdGlmaWVyKE5vdGlm aWVyICpuLCB2b2lkICpkYXRhKQ0KPiAgIH0NCj4gDQo+ICAgTkJERXhwb3J0ICpuYmRfZXhwb3J0 X25ldyhCbG9ja0RyaXZlclN0YXRlICpicywgb2ZmX3QgZGV2X29mZnNldCwgb2ZmX3Qgc2l6ZSwN Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hh ciAqZGVzY3JpcHRpb24sDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MTZfdCBu YmRmbGFncywgdm9pZCAoKmNsb3NlKShOQkRFeHBvcnQgKiksDQo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBib29sIHdyaXRldGhyb3VnaCwgQmxvY2tCYWNrZW5kICpvbl9lamVjdF9ibGss DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBFcnJvciAqKmVycnApDQo+IEBAIC0xNDcx LDYgKzE0NzIsNyBAQCBOQkRFeHBvcnQgKm5iZF9leHBvcnRfbmV3KEJsb2NrRHJpdmVyU3RhdGUg KmJzLCBvZmZfdCBkZXZfb2Zmc2V0LCBvZmZfdCBzaXplLA0KPiAgICAgICAgKiB0aGF0IEJEUlZf T19JTkFDVElWRSBpcyBjbGVhcmVkIGFuZCB0aGUgaW1hZ2UgaXMgcmVhZHkgZm9yIHdyaXRlDQo+ ICAgICAgICAqIGFjY2VzcyBzaW5jZSB0aGUgZXhwb3J0IGNvdWxkIGJlIGF2YWlsYWJsZSBiZWZv cmUgbWlncmF0aW9uIGhhbmRvdmVyLg0KPiAgICAgICAgKi8NCj4gKyAgICBhc3NlcnQobmFtZSk7 DQo+ICAgICAgIGN0eCA9IGJkcnZfZ2V0X2Fpb19jb250ZXh0KGJzKTsNCj4gICAgICAgYWlvX2Nv bnRleHRfYWNxdWlyZShjdHgpOw0KPiAgICAgICBiZHJ2X2ludmFsaWRhdGVfY2FjaGUoYnMsIE5V TEwpOw0KPiBAQCAtMTQ5NCw2ICsxNDk2LDggQEAgTkJERXhwb3J0ICpuYmRfZXhwb3J0X25ldyhC bG9ja0RyaXZlclN0YXRlICpicywgb2ZmX3QgZGV2X29mZnNldCwgb2ZmX3Qgc2l6ZSwNCj4gICAg ICAgUVRBSUxRX0lOSVQoJmV4cC0+Y2xpZW50cyk7DQo+ICAgICAgIGV4cC0+YmxrID0gYmxrOw0K PiAgICAgICBleHAtPmRldl9vZmZzZXQgPSBkZXZfb2Zmc2V0Ow0KPiArICAgIGV4cC0+bmFtZSA9 IGdfc3RyZHVwKG5hbWUpOw0KPiArICAgIGV4cC0+ZGVzY3JpcHRpb24gPSBnX3N0cmR1cChkZXNj cmlwdGlvbik7DQo+ICAgICAgIGV4cC0+bmJkZmxhZ3MgPSBuYmRmbGFnczsNCj4gICAgICAgZXhw LT5zaXplID0gc2l6ZSA8IDAgPyBibGtfZ2V0bGVuZ3RoKGJsaykgOiBzaXplOw0KPiAgICAgICBp ZiAoZXhwLT5zaXplIDwgMCkgew0KPiBAQCAtMTUxMywxMCArMTUxNywxNCBAQCBOQkRFeHBvcnQg Km5iZF9leHBvcnRfbmV3KEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBvZmZfdCBkZXZfb2Zmc2V0LCBv ZmZfdCBzaXplLA0KPiAgICAgICAgICAgZXhwLT5lamVjdF9ub3RpZmllci5ub3RpZnkgPSBuYmRf ZWplY3Rfbm90aWZpZXI7DQo+ICAgICAgICAgICBibGtfYWRkX3JlbW92ZV9ic19ub3RpZmllcihv bl9lamVjdF9ibGssICZleHAtPmVqZWN0X25vdGlmaWVyKTsNCj4gICAgICAgfQ0KPiArICAgIFFU QUlMUV9JTlNFUlRfVEFJTCgmZXhwb3J0cywgZXhwLCBuZXh0KTsNCj4gKyAgICBuYmRfZXhwb3J0 X2dldChleHApOw0KPiAgICAgICByZXR1cm4gZXhwOw0KPiANCj4gICBmYWlsOg0KPiAgICAgICBi bGtfdW5yZWYoYmxrKTsNCj4gKyAgICBnX2ZyZWUoZXhwLT5uYW1lKTsNCj4gKyAgICBnX2ZyZWUo ZXhwLT5kZXNjcmlwdGlvbik7DQo+ICAgICAgIGdfZnJlZShleHApOw0KPiAgICAgICByZXR1cm4g TlVMTDsNCj4gICB9DQo+IEBAIC0xNTMzLDMzICsxNTQxLDYgQEAgTkJERXhwb3J0ICpuYmRfZXhw b3J0X2ZpbmQoY29uc3QgY2hhciAqbmFtZSkNCj4gICAgICAgcmV0dXJuIE5VTEw7DQo+ICAgfQ0K PiANCj4gLXZvaWQgbmJkX2V4cG9ydF9zZXRfbmFtZShOQkRFeHBvcnQgKmV4cCwgY29uc3QgY2hh ciAqbmFtZSkNCj4gLXsNCj4gLSAgICBpZiAoZXhwLT5uYW1lID09IG5hbWUpIHsNCj4gLSAgICAg ICAgcmV0dXJuOw0KPiAtICAgIH0NCj4gLQ0KPiAtICAgIG5iZF9leHBvcnRfZ2V0KGV4cCk7DQo+ IC0gICAgaWYgKGV4cC0+bmFtZSAhPSBOVUxMKSB7DQo+IC0gICAgICAgIGdfZnJlZShleHAtPm5h bWUpOw0KPiAtICAgICAgICBleHAtPm5hbWUgPSBOVUxMOw0KPiAtICAgICAgICBRVEFJTFFfUkVN T1ZFKCZleHBvcnRzLCBleHAsIG5leHQpOw0KPiAtICAgICAgICBuYmRfZXhwb3J0X3B1dChleHAp Ow0KPiAtICAgIH0NCj4gLSAgICBpZiAobmFtZSAhPSBOVUxMKSB7DQo+IC0gICAgICAgIG5iZF9l eHBvcnRfZ2V0KGV4cCk7DQo+IC0gICAgICAgIGV4cC0+bmFtZSA9IGdfc3RyZHVwKG5hbWUpOw0K PiAtICAgICAgICBRVEFJTFFfSU5TRVJUX1RBSUwoJmV4cG9ydHMsIGV4cCwgbmV4dCk7DQo+IC0g ICAgfQ0KPiAtICAgIG5iZF9leHBvcnRfcHV0KGV4cCk7DQo+IC19DQo+IC0NCj4gLXZvaWQgbmJk X2V4cG9ydF9zZXRfZGVzY3JpcHRpb24oTkJERXhwb3J0ICpleHAsIGNvbnN0IGNoYXIgKmRlc2Ny aXB0aW9uKQ0KPiAtew0KPiAtICAgIGdfZnJlZShleHAtPmRlc2NyaXB0aW9uKTsNCj4gLSAgICBl eHAtPmRlc2NyaXB0aW9uID0gZ19zdHJkdXAoZGVzY3JpcHRpb24pOw0KPiAtfQ0KPiAtDQo+ICAg dm9pZCBuYmRfZXhwb3J0X2Nsb3NlKE5CREV4cG9ydCAqZXhwKQ0KPiAgIHsNCj4gICAgICAgTkJE Q2xpZW50ICpjbGllbnQsICpuZXh0Ow0KPiBAQCAtMTU2OCw4ICsxNTQ5LDE0IEBAIHZvaWQgbmJk X2V4cG9ydF9jbG9zZShOQkRFeHBvcnQgKmV4cCkNCj4gICAgICAgUVRBSUxRX0ZPUkVBQ0hfU0FG RShjbGllbnQsICZleHAtPmNsaWVudHMsIG5leHQsIG5leHQpIHsNCj4gICAgICAgICAgIGNsaWVu dF9jbG9zZShjbGllbnQsIHRydWUpOw0KPiAgICAgICB9DQo+IC0gICAgbmJkX2V4cG9ydF9zZXRf bmFtZShleHAsIE5VTEwpOw0KPiAtICAgIG5iZF9leHBvcnRfc2V0X2Rlc2NyaXB0aW9uKGV4cCwg TlVMTCk7DQo+ICsgICAgaWYgKGV4cC0+bmFtZSkgew0KPiArICAgICAgICBuYmRfZXhwb3J0X3B1 dChleHApOw0KPiArICAgICAgICBnX2ZyZWUoZXhwLT5uYW1lKTsNCj4gKyAgICAgICAgZXhwLT5u YW1lID0gTlVMTDsNCj4gKyAgICAgICAgUVRBSUxRX1JFTU9WRSgmZXhwb3J0cywgZXhwLCBuZXh0 KTsNCg0KZXhwLT5uYW1lIGlzIGFsd2F5cyBub24temVybywgYW5kIF9nZXQgYW5kIF9JTlNFUlRf VEFJTCB3ZXJlIGRvbmUgaW5kZXBlbmRlbnRseSBmcm9tIG5hbWUsDQpzbyB3aXRoIHRoZXNlIGZv dXIgbGluZXMgZG9uZSB1bmNvbmRpdGlvbmFsbHk6DQpSZXZpZXdlZC1ieTogVmxhZGltaXIgU2Vt ZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPg0KDQo+ICsgICAgfQ0K PiArICAgIGdfZnJlZShleHAtPmRlc2NyaXB0aW9uKTsNCj4gKyAgICBleHAtPmRlc2NyaXB0aW9u ID0gTlVMTDsNCj4gICAgICAgbmJkX2V4cG9ydF9wdXQoZXhwKTsNCj4gICB9DQo+IA0KPiBkaWZm IC0tZ2l0IGEvcWVtdS1uYmQuYyBiL3FlbXUtbmJkLmMNCj4gaW5kZXggMjgwN2UxMzIzOTYuLjY5 NmJkNzhhMmUyIDEwMDY0NA0KPiAtLS0gYS9xZW11LW5iZC5jDQo+ICsrKyBiL3FlbXUtbmJkLmMN Cj4gQEAgLTEwMTUsMTAgKzEwMTUsOSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3Yp DQo+ICAgICAgICAgICB9DQo+ICAgICAgIH0NCj4gDQo+IC0gICAgZXhwID0gbmJkX2V4cG9ydF9u ZXcoYnMsIGRldl9vZmZzZXQsIGZkX3NpemUsIG5iZGZsYWdzLCBuYmRfZXhwb3J0X2Nsb3NlZCwN Cj4gKyAgICBleHAgPSBuYmRfZXhwb3J0X25ldyhicywgZGV2X29mZnNldCwgZmRfc2l6ZSwgZXhw b3J0X25hbWUsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgZXhwb3J0X2Rlc2NyaXB0aW9u LCBuYmRmbGFncywgbmJkX2V4cG9ydF9jbG9zZWQsDQo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHdyaXRldGhyb3VnaCwgTlVMTCwgJmVycm9yX2ZhdGFsKTsNCj4gLSAgICBuYmRfZXhwb3J0 X3NldF9uYW1lKGV4cCwgZXhwb3J0X25hbWUpOw0KPiAtICAgIG5iZF9leHBvcnRfc2V0X2Rlc2Ny aXB0aW9uKGV4cCwgZXhwb3J0X2Rlc2NyaXB0aW9uKTsNCj4gDQo+ICAgICAgIGlmIChkZXZpY2Up IHsNCj4gICAjaWYgSEFWRV9OQkRfREVWSUNFDQo+IA0KDQoNCi0tIA0KQmVzdCByZWdhcmRzLA0K VmxhZGltaXINCg==