From: "its_Giaan (Code Review)"
Date: Tue, 21 Apr 2026 15:20:38 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, antonio@...2726...
Message-ID: <7c364b77cdf6a5aa655ff43b3710ed7655c3466f-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="IxSvyeZbRsg="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Multisocket: use
event engine rwflags for UDP I/O
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , openvpn-devel
--IxSvyeZbRsg=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos.
its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.=
openvpn.net/c/openvpn/+/1635?usp=3Demail )
Change subject: Multisocket: use event engine rwflags for UDP I/O
......................................................................
Patch Set 2:
(1 comment)
File src/openvpn/mudp.c:
http://gerrit.openvpn.net/c/openvpn/+/1635/comment/b423be31_f2681555?usp=3D=
email :
PS1, Line 341: const unsigned int status =3D rwflags;
> I think we can remove `status` and directly use `rwflags` throughout the =
function body?
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1635?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6b303805a3688b6f6363140c76853a58badecd8f
Gerrit-Change-Number: 1635
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: ordex
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: ordex
Gerrit-Comment-Date: Tue, 21 Apr 2026 15:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
--IxSvyeZbRsg=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: ordex, plaisthos.
View =
Change
1 comment:
=
File src/openvpn/mudp.c:
Done
To view, visit change 1635. To unsubscribe,=
or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6b303805a3688b6f6363140c768=
53a58badecd8f
Gerrit-Change-Number: 1635
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: ordex <antonio@...2726...&=
gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Tue, 21 Apr 2026 15:20:38=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
=
--IxSvyeZbRsg=--