Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E841C433DB for ; Fri, 15 Jan 2021 08:42:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4485422C7D for ; Fri, 15 Jan 2021 08:42:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4485422C7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADF3A6E1B2; Fri, 15 Jan 2021 08:42:40 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 890D06E1B2 for ; Fri, 15 Jan 2021 08:42:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1974DB729; Fri, 15 Jan 2021 08:42:37 +0000 (UTC) Subject: Re: [PATCH] drm/hisilicon/hibmc: Remove hibmc_ttm.c To: tiantao6@hisilicon.com References: <20210113113107.12005-1-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: <7c5611ac-772e-6529-6072-e192d05c916d@suse.de> Date: Fri, 15 Jan 2021 09:42:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113113107.12005-1-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xinliang Liu , Chen Feng , dri-devel@lists.freedesktop.org, Gong junjie , Xinwei Kong , Daniel Vetter , Sam Ravnborg Content-Type: multipart/mixed; boundary="===============1416272286==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1416272286== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VHOLXA5VTXUoN4JVrjVjdYUhJro7H7nu3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VHOLXA5VTXUoN4JVrjVjdYUhJro7H7nu3 Content-Type: multipart/mixed; boundary="0giusCf8M19XCjkJzIjgWTwoCrZsMFGRm"; protected-headers="v1" From: Thomas Zimmermann To: tiantao6@hisilicon.com Cc: dri-devel@lists.freedesktop.org, Sam Ravnborg , Xinliang Liu , John Stultz , Xinwei Kong , Chen Feng , Daniel Vetter , Gong junjie Message-ID: <7c5611ac-772e-6529-6072-e192d05c916d@suse.de> Subject: Re: [PATCH] drm/hisilicon/hibmc: Remove hibmc_ttm.c References: <20210113113107.12005-1-tzimmermann@suse.de> In-Reply-To: <20210113113107.12005-1-tzimmermann@suse.de> --0giusCf8M19XCjkJzIjgWTwoCrZsMFGRm Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable ping for review Am 13.01.21 um 12:31 schrieb Thomas Zimmermann: > The file is not in use. It got re-added by a rebased patch. Removing > it. >=20 > Signed-off-by: Thomas Zimmermann > Fixes: 4d4dad21cc7b ("drm/hibmc: Remove references to struct drm_device= =2Epdev") > Reported-by: Tian Tao > Cc: Sam Ravnborg > Cc: Xinliang Liu > Cc: Tian Tao > Cc: John Stultz > Cc: Xinwei Kong > Cc: Chen Feng > Cc: Daniel Vetter > Cc: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 61 --------------------= - > 1 file changed, 61 deletions(-) > delete mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c >=20 > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c b/drivers/gpu/= drm/hisilicon/hibmc/hibmc_ttm.c > deleted file mode 100644 > index 77f075075db2..000000000000 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c > +++ /dev/null > @@ -1,61 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-or-later > -/* Hisilicon Hibmc SoC drm driver > - * > - * Based on the bochs drm driver. > - * > - * Copyright (c) 2016 Huawei Limited. > - * > - * Author: > - * Rongrong Zou > - * Rongrong Zou > - * Jianhua Li > - */ > - > -#include > - > -#include > -#include > -#include > -#include > -#include > - > -#include "hibmc_drm_drv.h" > - > -int hibmc_mm_init(struct hibmc_drm_private *hibmc) > -{ > - struct drm_vram_mm *vmm; > - int ret; > - struct drm_device *dev =3D hibmc->dev; > - struct pci_dev *pdev =3D to_pci_dev(dev->dev); > - > - vmm =3D drm_vram_helper_alloc_mm(dev, pci_resource_start(pdev, 0), > - hibmc->fb_size); > - if (IS_ERR(vmm)) { > - ret =3D PTR_ERR(vmm); > - drm_err(dev, "Error initializing VRAM MM; %d\n", ret); > - return ret; > - } > - > - return 0; > -} > - > -void hibmc_mm_fini(struct hibmc_drm_private *hibmc) > -{ > - if (!hibmc->dev->vram_mm) > - return; > - > - drm_vram_helper_release_mm(hibmc->dev); > -} > - > -int hibmc_dumb_create(struct drm_file *file, struct drm_device *dev, > - struct drm_mode_create_dumb *args) > -{ > - return drm_gem_vram_fill_create_dumb(file, dev, 0, 128, args); > -} > - > -const struct drm_mode_config_funcs hibmc_mode_funcs =3D { > - .mode_valid =3D drm_vram_helper_mode_valid, > - .atomic_check =3D drm_atomic_helper_check, > - .atomic_commit =3D drm_atomic_helper_commit, > - .fb_create =3D drm_gem_fb_create, > -}; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --0giusCf8M19XCjkJzIjgWTwoCrZsMFGRm-- --VHOLXA5VTXUoN4JVrjVjdYUhJro7H7nu3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmABVXsFAwAAAAAACgkQlh/E3EQov+CQ fRAAyYaHKPigxQSf/eQGbLFrqxY7o2cudjJHmlPnkwhYF7slvbcxvWUH9r4g/VoHXTMGvGpsi+Pn zB3kB63+0TUSF4k9bQ7Z9b+O03dt3kSrfImvnEuYfCtfu1eobklj5jLB1SzrZRAvcgIXu/tyir/s PWNsPBrLvK/jGG5t48IEE8r1/GuoCwJCSyf+8stIZh9YBF6Nn8LqT6oWv/AQcNwIkya/GfwAQ9LZ 10JkUSd5HCMcmVmCFa8D1k6YPULrPmmA2UUbR1SeLYPZXRCP7D/TWOuEJH72eVMBNpFdhDXChGJZ Kghra1dvvP1BN/lq2neUZWrmdQECm79fZLzx4Jdd31nn0Edr6mfgWxfMDAA+Bbtm3txH3qPO5y0R H+6ixLmvhyzYpR0yHApv5rs7ZRa8HV7IvGVN/Of0PqWWHRNrgHA/2rcdR/v5TrUqDd8d81z9qJIW fyJOJn1Mnwsz5GkT8GV52XxqVhxTOM2xNwJZOtqPCNows935yoNFYppOPPrh1qCgU4qbovi+Ao7p 5luh004NZTrd6Xhz9o/Sp2m590Q2h6GUmMr0Odt7RqYbaZx7dWbFXXrq3eeJD/OURq288Dp0wjpn IjaxPbmQ3mkI0kWVozPj+gZb9WTsUI+tpEnXkBI0x4XQW19rO3etF2Lh3d8Tw4rYXlDA9b9+93KB z8o= =MqkA -----END PGP SIGNATURE----- --VHOLXA5VTXUoN4JVrjVjdYUhJro7H7nu3-- --===============1416272286== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1416272286==--