From: "its_Giaan (Code Review)"
Date: Tue, 12 Mar 2024 11:27:31 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <7c7dc53c2ac227f030acfcf4a0253a5794fda57d-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="Nv+qaKFNdQA="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug
preventing proxy credentials caching
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , plaisthos , openvpn-devel
--Nv+qaKFNdQA=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/523?usp=3Demail )
Change subject: Http-proxy: fix bug preventing proxy credentials caching
......................................................................
Patch Set 6:
(2 comments)
File src/openvpn/proxy.c:
http://gerrit.openvpn.net/c/openvpn/+/523/comment/42ea2ef6_c71a07f0 :
PS6, Line 299: else if (!static_proxy_user_pass.nocache)
> Do not actually need to check for nocache here. Since it will never be de=
fined when nocache is set. [=E2=80=A6]
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/523/comment/19fd5e77_9975a90f :
PS6, Line 304: else if (static_proxy_user_pass.nocache && !force)
> I think this condition is too complicated. [=E2=80=A6]
I think we need it otherwise in case of nocache true creds would be wiped a=
t the first call of the get_user_pass() and then asked again at the second =
call (the one with force =3D=3D false), by checking force we know that we'r=
e at the second call of the function so we can clear previous creds since w=
e don't need them anymore.
Totally agree about the "else".
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 6
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 12 Mar 2024 11:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--Nv+qaKFNdQA=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View C=
hange
2 comments:
Acknowledged
Patch Set #6, Line 304: else if (static_proxy_user_pass.no=
cache && !force)
I think this condition is to=
o complicated. [=E2=80=A6]
I think we need it otherwise in case of nocache =
true creds would be wiped at the first call of the get_user_pass() and then=
asked again at the second call (the one with force =3D=3D false), by check=
ing force we know that we're at the second call of the function so we c=
an clear previous creds since we don't need them anymore.
Totally a=
gree about the "else".
To view, visit <=
a href=3D"http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail">change 523=
. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279=
fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 6
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Tue, 12 Mar 2024 11:27:31=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--Nv+qaKFNdQA=--