From: "flichtenheld (Code Review)" Date: Mon, 2 Jun 2025 14:58:32 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <7cf6d6faae2f41fd8ab4de7bd235e5eea91c6fc4-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tZJz+F2hQLo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Do not segfault on missing --dh in server config List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --tZJz+F2hQLo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=3Demail to review the following change. Change subject: Do not segfault on missing --dh in server config ...................................................................... Do not segfault on missing --dh in server config Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1 Signed-off-by: Frank Lichtenheld --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/1037/1 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 0d648ba..b9708343 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3698,7 +3698,7 @@ if (o->tls_server) { - if (streq(o->dh_file, "none")) + if (o->dh_file && streq(o->dh_file, "none")) { o->dh_file =3D NULL; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1 Gerrit-Change-Number: 1037 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --tZJz+F2hQLo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

Do not segfault on missing --dh in server config

Chan= ge-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Signed-off-by: Frank Li= chtenheld <frank@...2641...>
---
M src/openvpn/options.c
1 f= ile changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.=
openvpn.net:29418/openvpn refs/changes/37/1037/1
diff --git a/src/o=
penvpn/options.c b/src/openvpn/options.c
index 0d648ba..b97= 08343 100644
--- a/src/openvpn/options.c
++= + b/src/openvpn/options.c
@@ -3698,7 +3698,7 @@
<= span>
if (o->tls_server)
{
- if (streq(o->= dh_file, "none"))
+ if (o->dh_file && streq(o->dh_file, "non= e"))
{
o->dh_= file =3D NULL;
}

=

To view, visit change 1037. To unsubscribe, or for help writing mail filters= , visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e13595c1057c680e1065eae84c= a94b273ed9ca1
Gerrit-Change-Number: 1037
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--tZJz+F2hQLo=--