Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC64DEA8 for ; Fri, 2 Jun 2023 00:46:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2FA7C433D2; Fri, 2 Jun 2023 00:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685666771; bh=zR/sLkaKZ4SOUbNFRoS296eVn2Zg3FLbTR94vJXNZgY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Erzi9NlnIJH7tqfXU12Q2WNaWlXNNOGk8TrBARAioPR0O/ZUmFEXKVE3i7/RmKHqB ro3Z43l5qxjLGwmSEyd5Nae4mAhFK0dC4dYx4QtSChA6y9b8X2yKiLl8tKhdpwVisw IMggx4DZM57GPltoGCS9xKzpLSuplIpBsg7bRUOIpi6tJSDbu7i1tJNzWej2Kjc3oR 9nWv3TAQNQSAsya9II1IqFpv8CAyV6RHKo3jZfpOtgW4izUo981qj8HWUZR1+MxH+Y xPvyL/MbO0hJkOY3g0eRz6TP7MWY6M3KQpegaqwUEisRlYsKqneLyTsTRGJZ7wdun1 u8JsUwql7JDag== Message-ID: <7d28139c-c348-c5cc-1e5f-b58b99772905@kernel.org> Date: Thu, 1 Jun 2023 18:46:10 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH net 1/2] net/ipv6: fix bool/int mismatch for skip_notify_on_dev_down Content-Language: en-US To: Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, Matthieu Baerts , eric.dumazet@gmail.com References: <20230601160445.1480257-1-edumazet@google.com> <20230601160445.1480257-2-edumazet@google.com> From: David Ahern In-Reply-To: <20230601160445.1480257-2-edumazet@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/1/23 10:04 AM, Eric Dumazet wrote: > skip_notify_on_dev_down ctl table expects this field > to be an int (4 bytes), not a bool (1 byte). > > Because proc_dou8vec_minmax() was added in 5.13, > this patch converts skip_notify_on_dev_down to an int. > > Following patch then converts the field to u8 and use proc_dou8vec_minmax(). > > Fixes: 7c6bb7d2faaf ("net/ipv6: Add knob to skip DELROUTE message on device down") > Signed-off-by: Eric Dumazet > Cc: David Ahern > --- > include/net/netns/ipv6.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern