From: Maarten Lankhorst Subject: Re: [PATCH v5 4/5] drm: Connector helper function to release resources Date: Thu, 30 Mar 2017 12:36:02 +0200 Message-ID: <7d2ff402-2b58-bc16-4b16-97b288ae387d@linux.intel.com> References: <1490863330-5359-1-git-send-email-dhinakaran.pandiyan@intel.com> <1490863330-5359-5-git-send-email-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1490863330-5359-5-git-send-email-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Archit Taneja , Harry Wentland , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMzAtMDMtMTcgb20gMTA6NDIgc2NocmVlZiBEaGluYWthcmFuIFBhbmRpeWFuOgo+IEZyb206 ICJQYW5kaXlhbiwgRGhpbmFrYXJhbiIgPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ Cj4gSGF2aW5nIGFuIC0+YXRvbWljX3JlbGVhc2UgY2FsbGJhY2sgaXMgdXNlZnVsIHRvIHJlbGVh c2Ugc2hhcmVkIHJlc291cmNlcwo+IHRoYXQgZ2V0IGFsbG9jYXRlZCBpbiBjb21wdXRlX2NvbmZp ZygpLiBUaGlzIGZ1bmN0aW9uIGlzIGV4cGVjdGVkIHRvIGJlCj4gY2FsbGVkIGluIHRoZSBhdG9t aWNfY2hlY2soKSBwaGFzZSBiZWZvcmUgbmV3IHJlc291cmNlcyBhcmUgYWNxdWlyZWQuCj4KPiB2 NDogRG9jdW1lbnQgdGhhdCB0aGUgZnVuY3Rpb24gaXMgY29uZGl0aW9uYWxseSBjYWxsZWQgYW5k IGJlZm9yZQo+IG90aGVyIGF0b21pY19jaGVja3MoKSAoRGFuaWVsKQo+IHYzOiBVc2UgdGhlIG5l dyAnZm9yX2VhY2hfb2xkbmV3X2Nvbm5lY3Rvcl9pbl9zdGF0ZSgpJyBtYWNyby4KPiB2MjogTW92 ZWQgdGhlIGNhbGxlciBodW5rIHRvIHRoaXMgcGF0Y2ggKERhbmllbCkKPgo+IENjOiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8 bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBBcmNoaXQgVGFuZWphIDxh cmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogSGFycnkgV2VudGxhbmQgPEhhcnJ5LndlbnRsYW5kQGFtZC5jb20+ Cj4gUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51 eC5pbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+Cj4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4u cGFuZGl5YW5AaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyAgICAgIHwgMTkgKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1f bW9kZXNldF9oZWxwZXJfdnRhYmxlcy5oIHwgMTYgKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVz IGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jCj4gaW5kZXggZDE0MDk0ZC4uOWQwNzY2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X2hlbHBlci5jCj4gQEAgLTU4Niw2ICs1ODYsMjUgQEAgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tf bW9kZXNldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCX0KPiAgCX0KPiAgCj4gKwlmb3Jf ZWFjaF9vbGRuZXdfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIG9sZF9jb25u ZWN0b3Jfc3RhdGUsIG5ld19jb25uZWN0b3Jfc3RhdGUsIGkpIHsKPiArCQljb25zdCBzdHJ1Y3Qg ZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MgKmNvbm5fZnVuY3M7Cj4gKwkJc3RydWN0IGRybV9j cnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ICsKPiArCQljb25uX2Z1bmNzID0gY29ubmVjdG9yLT5o ZWxwZXJfcHJpdmF0ZTsKPiArCQlpZiAoIWNvbm5fZnVuY3MtPmF0b21pY19yZWxlYXNlKQo+ICsJ CQljb250aW51ZTsKPiArCj4gKwkJaWYgKCFvbGRfY29ubmVjdG9yX3N0YXRlLT5jcnRjKQo+ICsJ CQljb250aW51ZTsKPiArCj4gKwkJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5n X2NydGNfc3RhdGUoc3RhdGUsIG9sZF9jb25uZWN0b3Jfc3RhdGUtPmNydGMpOwo+ICsKPiArCQlp ZiAoY3J0Y19zdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkIHx8Cj4gKwkJICAgIGNydGNfc3RhdGUt Pm1vZGVfY2hhbmdlZCB8fAo+ICsJCSAgICAoY3J0Y19zdGF0ZS0+YWN0aXZlX2NoYW5nZWQgJiYg IWNydGNfc3RhdGUtPmFjdGl2ZSkpCj4gKwkJCWNvbm5fZnVuY3MtPmF0b21pY19yZWxlYXNlKGNv bm5lY3RvciwgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7Cj4gKwl9Cj4gKwo+ICAJcmV0dXJuIG1vZGVf Zml4dXAoc3RhdGUpOwo+ICB9Ck9vcHMsIEknbSBqdXN0IGxvb2tpbmcgYXQgcGF0Y2ggNSBhZ2Fp bi4uCgphdG9taWNfcmVsZWFzZSBzaG91bGQgcmV0dXJuIGFuIGludCB0byBhbGxvdyBlcnJvciBw cm9wb2dhdGlvbi4gVGhlcmUncyBubyBnb29kIHJlYXNvbiB3aHkgaXQgc2hvdWxkbid0LgpUaGlz IHdvdWxkIGFsbG93IGhhbmRsaW5nIGVycm9ycyBpbiBwYXRjaCA1IG1vcmUgZ3JhY2VmdWxseS4K PiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KTsKPiBkaWZm IC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMuaCBiL2luY2x1 ZGUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlcl92dGFibGVzLmgKPiBpbmRleCAwOTFjNDIyLi44NGU4 MGFhIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlcl92dGFibGVz LmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fbW9kZXNldF9oZWxwZXJfdnRhYmxlcy5oCj4gQEAg LTgzNiw2ICs4MzYsMjIgQEAgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzIHsKPiAg CSAqLwo+ICAJc3RydWN0IGRybV9lbmNvZGVyICooKmF0b21pY19iZXN0X2VuY29kZXIpKHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJCQkJCSAgIHN0cnVjdCBkcm1fY29ubmVj dG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGUpOwo+ICsKPiArCS8qKgo+ICsJICogQGF0b21pY19y ZWxlYXNlOgo+ICsJICoKPiArCSAqIFRoaXMgZnVuY3Rpb24gaXMgY29uZGl0aW9uYWxseSBjYWxs ZWQgdG8gcmVsZWFzZSBzaGFyZWQgcmVzb3VyY2VzCj4gKwkgKiB3aGVuIHRoZSBhdHRhY2hlZCBD UlRDJ3MgbW9kZSBjaGFuZ2VzIG9yIGl0J3MgY29ubmVjdG9ycyBjaGFuZ2Ugb3IKPiArCSAqIGJl Y29tZXMgaW5hY3RpdmUuIEl0IGlzIGNhbGxlZCBiZWZvcmUgdGhlIGNvcnJlc3BvbmRpbmcKPiAr CSAqICZkcm1fY3J0Y19oZWxwZXJfZnVuY3MuYXRvbWljX2NoZWNrIG9yCj4gKwkgKiAmZHJtX2Ny dGNfaGVscGVyX2Z1bmNzLm1vZGVfZml4dXAgaG9va3MgYXJlIGNhbGxlZC4KPiArCSAqCj4gKwkg KiBOT1RFOgo+ICsJICoKPiArCSAqIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGluIHRoZSBjaGVj ayBwaGFzZSBvZiBhbiBhdG9taWMgdXBkYXRlLgo+ICsJICovCj4gKwl2b2lkICgqYXRvbWljX3Jl bGVhc2UpKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJCSAgICAgICBzdHJ1 Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubmVjdG9yX3N0YXRlKTsKPiAgfTsKPiAgCj4gIC8q KgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=