From: "plaisthos (Code Review)" Date: Fri, 23 Jan 2026 13:33:28 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., steffan@...1856..., max@...2606... Message-ID: <7d3ca09c70a16e6b79ed66f91f1bab23f4c0eb1a-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="nqLoFZ/euZg="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF Cc: flichtenheld , syzzer , openvpn-devel --nqLoFZ/euZg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, syzzer. plaisthos has posted comments on this change by MaxF. ( http://gerrit.openv= pn.net/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 7: Code-Review+2 (2 comments) File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/32a319ea_8293f4ed?usp=3D= email : PS7, Line 611: { "SHA256", PSA_ALG_SHA_256 }, We probably want to a few more of the common algorithms here in a follow up= commit or in the next version of this commit. At least SHA384 and SHA512 a= re pretty common and SHA224 wouldn't hurt either. #define PSA_ALG_SHA3_224 ((psa_algorithm_t) 0x020000= 10) /** SHA3-256 */ #define PSA_ALG_SHA3_256 ((psa_algorithm_t) 0x020000= 11) /** SHA3-384 */ #define PSA_ALG_SHA3_384 ((psa_algorithm_t) 0x020000= 12) /** SHA3-512 */ #define PSA_ALG_SHA3_512 ((psa_algorithm_t) 0x020000= 13) seem also good candidates to already add here to future proof it a bit. File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/3877c185_ffe25e3e?usp=3D= email : PS7, Line 362: { "X25519", MBEDTLS_SSL_IANA_TLS_GROUP_X25519 }, MBEDTLS_SSL_IANA_TLS_GROUP_X448 should also be added here I think. Also secp521r1. For the european context in goverment stuff, often the brai= n pool curves are also used, so I am surprised they are missing here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 7 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: syzzer Gerrit-Attention: MaxF Gerrit-Comment-Date: Fri, 23 Jan 2026 13:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --nqLoFZ/euZg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, syzzer.

Patch set 7:Code-Review +2=

V= iew Change

2 comments:

  • File src/openvpn/crypto_mbedtl= s.c:

    • P= atch Set #7, Line 611: = { "SHA256", PSA_ALG_SHA_256 },

      We probably want to= a few more of the common algorithms here in a follow up commit or in the n= ext version of this commit. At least SHA384 and SHA512 are pretty common an= d SHA224 wouldn't hurt either.

      #define PSA_ALG_SHA3_224 = ((psa_algorithm_t) 0x02000010)
      /** SHA3-256 */
      #define PS= A_ALG_SHA3_256 ((psa_algorithm_t) 0x02000011)
      /**= SHA3-384 */
      #define PSA_ALG_SHA3_384 ((psa_algor= ithm_t) 0x02000012)
      /** SHA3-512 */
      #define PSA_ALG_SHA3_512 = ((psa_algorithm_t) 0x02000013)

      seem also good candidate= s to already add here to future proof it a bit.

  • File src/openvpn/ssl_mbedtls.c:

    • Patch Set #7, Line= 362: { "X2551= 9", MBEDTLS_SSL_IANA_TLS_GROUP_X25519 },

      MBEDTLS_SSL_IANA_T= LS_GROUP_X448 should also be added here I think.

      Also secp521r1. For th= e european context in goverment stuff, often the brain pool curves are also= used, so I am surprised they are missing here.

T= o view, visit change 1441. To unsubscribe, or for help writing mail filters, vi= sit settings= .

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 7
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Fri, 23 Jan 2026 13:33:28= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --nqLoFZ/euZg=--