From: "Souza, Jose" Subject: Re: [PATCH v3 2/4] drm/i915: Enable edp psr error interrupts on bdw+ Date: Thu, 5 Apr 2018 20:38:02 +0000 Message-ID: <7d589e16956402750eed198f44aef668d3224b5a.camel@intel.com> References: <20180403212420.25007-1-dhinakaran.pandiyan@intel.com> <20180403212420.25007-2-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 466746E8B1 for ; Thu, 5 Apr 2018 20:38:04 +0000 (UTC) In-Reply-To: <20180403212420.25007-2-dhinakaran.pandiyan@intel.com> Content-Language: en-US Content-ID: <283C420AB196BA4497BCC0E0E30D6BD7@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" Cc: "daniel.vetter@ffwll.ch" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE4LTA0LTAzIGF0IDE0OjI0IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOg0KPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPg0KPiANCj4gUGx1ZyBpbiB0aGUgYmR3KyBpcnEgaGFuZGxpbmcgZm9yIFBTUiBpbnRlcnJ1 cHRzLiBiZHcrIHN1cHBvcnRzIHBzcg0KPiBvbg0KPiBhbnkgdHJhbnNjb2RlciBpbiB0aGVvcnks IHRob3VnaCB0aGUgd2UgZG9uJ3QgY3VycmVudHkgZW5hYmxlIFBTUg0KPiBleGNlcHQNCj4gb24g dGhlIEVEUCB0cmFuc2NvZGVyLg0KPiANCj4gdjI6IEZyb20gREsNCj4gICogUmViYXNlZCBvbiBk cm0tdGlwDQo+IHYzOiBTd2l0Y2hlZCBhdXRob3IgdG8gVmlsbGUgYmFzZWQgb24gSVJDIGRpc2N1 c3Npb24uDQo+IA0KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPg0K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4NCg0KUmV2aWV3ZWQt Ynk6IEpvc2UgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+DQoNCj4gU2ln bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4NCj4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEu YyAgICAgIHwgNTcNCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tDQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgfCAgNyArKystLQ0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5oIHwgIDQgKysrDQo+ICAzIGZpbGVzIGNoYW5n ZWQsIDUyIGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMNCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2lycS5jDQo+IGluZGV4IGMyZDNmMzA3NzhlZS4uOGE4OTRhZGYyY2ExIDEwMDY0NA0K PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jDQo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfaXJxLmMNCj4gQEAgLTIzOTQsMjAgKzIzOTQsMzQgQEAgc3RhdGlj IHZvaWQgaWxrX2Rpc3BsYXlfaXJxX2hhbmRsZXIoc3RydWN0DQo+IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LA0KPiAgc3RhdGljIHZvaWQgaHN3X2VkcF9wc3JfaXJxX2hhbmRsZXIoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUNCj4gKmRldl9wcml2KQ0KDQpuaXRwaWNrOiBMaWtlIEkgc2FpZCBp biB0aGUgb3RoZXIgcGF0Y2ggSSB3b3VsZCBsaWtlIHRvIGhhdmUgdGhpcw0KZnVuY3Rpb24gcmVu YW1lZCBoZXJlLg0KDQo+ICB7DQo+ICAJdTMyIGVkcF9wc3JfaWlyID0gSTkxNV9SRUFEKEVEUF9Q U1JfSUlSKTsNCj4gKwl1MzIgZWRwX3Bzcl9pbXIgPSBJOTE1X1JFQUQoRURQX1BTUl9JTVIpOw0K PiArCXUzMiBtYXNrID0gQklUKFRSQU5TQ09ERVJfRURQKTsNCj4gKwllbnVtIHRyYW5zY29kZXIg Y3B1X3RyYW5zY29kZXI7DQo+ICANCj4gLQlpZiAoZWRwX3Bzcl9paXIgJiBFRFBfUFNSX0VSUk9S KQ0KPiAtCQlEUk1fREVCVUdfS01TKCJQU1IgZXJyb3JcbiIpOw0KPiAtDQo+IC0JaWYgKGVkcF9w c3JfaWlyICYgRURQX1BTUl9QUkVfRU5UUlkpIHsNCj4gLQkJRFJNX0RFQlVHX0tNUygiUFNSIHBy ZXBhcmUgZW50cnkgaW4gMiB2YmxhbmtzXG4iKTsNCj4gLQkJSTkxNV9XUklURShFRFBfUFNSX0lN UiwgRURQX1BTUl9QUkVfRU5UUlkpOw0KPiAtCX0NCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA+PSA4KQ0KPiArCQltYXNrIHw9IEJJVChUUkFOU0NPREVSX0EpIHwNCj4gKwkJCUJJVChUUkFO U0NPREVSX0IpIHwNCj4gKwkJCUJJVChUUkFOU0NPREVSX0MpOw0KPiArDQo+ICsJZm9yX2VhY2hf Y3B1X3RyYW5zY29kZXJfbWFza2VkKGRldl9wcml2LCBjcHVfdHJhbnNjb2RlciwNCj4gbWFzaykg ew0KPiArCQlpZiAoZWRwX3Bzcl9paXIgJiBFRFBfUFNSX0VSUk9SKGNwdV90cmFuc2NvZGVyKSkN Cj4gKwkJCURSTV9ERUJVR19LTVMoIlRyYW5zY29kZXIgJXMgUFNSIGVycm9yXG4iLA0KPiArCQkJ CSAgICAgIHRyYW5zY29kZXJfbmFtZShjcHVfdHJhbnNjb2Rlcg0KPiApKTsNCj4gKw0KPiArCQlp ZiAoZWRwX3Bzcl9paXIgJiBFRFBfUFNSX1BSRV9FTlRSWShjcHVfdHJhbnNjb2RlcikpDQo+IHsN Cj4gKwkJCURSTV9ERUJVR19LTVMoIlRyYW5zY29kZXIgJXMgUFNSIHByZXBhcmUNCj4gZW50cnkg aW4gMiB2YmxhbmtzXG4iLA0KPiArCQkJCSAgICAgIHRyYW5zY29kZXJfbmFtZShjcHVfdHJhbnNj b2Rlcg0KPiApKTsNCj4gKwkJCWVkcF9wc3JfaW1yIHw9DQo+IEVEUF9QU1JfUFJFX0VOVFJZKGNw dV90cmFuc2NvZGVyKTsNCj4gKwkJfQ0KPiAgDQo+IC0JaWYgKGVkcF9wc3JfaWlyICYgRURQX1BT Ul9QT1NUX0VYSVQpIHsNCj4gLQkJRFJNX0RFQlVHX0tNUygiUFNSIGV4aXQgY29tcGxldGVkXG4i KTsNCj4gLQkJSTkxNV9XUklURShFRFBfUFNSX0lNUiwgMCk7DQo+ICsJCWlmIChlZHBfcHNyX2lp ciAmIEVEUF9QU1JfUE9TVF9FWElUKGNwdV90cmFuc2NvZGVyKSkNCj4gew0KPiArCQkJRFJNX0RF QlVHX0tNUygiVHJhbnNjb2RlciAlcyBQU1IgZXhpdA0KPiBjb21wbGV0ZWRcbiIsDQo+ICsJCQkJ ICAgICAgdHJhbnNjb2Rlcl9uYW1lKGNwdV90cmFuc2NvZGVyDQo+ICkpOw0KPiArCQkJZWRwX3Bz cl9pbXIgJj0NCj4gfkVEUF9QU1JfUFJFX0VOVFJZKGNwdV90cmFuc2NvZGVyKTsNCj4gKwkJfQ0K PiAgCX0NCj4gIA0KPiArCUk5MTVfV1JJVEUoRURQX1BTUl9JTVIsIGVkcF9wc3JfaW1yKTsNCj4g IAlJOTE1X1dSSVRFKEVEUF9QU1JfSUlSLCBlZHBfcHNyX2lpcik7DQo+ICB9DQo+ICANCj4gQEAg LTI1NTUsMTEgKzI1NjksMjIgQEAgZ2VuOF9kZV9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZQ0KPiAqZGV2X3ByaXYsIHUzMiBtYXN0ZXJfY3RsKQ0KPiAgCWlmIChtYXN0ZXJfY3Rs ICYgR0VOOF9ERV9NSVNDX0lSUSkgew0KPiAgCQlpaXIgPSBJOTE1X1JFQUQoR0VOOF9ERV9NSVND X0lJUik7DQo+ICAJCWlmIChpaXIpIHsNCj4gKwkJCWJvb2wgZm91bmQgPSBmYWxzZTsNCj4gKw0K PiAgCQkJSTkxNV9XUklURShHRU44X0RFX01JU0NfSUlSLCBpaXIpOw0KPiAgCQkJcmV0ID0gSVJR X0hBTkRMRUQ7DQo+IC0JCQlpZiAoaWlyICYgR0VOOF9ERV9NSVNDX0dTRSkNCj4gKw0KPiArCQkJ aWYgKGlpciAmIEdFTjhfREVfTUlTQ19HU0UpIHsNCj4gIAkJCQlpbnRlbF9vcHJlZ2lvbl9hc2xl X2ludHIoZGV2X3ByaXYpOw0KPiAtCQkJZWxzZQ0KPiArCQkJCWZvdW5kID0gdHJ1ZTsNCj4gKwkJ CX0NCj4gKw0KPiArCQkJaWYgKGlpciAmIEdFTjhfREVfRURQX1BTUikgew0KPiArCQkJCWhzd19l ZHBfcHNyX2lycV9oYW5kbGVyKGRldl9wcml2KTsNCj4gKwkJCQlmb3VuZCA9IHRydWU7DQo+ICsJ CQl9DQo+ICsNCj4gKwkJCWlmICghZm91bmQpDQo+ICAJCQkJRFJNX0VSUk9SKCJVbmV4cGVjdGVk IERFIE1pc2MNCj4gaW50ZXJydXB0XG4iKTsNCj4gIAkJfQ0KPiAgCQllbHNlDQo+IEBAIC0zMzI2 LDYgKzMzNTEsOSBAQCBzdGF0aWMgdm9pZCBnZW44X2lycV9yZXNldChzdHJ1Y3QgZHJtX2Rldmlj ZQ0KPiAqZGV2KQ0KPiAgDQo+ICAJZ2VuOF9ndF9pcnFfcmVzZXQoZGV2X3ByaXYpOw0KPiAgDQo+ ICsJSTkxNV9XUklURShFRFBfUFNSX0lNUiwgMHhmZmZmZmZmZik7DQo+ICsJSTkxNV9XUklURShF RFBfUFNSX0lJUiwgMHhmZmZmZmZmZik7DQo+ICsNCj4gIAlmb3JfZWFjaF9waXBlKGRldl9wcml2 LCBwaXBlKQ0KPiAgCQlpZiAoaW50ZWxfZGlzcGxheV9wb3dlcl9pc19lbmFibGVkKGRldl9wcml2 LA0KPiAgCQkJCQkJICAgUE9XRVJfRE9NQUlOX1BJUEUNCj4gKHBpcGUpKSkNCj4gQEAgLTM4MTUs NyArMzg0Myw3IEBAIHN0YXRpYyB2b2lkIGdlbjhfZGVfaXJxX3Bvc3RpbnN0YWxsKHN0cnVjdA0K PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikNCj4gIAl1aW50MzJfdCBkZV9waXBlX2VuYWJs ZXM7DQo+ICAJdTMyIGRlX3BvcnRfbWFza2VkID0gR0VOOF9BVVhfQ0hBTk5FTF9BOw0KPiAgCXUz MiBkZV9wb3J0X2VuYWJsZXM7DQo+IC0JdTMyIGRlX21pc2NfbWFza2VkID0gR0VOOF9ERV9NSVND X0dTRTsNCj4gKwl1MzIgZGVfbWlzY19tYXNrZWQgPSBHRU44X0RFX01JU0NfR1NFIHwgR0VOOF9E RV9FRFBfUFNSOw0KPiAgCWVudW0gcGlwZSBwaXBlOw0KPiAgDQo+ICAJaWYgKElOVEVMX0dFTihk ZXZfcHJpdikgPj0gOSkgew0KPiBAQCAtMzg0MCw2ICszODY4LDkgQEAgc3RhdGljIHZvaWQgZ2Vu OF9kZV9pcnFfcG9zdGluc3RhbGwoc3RydWN0DQo+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQ0KPiAgCWVsc2UgaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikpDQo+ICAJCWRlX3BvcnRfZW5h YmxlcyB8PSBHRU44X1BPUlRfRFBfQV9IT1RQTFVHOw0KPiAgDQo+ICsJZ2VuM19hc3NlcnRfaWly X2lzX3plcm8oZGV2X3ByaXYsIEVEUF9QU1JfSUlSKTsNCj4gKwlJOTE1X1dSSVRFKEVEUF9QU1Jf SU1SLCAwKTsNCj4gKw0KPiAgCWZvcl9lYWNoX3BpcGUoZGV2X3ByaXYsIHBpcGUpIHsNCj4gIAkJ ZGV2X3ByaXYtPmRlX2lycV9tYXNrW3BpcGVdID0gfmRlX3BpcGVfbWFza2VkOw0KPiAgDQo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oDQo+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiBpbmRleCBmNTc4M2Q2ZGI2MTQuLjZlYjM1MTE3N2E2 OCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oDQo+IEBAIC00MDE0LDkgKzQwMTQsOSBA QCBlbnVtIHsNCj4gIC8qIEJzcGVjIGNsYWltcyB0aG9zZSBhcmVuJ3Qgc2hpZnRlZCBidXQgc3Rh eSBhdCAweDY0ODAwICovDQo+ICAjZGVmaW5lIEVEUF9QU1JfSU1SCQkJCV9NTUlPKDB4NjQ4MzQp DQo+ICAjZGVmaW5lIEVEUF9QU1JfSUlSCQkJCV9NTUlPKDB4NjQ4MzgpDQo+IC0jZGVmaW5lICAg RURQX1BTUl9FUlJPUgkJCQkoMTw8MikNCj4gLSNkZWZpbmUgICBFRFBfUFNSX1BPU1RfRVhJVAkJ CSgxPDwxKQ0KPiAtI2RlZmluZSAgIEVEUF9QU1JfUFJFX0VOVFJZCQkJKDE8PDApDQo+ICsjZGVm aW5lICAgRURQX1BTUl9FUlJPUih0cmFucykJCQkoMSA8PA0KPiAoKCh0cmFucykgKiA4ICsgMTAp ICYgMzEpKQ0KPiArI2RlZmluZSAgIEVEUF9QU1JfUE9TVF9FWElUKHRyYW5zKQkJKDEgPDwgKCgo dHJhbnMpICoNCj4gOCArIDkpICYgMzEpKQ0KPiArI2RlZmluZSAgIEVEUF9QU1JfUFJFX0VOVFJZ KHRyYW5zKQkJKDEgPDwgKCgodHJhbnMpICoNCj4gOCArIDgpICYgMzEpKQ0KPiAgDQoNCkNsZXZl ciBtYWNyb3MNCg0KPiAgI2RlZmluZSBFRFBfUFNSX0FVWF9DVEwJCQkJX01NSU8oZGV2X3ByaQ0K PiB2LT5wc3JfbW1pb19iYXNlICsgMHgxMCkNCj4gICNkZWZpbmUgICBFRFBfUFNSX0FVWF9DVExf VElNRV9PVVRfTUFTSwkJKDMgPDwgMjYpDQo+IEBAIC02OTUyLDYgKzY5NTIsNyBAQCBlbnVtIHsN Cj4gICNkZWZpbmUgR0VOOF9ERV9NSVNDX0lJUiBfTU1JTygweDQ0NDY4KQ0KPiAgI2RlZmluZSBH RU44X0RFX01JU0NfSUVSIF9NTUlPKDB4NDQ0NmMpDQo+ICAjZGVmaW5lICBHRU44X0RFX01JU0Nf R1NFCQkoMSA8PCAyNykNCj4gKyNkZWZpbmUgIEdFTjhfREVfRURQX1BTUgkJKDEgPDwgMTkpDQo+ ICANCj4gICNkZWZpbmUgR0VOOF9QQ1VfSVNSIF9NTUlPKDB4NDQ0ZTApDQo+ICAjZGVmaW5lIEdF TjhfUENVX0lNUiBfTU1JTygweDQ0NGU0KQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5oDQo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5oDQo+IGluZGV4IDRlNzQxOGIzNDViYy4uMmVmMzE2MTc2MTRhIDEwMDY0NA0KPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmgNCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5oDQo+IEBAIC0yMTgsNiArMjE4LDEwIEBAIHN0cnVj dCBpbnRlbF9saW5rX21fbiB7DQo+ICAJZm9yICgoX19wKSA9IDA7IChfX3ApIDwgSU5URUxfSU5G TyhfX2Rldl9wcml2KS0+bnVtX3BpcGVzOw0KPiAoX19wKSsrKSBcDQo+ICAJCWZvcl9lYWNoX2lm KChfX21hc2spICYgQklUKF9fcCkpDQo+ICANCj4gKyNkZWZpbmUgZm9yX2VhY2hfY3B1X3RyYW5z Y29kZXJfbWFza2VkKF9fZGV2X3ByaXYsIF9fdCwgX19tYXNrKSBcDQo+ICsJZm9yICgoX190KSA9 IDA7IChfX3QpIDwgSTkxNV9NQVhfVFJBTlNDT0RFUlM7IChfX3QpKyspCQ0KPiBcDQo+ICsJCWZv cl9lYWNoX2lmICgoX19tYXNrKSAmICgxIDw8IChfX3QpKSkNCj4gKw0KPiAgI2RlZmluZSBmb3Jf ZWFjaF91bml2ZXJzYWxfcGxhbmUoX19kZXZfcHJpdiwgX19waXBlLCBfX3ApCQkNCj4gXA0KPiAg CWZvciAoKF9fcCkgPSAwOwkJCQkJCQ0KPiAJXA0KPiAgCSAgICAgKF9fcCkgPCBJTlRFTF9JTkZP KF9fZGV2X3ByaXYpLT5udW1fc3ByaXRlc1soX19waXBlKV0gKw0KPiAxOwlcCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=