From: Markus Elfring Date: Tue, 02 Jul 2019 09:50:10 +0000 Subject: [PATCH] brcmfmac: Replace two seq_printf() calls in brcmf_feat_fwcap_debugfs_read() Message-Id: <7d96085a-76e8-c290-698a-e1473d3f4be7@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list@cypress.com, brcm80211-dev-list.pdl@broadcom.com, Arend van Spriel , Chi-Hsien Lin , "David S. Miller" , Franky Lin , Hante Meuleman , Kalle Valo , Pieter-Paul Giesberts , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Wright Feng Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Tue, 2 Jul 2019 11:31:07 +0200 A line break and a single string should be put into a sequence. Thus use the corresponding output functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c index 73aff4e4039d..ec0e80296e43 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c @@ -225,10 +225,10 @@ static int brcmf_feat_fwcap_debugfs_read(struct seq_file *seq, void *data) } /* Usually there is a space at the end of capabilities string */ - seq_printf(seq, "%s", caps); + seq_puts(seq, caps); /* So make sure we don't print two line breaks */ if (tmp > caps && *(tmp - 1) != '\n') - seq_printf(seq, "\n"); + seq_putc(seq, '\n'); return 0; } -- 2.22.0