From: "plaisthos (Code Review)" Date: Thu, 19 Mar 2026 11:27:19 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <7e323bb6742097f688e960bc8b321b131803f011-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="N1tNjZ2XHIs="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Optimise iterating over all clients by remembering highest peer id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --N1tNjZ2XHIs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable plaisthos has posted comments on this change by plaisthos. ( http://gerrit.= openvpn.net/c/openvpn/+/1557?usp=3Demail ) Change subject: Optimise iterating over all clients by remembering highest = peer id ...................................................................... Patch Set 6: (1 comment) File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/1557/comment/6ce2d185_dc6b762e?usp=3D= email : PS3, Line 166: uint32_t max_peerid; /**< currently highes= t allocated peerid and > "highest currently" I will update this if I have to update the patch again as this has been alr= eady sent out as mail. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1557?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If797f3fe178fba3f43fb12898e5484bfb38f05c3 Gerrit-Change-Number: 1557 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Comment-Date: Thu, 19 Mar 2026 11:27:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --N1tNjZ2XHIs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

View Change

1 c= omment:

  • File src/openvpn/multi.h:

    • Patch Set #3, Line 166: uint32_t max_peerid; = /**< currently highest allocated peerid and

      &= quot;highest currently"

      I will update this if I have = to update the patch again as this has been already sent out as mail.

To view, visit change 1557. To unsubscribe, or for help wri= ting mail filters, visit settings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If797f3fe178fba3f43fb12898e5= 484bfb38f05c3
Gerrit-Change-Number: 1557
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Comment-Date: Thu, 19 Mar 2026 11:27:19= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --N1tNjZ2XHIs=--