From: "flichtenheld (Code Review)"
Date: Fri, 9 Jan 2026 12:56:27 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515...,
openvpn-devel@lists.sourceforge.net, gert@...1296...
Message-ID: <7e416778799de0396a13c8a3c037f0a4ab34fb6f-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="aEPk7uTHSVU="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix
conversion warnings in interactive.c
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: d12fk , plaisthos , openvpn-devel
--aEPk7uTHSVU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, d12fk, plaisthos.
flichtenheld has posted comments on this change by flichtenheld. ( http://g=
errit.openvpn.net/c/openvpn/+/1457?usp=3Demail )
Change subject: openvpnserv: Fix conversion warnings in interactive.c
......................................................................
Patch Set 4:
(2 comments)
File src/openvpnserv/interactive.c:
http://gerrit.openvpn.net/c/openvpn/+/1457/comment/cb480e29_6a268e34?usp=3D=
email :
PS3, Line 1391: RegWStringLength(PCWSTR string)
> I'd suggest to name that `RegWStringSize()` - d12fk has tried to make eve=
rything that is a "number o [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/1457/comment/591009df_dff70458?usp=3D=
email :
PS3, Line 1744: static LSTATUS
> why is that change? We have a `DWORD err` and return that?
Yeah, I started cleaning up DWORD vs LSTATUS. But didn't really finish it. =
Also not relevant right now since they are the same size, only differ in si=
gnedness. So removing all these changes and deferring them to later.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1457?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I864cd4a718886f437b72e93d0286f90fcb73592b
Gerrit-Change-Number: 1457
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: cron2
Gerrit-Reviewer: d12fk
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: d12fk
Gerrit-Comment-Date: Fri, 09 Jan 2026 12:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
--aEPk7uTHSVU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: cron2, d12fk, plaisthos.
why is that change? We have a `DWO=
RD err` and return that?
Yeah, I started cleaning up DWORD=
vs LSTATUS. But didn't really finish it. Also not relevant right now s=
ince they are the same size, only differ in signedness. So removing all the=
se changes and deferring them to later.
To view, =
visit ch=
ange 1457. To unsubscribe, or for help writing mail filters, visit settings.