From: "plaisthos (Code Review)" Date: Wed, 13 Dec 2023 14:06:59 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <7ef31d31eb8355381d31326479793383b37fa16a-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="TA23DA8nIow="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --TA23DA8nIow= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by flichtenheld Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Add test_ssl unit test and test export of PEM to file This introduces a number of mock function to be able to compile ssl_verify_*.c and ssl_mbedtls.c/ssl_openssl.c into a unit and adds quite a number of files to that unit. But it allows similar unit tests (in term of dependencies) to be added in the future. Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Signed-off-by: Arne Schwabe --- M .github/workflows/build.yaml M CMakeLists.txt M tests/unit_tests/openvpn/Makefile.am A tests/unit_tests/openvpn/mock_management.c A tests/unit_tests/openvpn/mock_ssl_dependencies.c A tests/unit_tests/openvpn/test_ssl.c 6 files changed, 311 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/471/3 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 4393f5c..bdb30c8 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -85,7 +85,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, ncp, pac= ket_id, pkt, provider, tls_crypt] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, ncp, pac= ket_id, pkt, provider, ssl, tls_crypt] runs-on: windows-latest name: "mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - OSSL" diff --git a/CMakeLists.txt b/CMakeLists.txt index 6cbee56..6ac453c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -588,6 +588,7 @@ "test_packet_id" "test_pkt" "test_provider" + "test_ssl" ) if (WIN32) @@ -697,6 +698,34 @@ src/openvpn/mss.c ) + target_sources(test_ssl PRIVATE + tests/unit_tests/openvpn/mock_management.c + tests/unit_tests/openvpn/mock_ssl_dependencies.c + tests/unit_tests/openvpn/mock_win32_execve.c + src/openvpn/argv.c + src/openvpn/base64.c + src/openvpn/block_dns.c + src/openvpn/crypto.c + src/openvpn/crypto_mbedtls.c + src/openvpn/crypto_openssl.c + src/openvpn/cryptoapi.c + src/openvpn/env_set.c + src/openvpn/env_set.c + src/openvpn/mss.c + src/openvpn/mtu.c + src/openvpn/options_util.c + src/openvpn/otime.c + src/openvpn/packet_id.c + src/openvpn/run_command.c + src/openvpn/ssl_mbedtls.c + src/openvpn/ssl_openssl.c + src/openvpn/ssl_util.c + src/openvpn/ssl_verify_mbedtls.c + src/openvpn/ssl_verify_openssl.c + src/openvpn/xkey_helper.c + src/openvpn/xkey_provider.c + ) + target_sources(test_misc PRIVATE tests/unit_tests/openvpn/mock_get_random.c src/openvpn/options_util.c diff --git a/tests/unit_tests/openvpn/Makefile.am b/tests/unit_tests/openvp= n/Makefile.am index ef45b11..eb8ccc8 100644 --- a/tests/unit_tests/openvpn/Makefile.am +++ b/tests/unit_tests/openvpn/Makefile.am @@ -7,7 +7,8 @@ endif test_binaries +=3D crypto_testdriver packet_id_testdriver auth_token_testd= river ncp_testdriver misc_testdriver \ - pkt_testdriver + pkt_testdriver ssl_testdriver + if HAVE_LD_WRAP_SUPPORT if !WIN32 test_binaries +=3D tls_crypt_testdriver @@ -67,6 +68,28 @@ $(top_srcdir)/src/openvpn/win32-util.c \ $(top_srcdir)/src/openvpn/mss.c +ssl_testdriver_CFLAGS =3D @TEST_CFLAGS@ \ + -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/op= envpn +ssl_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ +ssl_testdriver_SOURCES =3D test_crypto.c mock_msg.c mock_msg.h \ + mock_management.c mock_ssl_dependencies.c mock_win32_execve.c \ + $(top_srcdir)/src/openvpn/buffer.c \ + $(top_srcdir)/src/openvpn/crypto.c \ + $(top_srcdir)/src/openvpn/crypto_mbedtls.c \ + $(top_srcdir)/src/openvpn/crypto_openssl.c \ + $(top_srcdir)/src/openvpn/otime.c \ + $(top_srcdir)/src/openvpn/packet_id.c \ + $(top_srcdir)/src/openvpn/platform.c \ + $(top_srcdir)/src/openvpn/mtu.c \ + $(top_srcdir)/src/openvpn/win32-util.c \ + $(top_srcdir)/src/openvpn/mss.c \ + $(top_srcdir)/src/openvpn/xkey_provider.c \ + $(top_srcdir)/src/openvpn/xkey_helper.c \ + $(top_srcdir)/src/openvpn/ssl_util.c \ + $(top_srcdir)/src/openvpn/base64.c \ + $(top_srcdir)/src/openvpn/cryptoapi.c + + packet_id_testdriver_CFLAGS =3D @TEST_CFLAGS@ \ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/op= envpn packet_id_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ diff --git a/tests/unit_tests/openvpn/mock_management.c b/tests/unit_tests/= openvpn/mock_management.c new file mode 100644 index 0000000..8936c3a --- /dev/null +++ b/tests/unit_tests/openvpn/mock_management.c @@ -0,0 +1,51 @@ +/* + * OpenVPN -- An application to securely tunnel IP networks + * over a single UDP port, with support for SSL/TLS-based + * session authentication and key exchange, + * packet encryption, packet authentication, and + * packet compression. + * + * Copyright (C) 2002-2023 OpenVPN Inc + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +/* Minimal set of mocked management function/globals to get unit tests to + * compile */ + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif + +#include "syshead.h" + +#include "manage.h" + +#ifdef ENABLE_MANAGEMENT + +struct management *management; /* GLOBAL */ + +void +management_auth_failure(struct management *man, const char *type, const ch= ar *reason) +{ + ASSERT(false); +} + +char * +management_query_pk_sig(struct management *man, const char *b64_data, + const char *algorithm) +{ + return NULL; +} +#endif diff --git a/tests/unit_tests/openvpn/mock_ssl_dependencies.c b/tests/unit_= tests/openvpn/mock_ssl_dependencies.c new file mode 100644 index 0000000..9231d65 --- /dev/null +++ b/tests/unit_tests/openvpn/mock_ssl_dependencies.c @@ -0,0 +1,67 @@ +/* + * OpenVPN -- An application to securely tunnel IP networks + * over a single UDP port, with support for SSL/TLS-based + * session authentication and key exchange, + * packet encryption, packet authentication, and + * packet compression. + * + * Copyright (C) 2002-2023 OpenVPN Inc + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +/* Minimal set of mocked function/globals to get unit tests to + * compile that use the ssl_* files */ + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif + +#include "syshead.h" + +#include +#include + + +#include "ssl.h" +#include "ssl_verify.h" + +int +parse_line(const char *line, char **p, const int n, const char *file, + const int line_num, int msglevel, struct gc_arena *gc) +{ + /* Dummy function to get the linker happy, should never be called */ + assert_true(false); + return 0; +} + + +int +pem_password_callback(char *buf, int size, int rwflag, void *u) +{ + return 0; +} + +void +cert_hash_remember(struct tls_session *session, const int cert_depth, + const struct buffer *cert_hash) +{ + assert_false(true); +} + +result_t +verify_cert(struct tls_session *session, openvpn_x509_cert_t *cert, int ce= rt_depth) +{ + return FAILURE; +} diff --git a/tests/unit_tests/openvpn/test_ssl.c b/tests/unit_tests/openvpn= /test_ssl.c new file mode 100644 index 0000000..acaaad5 --- /dev/null +++ b/tests/unit_tests/openvpn/test_ssl.c @@ -0,0 +1,139 @@ +/* + * OpenVPN -- An application to securely tunnel IP networks + * over a single UDP port, with support for SSL/TLS-based + * session authentication and key exchange, + * packet encryption, packet authentication, and + * packet compression. + * + * Copyright (C) 2023 OpenVPN Inc + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif + +#include "syshead.h" + +#include +#include +#include +#include +#include +#include + +#include "crypto.h" +#include "options.h" +#include "ssl_backend.h" +#include "options_util.h" + +#include "mock_msg.h" +#include "mss.h" +#include "ssl_verify_backend.h" +#include "win32.h" + +/* Mock function to be allowed to include win32.c which is required for + * getting the temp directory */ +#ifdef _WIN32 +struct signal_info siginfo_static; /* GLOBAL */ + +const char * +strerror_win32(DWORD errnum, struct gc_arena *gc) +{ + ASSERT(false); +} + +void +throw_signal(const int signum) +{ + ASSERT(false); +} +#endif + + +const char *unittest_cert =3D "-----BEGIN CERTIFICATE-----\n" + "MIIBuTCCAUCgAwIBAgIUTLtjSBzx53qZRvZ6Ur7D9kgoO= HkwCgYIKoZIzj0EAwIw\n" + "EzERMA8GA1UEAwwIdW5pdHRlc3QwIBcNMjMxMTIxMDk1N= DQ3WhgPMjA3ODA4MjQw\n" + "OTU0NDdaMBMxETAPBgNVBAMMCHVuaXR0ZXN0MHYwEAYHK= oZIzj0CAQYFK4EEACID\n" + "YgAEHYB2hn2xx3f4lClXDtdi36P19pMZA+kI1Dkv/Vn10= vBZ/j9oa+P99T8duz/e\n" + "QlPeHpesNJO4fX8iEDj6+vMeWejOT7jAQ4MmG5EZjpcBK= xCfwFooEvzu8bVujUcu\n" + "wTQEo1MwUTAdBgNVHQ4EFgQUPcgBEVXjF5vYfDsInoE3d= F6UfQswHwYDVR0jBBgw\n" + "FoAUPcgBEVXjF5vYfDsInoE3dF6UfQswDwYDVR0TAQH/B= AUwAwEB/zAKBggqhkjO\n" + "PQQDAgNnADBkAjBLPAGrQAyinigqiu0RomoV8TVaknVLF= Sq6H6A8jgvzfsFCUK1O\n" + "dvNZhFPM6idKB+oCME2JLOBANCSV8o7aJzq7SYHKwPyb1= J4JFlwKe/0Jpv7oh9b1\n" + "IJbuaM9Z/VSKbrIXGg=3D=3D\n" + "-----END CERTIFICATE-----\n"; + +static const char * +get_tmp_dir() +{ + const char *ret; +#ifdef _WIN32 + ret =3D win_get_tempdir(); +#else + ret =3D "/tmp"; +#endif + assert_non_null(ret); + return ret; +} + +static void +crypto_pem_encode_certificate(void **state) +{ + struct gc_arena gc =3D gc_new(); + + struct tls_root_ctx ctx =3D { 0 }; + tls_ctx_client_new(&ctx); + tls_ctx_load_cert_file(&ctx, unittest_cert, true); + + openvpn_x509_cert_t *cert =3D NULL; + + /* we do not have methods to fetch certificates from ssl contexts, use + * internal TLS library methods for the unit test */ +#ifdef ENABLE_CRYPTO_OPENSSL + cert =3D SSL_CTX_get0_certificate(ctx.ctx); +#elif defined(ENABLE_CRYPTO_MBEDTLS) + cert =3D ctx.crt_chain; +#endif + + const char *tmpfile =3D platform_create_temp_file(get_tmp_dir(), "ut_p= em", &gc); + backend_x509_write_pem(cert, tmpfile); + + struct buffer exported_pem =3D buffer_read_from_file(tmpfile, &gc); + assert_string_equal(BSTR(&exported_pem), unittest_cert); + + unlink(tmpfile); + gc_free(&gc); +} + +int +main(void) +{ + const struct CMUnitTest tests[] =3D { + cmocka_unit_test(crypto_pem_encode_certificate) + }; + +#if defined(ENABLE_CRYPTO_OPENSSL) + OpenSSL_add_all_algorithms(); +#endif + + int ret =3D cmocka_run_group_tests_name("crypto tests", tests, NULL, N= ULL); + +#if defined(ENABLE_CRYPTO_OPENSSL) + EVP_cleanup(); +#endif + + return ret; +} -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset --TA23DA8nIow= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

plaisthos uploaded patch set #3 to this change.

<= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail">View Chang= e

The following approvals got outdated and were removed: Code-Review-1 by flichtenheld

Add test_ssl unit test and test export of PEM=
 to file

This introduces a number of mock function to be able to com= pile
ssl_verify_*.c and ssl_mbedtls.c/ssl_openssl.c into a unit and adds=
quite a number of files to that unit. But it allows similar unit tests<= br>(in term of dependencies) to be added in the future.

Change-Id: I= e248d35d063bb6878f3dd42840c77ba0d6fa3381
Signed-off-by: Arne Schwabe <= ;arne@...1227...>
---
M .github/workflows/build.yaml
M CMakeLis= ts.txt
M tests/unit_tests/openvpn/Makefile.am
A tests/unit_tests/open= vpn/mock_management.c
A tests/unit_tests/openvpn/mock_ssl_dependencies.c=
A tests/unit_tests/openvpn/test_ssl.c
6 files changed, 311 insertion= s(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/open=
vpn refs/changes/71/471/3
diff --git a/.github/workflows/build.yaml=
 b/.github/workflows/build.yaml
index 4393f5c..bdb30c8 1006= 44
--- a/.github/workflows/build.yaml
+++ b= /.github/workflows/build.yaml
@@ -85,7 +85,7 @@
<= span> fail-fast: false
matrix:
arch: [x86, x64]
- test: [argv, auth_token, buffer, cryptoapi, crypto, misc, ncp,= packet_id, pkt, provider, tls_crypt]
+ test: [argv, auth_token, buffer, cryptoapi, crypt= o, misc, ncp, packet_id, pkt, provider, ssl, tls_crypt]

runs-on: windows-latest
name: &quo= t;mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - OSSL"

diff --git a/CMakeLists.txt b/CMakeLists.txt
ind= ex 6cbee56..6ac453c 100644
--- a/CMakeLists.txt
<= span>+++ b/CMakeLists.txt
@@ -588,6 +588,7 @@
"test_packet_id"
"test_= pkt"
"test_provider"
+ "test_ssl"
)

if (WIN32)

@@ -697,6 +698,34 @@
src/openvpn/mss.= c
)

+ target_sources(test_ssl PRIVATE
+ tests/unit_tests/ope= nvpn/mock_management.c
+ tests/unit_tests/op= envpn/mock_win32_execve.c
+ src/openvpn/argv.c
+ src/openvpn/base64.c
+ src/openvpn/block_dns.c+ src/openvpn/crypt= o.c
+ src/= openvpn/crypto_mbedtls.c
+ src/openvpn/crypto_openssl.c
+ src/openvpn/cryptoapi.c
+ src/openvpn/env_set.c=
+ src/ope= nvpn/env_set.c
+ = src/openvpn/mss.c
+ src/openvpn/mtu.c
+ src/openvpn/options_util.c
+ src/openvpn/otime.c+ src/openvpn/packe= t_id.c
+ s= rc/openvpn/run_command.c
+ src/openvpn/ssl_mbedtls.c
+ src/openvpn/ssl_openssl.c
+ src/openvpn/ssl_util.c=
+ src/ope= nvpn/ssl_verify_mbedtls.c
+ src/openvpn/ssl_verify_openssl.c
+ src/openvpn/xkey_helper.c=
+ src/openvpn/xk= ey_provider.c
+ )<= /span>
+
= target_sources(test_misc PRIVATE
tests/unit_test= s/openvpn/mock_get_random.c
src/openvpn/options_ut= il.c
diff --git a/tests/unit_tests/openvpn/Makefile.am b/te= sts/unit_tests/openvpn/Makefile.am
index ef45b11..eb8ccc8 1= 00644
--- a/tests/unit_tests/openvpn/Makefile.am
= +++ b/tests/unit_tests/openvpn/Makefile.am
@@ -7,7 +7= ,8 @@
endif

test_binari= es +=3D crypto_testdriver packet_id_testdriver auth_token_testdriver ncp_te= stdriver misc_testdriver \
- pkt_testdriver
= + pkt_testdriver ssl_testdriver
+
if HAVE_LD_WRAP_SUPPORT
if != WIN32
test_binaries +=3D tls_crypt_testdriver
@@ -67,6 +68,28 @@

$(top_srcdir)/src/openvpn/win32-ut= il.c \
$(top_srcdir)/src/openvpn/mss.c
<= /span>
+ssl_testdriver_CFLAG= S =3D @TEST_CFLAGS@ \
+ssl_testdriv= er_LDFLAGS =3D @TEST_LDFLAGS@
+ssl_testdriver_SOURCES =3D test_crypto.c mock_msg.c mock_msg.h \<= /span>
+ mock_management.c m= ock_ssl_dependencies.c mock_win32_execve.c \
+ $(top_srcdir)/src/openvpn/buffer.c \
+ $(top_srcdir)/src/openvpn/crypt= o.c \

+ $(top_srcdir)= /src/openvpn/crypto_mbedtls.c \
+ $(top_srcdir)/src/openvpn/crypto_openssl.c \
+ $(top_srcdir)/src/openvpn/otime.c \<= /span>
+ $(top_srcdir)/src/o= penvpn/packet_id.c \
= + $(top_srcdir)/src/openvpn/platform.c \
+ $(top_srcdir)/src/openvpn/mtu.c \
+ $(top_srcdir)/src/openvpn/win32-util.c= \
+ $(top_srcdir)/sr= c/openvpn/mss.c \
+ $= (top_srcdir)/src/openvpn/xkey_provider.c \
+ $(top_srcdir)/src/openvpn/xkey_helper.c \+ $(top_srcdir)/src/openvpn/ss= l_util.c \
+ $(top_sr= cdir)/src/openvpn/base64.c \
+ $(top_srcdir)/src/openvpn/cryptoapi.c
+
+
packet_id_testdriver_CFLAGS =3D @TEST_CFLAGS@ \=
-I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(t= op_srcdir)/src/openvpn
packet_id_testdriver_LDFLAGS =3D @T= EST_LDFLAGS@
diff --git a/tests/unit_tests/openvpn/mock_man= agement.c b/tests/unit_tests/openvpn/mock_management.c
new = file mode 100644
index 0000000..8936c3a
---= /dev/null
+++ b/tests/unit_tests/openvpn/mock_management.c=
@@ -0,0 +1,51 @@
+/*
+ * = OpenVPN -- An application to securely tunnel IP networks
+ * over a single UDP port= , with support for SSL/TLS-based
+ * session authentication and key exchange,=
+ * packet encr= yption, packet authentication, and
+ * packet compression.
+ *
+ * Copyright (C) 2002-2023 OpenVPN Inc <sales@...515...>= ;
+ *
+ * This program is free software; = you can redistribute it and/or modify

+ * it under the terms of the GNU General Public License = version 2
+ * as pub= lished by the Free Software Foundation.
+ *
+ * but WITHOUT ANY WARR= ANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURP= OSE. See the
+ * GN= U General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License= along
+ * with this= program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Fl= oor, Boston, MA 02110-1301 USA.

+ */
+

+/* Minimal set of mocke= d management function/globals to get unit tests to
+ * compile */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include "= syshead.h"
+
+#include "manage.h= "
+
+#ifdef ENABLE_MANAGEMENT
<= br>+
+struct management *management; /* GLOBAL */

+
+void
+management_auth_failure(struct management *man, const ch= ar *type, const char *reason)
+{
+ ASSE= RT(false);
+}<= br>+
+char *
+management_query_pk_sig(struct management *man, const char = *b64_data,
+ = const char *algorithm)
+{
+= return NULL;
+}
+#endif
diff --git a/tests/unit_tests/openvpn/mock_ssl_dependencies.c b/tests/uni= t_tests/openvpn/mock_ssl_dependencies.c

new file mode 10064= 4
index 0000000..9231d65
--- /dev/null
+++ b/tests/unit_tests/openvpn/mock_ssl_dependencies.c@@ -0,0 +1,67 @@
+/*
+ * OpenVPN = -- An application to securely tunnel IP networks
+ * over a single UDP port, with su= pport for SSL/TLS-based
+ * session authentication and key exchange,
+ * packet encryption, p= acket authentication, and

+ * packet compression.
+ *
+ * Copyright (C) 2002-2023 OpenVPN Inc <sales@...515...><= br>+ *
+ * This program is free software; you can r= edistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2=
+ * as published by= the Free Software Foundation.
+ *
+ * Th= is program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; wit= hout even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See= the
+ * GNU General= Public License for more details.
+ *
+ * = You should have received a copy of the GNU General Public License along
+ * with this program;= if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Bost= on, MA 02110-1301 USA.
+
+/* Minimal set of mocked functio= n/globals to get unit tests to

+ * compile that use the ssl_* files */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include &= quot;syshead.h"
= +
+#include <setjm= p.h>
+#include <= ;cmocka.h>
+
+
+#include "ssl.h"
+#include "ssl_verify.h"

+
+int
+parse_line(const char *line, char **p, const int n, const= char *file,
+ = const int line_num, int msglevel, struct gc_arena *gc)
+{
+ /* Dummy function to get the linker happy, should = never be called */
+ = assert_true(false);
+}
+
+
+int
+= pem_password_callback(char *buf, int size, int rwflag, void *u)
<= span style=3D"color: hsl(120, 100%, 40%);">+{

+ return 0;
+}
+
+void
+cert_hash_remember(struct tls_se= ssion *session, const int cert_depth,
+ const struct buffer *cert_hash)=
+{
+ assert_false(true);
+}
+
+re= sult_t
+verify_cert(s= truct tls_session *session, openvpn_x509_cert_t *cert, int cert_depth)
+{
+ return FAILURE;
+}
diff --git a/tests/unit= _tests/openvpn/test_ssl.c b/tests/unit_tests/openvpn/test_ssl.c
<= span>new file mode 100644

index 0000000..acaaad5
= --- /dev/null
+++ b/tests/unit_tests/openvpn/test_ssl= .c
@@ -0,0 +1,139 @@
+/*
+= * OpenVPN -- An application to securely tunnel IP networks
+ * over a single UDP p= ort, with support for SSL/TLS-based
+ * session authentication and key exchange,
+ * packet e= ncryption, packet authentication, and
+ * packet compression.
+ *
+ * Copyright (C) 2023 OpenVPN Inc <sales@...515...><= /span>
+ *
+ * This program is free software; yo= u can redistribute it and/or modify
+ * it under the terms of the GNU General Public License ve= rsion 2
+ * as publi= shed by the Free Software Foundation.
+ *
= + * This program is distributed in the hope that it will be useful,=
+ * but WITHOUT ANY WARRAN= TY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOS= E. See the
+ * GNU = General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License a= long
+ * with this p= rogram; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floo= r, Boston, MA 02110-1301 USA.

+ */
+
+#ifdef HAVE_CONFIG_H

+#include "config.h&= quot;
+#endif<= br>+
+#include "syshead.h"
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdarg.h>
+#include <string.h>+#include <setjmp.h>
+#include <cmocka.h&g= t;
+
+#include "crypto.h"=
+#include "options.h&q= uot;
+#include "= ssl_backend.h"
+= #include "options_util.h"
+
+#in= clude "mock_msg.h"
+#include "mss.h"
+#include "ssl_verify_backend.h"
+#include "win32.h"+
+/* Mock function to be allowed to include win32= .c which is required for
+ * getting the temp directory */
+#ifdef _WIN32
+struct signal_info siginfo_static; /* GLOBAL */
+

+const char *
+strerror_win32(DWORD errnum, struct gc_arena *gc)
<= span style=3D"color: hsl(120, 100%, 40%);">+{
+ ASSERT(false);
+}
+
+void<= br>+throw_signal(const int sign= um)
+{
+ ASSERT(false);
+}
+#endif
+
++const char *unittest_cert =3D= "-----BEGIN CERTIFICATE-----\n"
+ "MIIBuTCCAUCgAwIBAg= IUTLtjSBzx53qZRvZ6Ur7D9kgoOHkwCgYIKoZIzj0EAwIw\n"
+ "EzERMA= 8GA1UEAwwIdW5pdHRlc3QwIBcNMjMxMTIxMDk1NDQ3WhgPMjA3ODA4MjQw\n"+ = "OTU0NDdaMBMxETAPBgNVBAMMCHVuaXR0ZXN0MHYwEAYHKoZIzj0CAQYFK4EEACID\n&qu= ot;
+ = "YgAEHYB2hn2xx3f4lClXDtdi36P19pMZA+kI1Dkv/Vn10vBZ/j9oa+P99= T8duz/e\n"
+ = "QlPeHpesNJO4fX8iEDj6+vMeWejOT7jAQ4MmG5EZjpcBK= xCfwFooEvzu8bVujUcu\n"
+ "wTQEo1MwUTAdBgNVHQ4EFgQUPcgBEVXjF= 5vYfDsInoE3dF6UfQswHwYDVR0jBBgw\n"
+ "FoAUPcgBEVXjF5vYfDsIn= oE3dF6UfQswDwYDVR0TAQH/BAUwAwEB/zAKBggqhkjO\n"
+ "PQQDAgN= nADBkAjBLPAGrQAyinigqiu0RomoV8TVaknVLFSq6H6A8jgvzfsFCUK1O\n"+ &= quot;dvNZhFPM6idKB+oCME2JLOBANCSV8o7aJzq7SYHKwPyb1J4JFlwKe/0Jpv7oh9b1\n&quo= t;
+ = "IJbuaM9Z/VSKbrIXGg=3D=3D\n"
+ "-----END CE= RTIFICATE-----\n";
+
+static const ch= ar *
+get_tmp_dir()
+{
+ const char *ret;
+#ifdef _WIN32
+ ret =3D win_get_tempdir();
+#else

+ ret =3D "/tmp";
+#endif
+ assert_non_null(ret);
+ return ret;
+}
+
+static voi= d
+crypto_pem_encode_= certificate(void **state)
+{
+ struct g= c_arena gc =3D gc_new();
+
+ struct tls= _root_ctx ctx =3D { 0 };
+ tls_ctx_client_new(&ctx);
+ tls_ctx_load_cert_file(&ctx, unittest_cert, true= );
+
+ openvpn_x509_cert_t *cert =3D NU= LL;
+
+ /* we do not have methods to fe= tch certificates from ssl contexts, use
+ * internal TLS library methods for the unit test *= /
+#ifdef ENABLE_CRYP= TO_OPENSSL
+ cert = =3D SSL_CTX_get0_certificate(ctx.ctx);
+#elif defined(ENABLE_CRYPTO_MBEDTLS)
+ cert =3D ctx.crt_chain;
<= span style=3D"color: hsl(120, 100%, 40%);">+#endif
+
+ const char *tmpfile =3D platform_create_temp_file(get_tmp_d= ir(), "ut_pem", &gc);
+ backend_x509_write_pem(cert, tmpfile);
+
+ struct buffer exported_pem =3D buffer_read_from_fil= e(tmpfile, &gc);
= + assert_string_equal(BSTR(&exported_pem), unittest_cert);+
+ unlink(tmpfile);
+ gc_free(&gc);
+}
+
+int
+main(void)
+{

+ const struct CMUnitTest tests[] =3D {+ cmocka_unit_test(cry= pto_pem_encode_certificate)
+ };
+

+#if defined(ENABLE_CRYPT= O_OPENSSL)
+ OpenS= SL_add_all_algorithms();
+#endif
+<= br>+ int ret =3D cmocka_run_= group_tests_name("crypto tests", tests, NULL, NULL);
+
+#if defined(ENABLE_CRYPTO_OPENSSL)
+ EVP_cleanup();
+#endif
+
+ return ret;
+}

To view, visit change 471. To unsubscrib= e, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c= 77ba0d6fa3381
Gerrit-Change-Number: 471
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newpatchset
--TA23DA8nIow=--