From: Heinrich Schuchardt Date: Tue, 29 Dec 2020 11:42:56 +0100 Subject: [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE In-Reply-To: References: <20201226210409.28073-1-pali@kernel.org> Message-ID: <7efcb954-18a8-9159-eafc-c446681fc2b5@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/29/20 4:32 AM, Simon Glass wrote: > Hi Paul, > > On Sat, 26 Dec 2020 at 14:04, Pali Roh?r wrote: >> >> CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled >> CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work. >> >> Define this dependency in Kconfig and remove information about this >> requirement from documentation file. >> >> Signed-off-by: Pali Roh?r >> --- >> cmd/Kconfig | 1 + >> doc/usage/bootmenu.rst | 5 ----- >> 2 files changed, 1 insertion(+), 5 deletions(-) > > This driver is past the driver model migration deadline so we > shouldn't accept patches, except perhaps to migrate or remove it. All boards selecting CONFIG_CFB_CONSOLE also select CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in doc/usage/bootmenu.rst. Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting used by all driver model video drivers? Shouldn't that setting be mentioned in doc/usage/bootmenu.rst? Best regards Heinrich