From: "flichtenheld (Code Review)" Date: Fri, 7 Jun 2024 11:36:25 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net Message-ID: <7f07cb6c56f35968b6eef49fd1e6b8074736cfc8-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="jvRJcBbhGMY="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: plaisthos , openvpn-devel --jvRJcBbhGMY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/663?usp=3Demail ) Change subject: Add t_server_null test suite ...................................................................... Patch Set 1: Code-Review-2 (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/663/comment/923993f1_1319ae66 : PS1, Line 1: #!/usr/bin/env bash bash is not necessarily available on BSD. http://gerrit.openvpn.net/c/openvpn/+/663/comment/54cb0bde_ba12a5e5 : PS1, Line 74: # Wait until servers are up. This check is based on the prese= nce of processes This check does not work correctly. You often see something like this in th= e output of the test: cat: t_server_null_server-1194_udp.pid: No such file or directory cat: t_server_null_server-1195_tcp.pid: No such file or directory error: list of process IDs must follow -p Usage: ps [options] Try 'ps --help ' or 'ps --help ' for additional help text. For more details see ps(1). OpenVPN test servers up: 0/0 Does not necessarily fail the test but definitely does not do what it is su= pposed to do. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/663?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1b54da258c7d15551b6c3de7522a0d19afdb66de Gerrit-Change-Number: 663 Gerrit-PatchSet: 1 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Fri, 07 Jun 2024 11:36:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --jvRJcBbhGMY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

2 comments:

  • File tests/t_server_null_client= .sh:

    • Patch Set #1, = Line 1: #!/usr/bin/env = bash

      b= ash is not necessarily available on BSD.

    • Patch Set #1, Lin= e 74: # Wait until serv= ers are up. This check is based on the presence of processes

      This check does not = work correctly. You often see something like this in the output of the test= :

      Does not necessarily fail the test but =
      definitely does not do what it is supposed
      to do.

  • To view, visit change 663. To unsubscribe, or for help writing mail filters,= visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I1b54da258c7d15551b6c3de7522= a0d19afdb66de
    Gerrit-Change-Number: 663
    Gerrit-PatchSet: 1
    Gerrit-Owner: mattock <samuli@...515...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: mattock <samuli@...515...= >
    Gerrit-Comment-Date: Fri, 07 Jun 2024 11:36:25= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --jvRJcBbhGMY=--