From: Oscar Mateo Subject: Re: [PATCH v7 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads Date: Mon, 16 Apr 2018 15:09:58 -0700 Message-ID: <7f33f4a8-9f8c-0de5-d131-e99cf1322f33@intel.com> References: <1522338266-9129-1-git-send-email-yunwei.zhang@intel.com> <1523913758-32381-1-git-send-email-yunwei.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6C846E01C for ; Mon, 16 Apr 2018 22:09:48 +0000 (UTC) In-Reply-To: <1523913758-32381-1-git-send-email-yunwei.zhang@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yunwei Zhang , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwNC8xNi8yMDE4IDAyOjIyIFBNLCBZdW53ZWkgWmhhbmcgd3JvdGU6Cj4gV2FQcm9ncmFt TWdzckZvckNvcnJlY3RTbGljZVNwZWNpZmljTW1pb1JlYWRzIGRpY3RhdGUgdGhhdCBiZWZvcmUg YW55IE1NSU8KPiByZWFkIGludG8gU2xpY2UvU3Vic2xpY2Ugc3BlY2lmaWMgcmVnaXN0ZXJzLCBN Q1IgcGFja2V0IGNvbnRyb2wKPiByZWdpc3RlcigweEZEQykgbmVlZHMgdG8gYmUgcHJvZ3JhbW1l ZCB0byBwb2ludCB0byBhbnkgZW5hYmxlZAo+IHNsaWNlL3N1YnNsaWNlIHBhaXIuIE90aGVyd2lz ZSwgaW5jb3JyZWN0IHZhbHVlIHdpbGwgYmUgcmV0dXJuZWQuCj4KPiBIb3dldmVyLCB0aGF0IG1l YW5zIGVhY2ggc3Vic2VxdWVudCBNTUlPIHJlYWQgd2lsbCBiZSBmb3J3YXJkZWQgdG8gYQo+IHNw ZWNpZmljIHNsaWNlL3N1YnNsaWNlIGNvbWJpbmF0aW9uIGFzIHJlYWQgaXMgdW5pY2FzdC4gVGhp cyBpcyBPSyBzaW5jZQo+IHNsaWNlL3N1YnNsaWNlIHNwZWNpZmljIHJlZ2lzdGVyIHZhbHVlcyBh cmUgY29uc2lzdGVudCBpbiBhbG1vc3QgYWxsIGNhc2VzCj4gYWNyb3NzIHNsaWNlL3N1YnNsaWNl LiBUaGVyZSBhcmUgcmFyZSBvY2Nhc2lvbnMgc3VjaCBhcyBJTlNURE9ORSB0aGF0IHRoaXMKPiB2 YWx1ZSB3aWxsIGJlIGRlcGVuZGVudCBvbiBzbGljZS9zdWJzbGljZSBjb21ibywgaW4gc3VjaCBj YXNlcywgd2UgbmVlZCB0bwo+IHByb2dyYW0gMHhGREMgYW5kIHJlY292ZXIgdGhpcyBhZnRlci4g VGhpcyBpcyBhbHJlYWR5IGNvdmVyZWQgYnkKPiByZWFkX3N1YnNsaWNlX3JlZy4KPgo+IEFsc28s IDB4RkRDIHdpbGwgbG9zZSBpdHMgaW5mb3JtYXRpb24gYWZ0ZXIgVERSL2VuZ2luZSByZXNldC9w b3dlciBzdGF0ZQo+IGNoYW5nZS4KPgo+IFJlZmVyZW5jZXM6IEhTRCMxNDA1NTg2ODQwLCBCU0lE IzA1NzUKPgo+IHYyOgo+ICAgLSB1c2UgZmxzKCkgaW5zdGVhZCBvZiBmaW5kX2xhc3RfYml0KCkg KENocmlzKQo+ICAgLSBhZGRlZCBJTlRFTF9TU0VVIHRvIGV4dHJhY3Qgc3NldSBmcm9tIGRldmlj ZSBpbmZvLiAoQ2hyaXMpCj4gdjM6Cj4gICAtIHJlYmFzZSBvbiBsYXRlc3QgdGlwCj4gdjU6Cj4g ICAtIEFkZGVkIHJlZmVyZW5jZXMgKE1pa2EpCj4gICAtIENoYW5nZSB0aGUgb3JkZXJlZCBvZiBw YXNzaW5nIGFyZ3VtZW50cyBhbmQgZXRjLiAoVXJzdWxpbikKPiB2NzoKPiAgIC0gUmViYXNlZC4K Pgo+IENjOiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IENjOiBNaWNoZWwg VGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4g PGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hy aXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxh QGxpbnV4LmludGVsLmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxp bnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBZdW53ZWkgWmhhbmcgPHl1bndlaS56aGFu Z0BpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAg ICAgICAgIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5j ICAgfCAzMCArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMgfCAxMiArKysrKysrKysrKysKPiAgIDMgZmlsZXMg Y2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+IGluZGV4IDhlODY2N2QuLjQzNDk4YTQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gQEAgLTI3MjUsNiArMjcyNSw4IEBAIGludCB2bHZfZm9yY2VfZ2Z4X2Nsb2Nr KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgYm9vbCBvbik7Cj4gICBpbnQgaW50 ZWxfZW5naW5lc19pbml0X21taW8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsK PiAgIGludCBpbnRlbF9lbmdpbmVzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KTsKPiAgIAo+ICt1MzIgY2FsY3VsYXRlX21jcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIHUzMiBtY3IpOwo+ICsKCkFzIGEgZ2xvYmFsIGZ1bmN0aW9uLCB0aGlzIGNvdWxk IHVzZSBhIGJldHRlciBwcmVmaXggKGludGVsX3NvbWV0aGluZ18pCgpPciwgYWx0ZXJuYXRpdmVs eSwgbWFrZSBpdCBsb2NhbCBhbmQgc3RvcmUgdGhlIGNhbGN1bGF0aW9uIHNvbWV3aGVyZS4KCj4g ICAvKiBpbnRlbF9ob3RwbHVnLmMgKi8KPiAgIHZvaWQgaW50ZWxfaHBkX2lycV9oYW5kbGVyKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAkJCSAgIHUzMiBwaW5fbWFzaywg dTMyIGxvbmdfbWFzayk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2VuZ2luZV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBp bmRleCAxYTgzNzA3Li4zYjZiYzVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2VuZ2luZV9jcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5n aW5lX2NzLmMKPiBAQCAtNzk5LDYgKzc5OSwxOCBAQCBjb25zdCBjaGFyICppOTE1X2NhY2hlX2xl dmVsX3N0cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgaW50IHR5cGUpCj4gICAJfQo+ ICAgfQo+ICAgCj4gK3UzMiBjYWxjdWxhdGVfbWNyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwgdTMyIG1jcikKPiArewo+ICsJY29uc3Qgc3RydWN0IHNzZXVfZGV2X2luZm8gKnNz ZXUgPSAmKElOVEVMX0lORk8oZGV2X3ByaXYpLT5zc2V1KTsKPiArCXUzMiBzbGljZSA9IGZscyhz c2V1LT5zbGljZV9tYXNrKTsKPiArCXUzMiBzdWJzbGljZSA9IGZscyhzc2V1LT5zdWJzbGljZV9t YXNrW3NsaWNlXSk7Cj4gKwo+ICsJbWNyICY9IH4oR0VOOF9NQ1JfU0xJQ0VfTUFTSyB8IEdFTjhf TUNSX1NVQlNMSUNFX01BU0spOwo+ICsJbWNyIHw9IEdFTjhfTUNSX1NMSUNFKHNsaWNlKSB8IEdF TjhfTUNSX1NVQlNMSUNFKHN1YnNsaWNlKTsKPiArCj4gKwlyZXR1cm4gbWNyOwo+ICt9Cj4gKwo+ ICAgc3RhdGljIGlubGluZSB1aW50MzJfdAo+ICAgcmVhZF9zdWJzbGljZV9yZWcoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgc2xpY2UsCj4gICAJCSAgaW50IHN1YnNsaWNl LCBpOTE1X3JlZ190IHJlZykKPiBAQCAtODMxLDE4ICs4NDMsMzAgQEAgcmVhZF9zdWJzbGljZV9y ZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgc2xpY2UsCj4gICAJaW50 ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXRfX2xvY2tlZChkZXZfcHJpdiwgZndfZG9tYWlucyk7Cj4g ICAKPiAgIAltY3IgPSBJOTE1X1JFQURfRlcoR0VOOF9NQ1JfU0VMRUNUT1IpOwo+ICsKPiAgIAkv Kgo+ICAgCSAqIFRoZSBIVyBleHBlY3RzIHRoZSBzbGljZSBhbmQgc3VibGljZSBzZWxlY3RvcnMg dG8gYmUgcmVzZXQgdG8gMAo+IC0JICogYWZ0ZXIgcmVhZGluZyBvdXQgdGhlIHJlZ2lzdGVycy4K PiArCSAqIGJlZm9yZSBHRU4xMCBvciB0byBhIGVuYWJsZWQgcy9zcyBwb3N0IEdFTjEwIGFmdGVy IHJlYWRpbmcgb3V0IHRoZQo+ICsJICogcmVnaXN0ZXJzLgo+ICAgCSAqLwo+IC0JV0FSTl9PTl9P TkNFKG1jciAmIG1jcl9zbGljZV9zdWJzbGljZV9tYXNrKTsKPiArCVdBUk5fT05fT05DRShJTlRF TF9HRU4oZGV2X3ByaXYpIDwgMTAgJiYKPiArCQkgICAgIChtY3IgJiBtY3Jfc2xpY2Vfc3Vic2xp Y2VfbWFzaykpOwoKQWR2YW50YWdlIG9mIHN0b3JpbmcgdGhlIGNhbGN1bGF0aW9uOiB5b3UgY2Fu IGFzc2VydCBoZXJlIGZvciB0aGUgCmV4cGVjdGVkIHZhbHVlLCBpbmRlcGVuZGVudGx5IG9mIHRo ZSBwbGF0Zm9ybS4KCj4gICAJbWNyICY9IH5tY3Jfc2xpY2Vfc3Vic2xpY2VfbWFzazsKPiAgIAlt Y3IgfD0gbWNyX3NsaWNlX3N1YnNsaWNlX3NlbGVjdDsKPiAgIAlJOTE1X1dSSVRFX0ZXKEdFTjhf TUNSX1NFTEVDVE9SLCBtY3IpOwo+ICAgCj4gICAJcmV0ID0gSTkxNV9SRUFEX0ZXKHJlZyk7Cj4g ICAKPiAtCW1jciAmPSB+bWNyX3NsaWNlX3N1YnNsaWNlX21hc2s7Cj4gKwkvKgo+ICsJICogV2FQ cm9ncmFtTWdzckZvckNvcnJlY3RTbGljZVNwZWNpZmljTW1pb1JlYWRzOmNubAo+ICsJICogZXhw ZWN0cyBtY3IgdG8gYmUgcHJvZ3JhbWVkIHRvIGEgZW5hYmxlZCBzbGljZS9zdWJzbGljZSBwYWly Cj4gKwkgKiBiZWZvcmUgYW55IE1NSU8gcmVhZCBpbnRvIHNsaWNlL3N1YnNsaWNlIHJlZ2lzdGVy Cj4gKwkgKi8KPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgMTApCj4gKwkJbWNyICY9IH5t Y3Jfc2xpY2Vfc3Vic2xpY2VfbWFzazsKPiArCWVsc2UKPiArCQltY3IgPSBjYWxjdWxhdGVfbWNy KGRldl9wcml2LCBtY3IpOwoKQW5vdGhlciBhZHZhbnRhZ2U6IG5vIGJyYW5jaGluZyBoZXJlIGVp dGhlci4KCj4gKwo+ICAgCUk5MTVfV1JJVEVfRlcoR0VOOF9NQ1JfU0VMRUNUT1IsIG1jcik7Cj4g ICAKPiAgIAlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dF9fbG9ja2VkKGRldl9wcml2LCBmd19k b21haW5zKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fy b3VuZHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMKPiBpbmRl eCBlYzlkMzQwLi44YTIzNTRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3dvcmthcm91bmRzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3Jr YXJvdW5kcy5jCj4gQEAgLTY0NSw4ICs2NDUsMjAgQEAgc3RhdGljIHZvaWQgY2ZsX2d0X3dvcmth cm91bmRzX2FwcGx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkJICAg R0FNVF9FQ09fRU5BQkxFX0lOX1BMQUNFX0RFQ09NUFJFU1MpOwo+ICAgfQo+ICAgCj4gK3N0YXRp YyB2b2lkIHdhX2luaXRfbWNyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAr ewo+ICsJdTMyIG1jcjsKPiArCj4gKwltY3IgPSBJOTE1X1JFQUQoR0VOOF9NQ1JfU0VMRUNUT1Ip Owo+ICsJbWNyID0gY2FsY3VsYXRlX21jcihkZXZfcHJpdiwgbWNyKTsKPiArCUk5MTVfV1JJVEUo R0VOOF9NQ1JfU0VMRUNUT1IsIG1jcik7Cj4gK30KPiArCj4gICBzdGF0aWMgdm9pZCBjbmxfZ3Rf d29ya2Fyb3VuZHNfYXBwbHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAg ewo+ICsJLyogV2FQcm9ncmFtTWdzckZvckNvcnJlY3RTbGljZVNwZWNpZmljTW1pb1JlYWRzOiBj bmwgKi8KPiArCXdhX2luaXRfbWNyKGRldl9wcml2KTsKPiArCj4gICAJLyogV2FEaXNhYmxlSTJt Q3ljbGVPbldSUG9ydDpjbmwgKHByZS1wcm9kKSAqLwo+ICAgCWlmIChJU19DTkxfUkVWSUQoZGV2 X3ByaXYsIENOTF9SRVZJRF9CMCwgQ05MX1JFVklEX0IwKSkKPiAgIAkJSTkxNV9XUklURShHQU1U X0NIS05fQklUX1JFRywKCldpdGggb25lIG9mIHRoZSB0d28gYWJvdmUgKGFwcHJvcHJpYXRlIHBy ZWZpeCBvciBzdG9yZSB2YWx1ZSksIHRoaXMgaXM6CgpSZXZpZXdlZC1ieTogT3NjYXIgTWF0ZW8g PG9zY2FyLm1hdGVvQGludGVsLmNvbT4KCkFuZCBhcyBhIHNpZGUgbm90ZTogdGhpcyBpcyBhbHNv IG5lZWRlZCBmb3IgSWNlbGFrZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==