From: Yong Zhao Subject: Re: [PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd Date: Thu, 6 Jul 2017 17:50:17 -0400 Message-ID: <7f50f1dc-a8cc-acd0-a96a-9e3a2b60df36@amd.com> References: <1499116294-12817-1-git-send-email-Felix.Kuehling@amd.com> <1499116294-12817-7-git-send-email-Felix.Kuehling@amd.com> <641e1921-3adb-a3d4-0e9c-4f309c58e4ab@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: Felix Kuehling , amd-gfx list CgpPbiAyMDE3LTA3LTA2IDA1OjQ0IFBNLCBBbGV4IERldWNoZXIgd3JvdGU6Cj4gT24gVGh1LCBK dWwgNiwgMjAxNyBhdCA1OjMzIFBNLCBZb25nIFpoYW8gPHlvbmcuemhhb0BhbWQuY29tPiB3cm90 ZToKPj4gSGkgQWxleCwKPj4KPj4gQXMgZmFyIGFzIEkga25vdywgd2UgbmV2ZXIgdGVzdGVkIHN1 c3BlbmQvcmVzdW1lIG9uIHRoZSBzZXR0aW5nIHlvdQo+PiBtZW50aW9uZWQuIFRoZW9yZXRpY2Fs bHkgaXQgc2hvdWxkIHdvcmsuCj4gQXJlIHRoZSBrZmQgcy9yIGVudHJ5IHBvaW50cyBnbG9iYWwg b3IgcGVyIEdQVT8gIElmIHlvdSBoYXZlIHR3byBHUFVzCj4gYW5kIHlvdSBzdXNwZW5kIG9uZSwg d2lsbCBpdCBzdXNwZW5kIHRoZSBlbnRpcmUga2ZkPyAgSSdtIGZpbmUgd2l0aAo+IHRoZSBjaGFu Z2UsIGl0J3Mgbm8gd29yc2UgdGhhbiB0aGUgY3VycmVudCBzaXR1YXRpb24uICBNb3N0bHkganVz dAo+IGN1cmlvdXMuCmtmZCBzL3IgaXMgcGVyIEdQVS4gSWYgd2Ugc3VzcGVuZCBvbmx5IG9uZSBv dXQgb2YgdHdvIEdQVXMsIHRoZSBvdGhlciAKb25lIHdpbGwga2VlcCB3b3JraW5nLgo+Cj4+IFdo ZW4gSSByZWFkIHRoZSBjb2RlIG5vdywgSSB3YXMgd29uZGVyaW5nIHdoZXRoZXIgd2Ugc2hvdWxk IHN0b3Aga2ZkIGJlZm9yZQo+PiBhbWRncHVfYm9fZXZpY3RfdnJhbSgpIGFuZCBhbWRncHVfZmVu Y2VfZHJpdmVyX3N1c3BlbmQoKS4gSWYgdGhhdCdzIG5vdAo+PiBuZWVkZWQsIGl0IG1heSBtYWtl IG1vcmUgc2Vuc2UgdG8gc3RpY2sgdG8gdGhlIHByZXZpb3VzIGRlc2lnbiB3aGljaCBrZXB0Cj4+ IHRoZSBrZmQgc3VzcGVuZC9yZXN1bWUgaW5zaWRlIHlvdXIgSVAgYmxvY2sgc3VzcGVuZC9yZXN1 bWUuCj4gSSB0aGluayBpdCBtYWtlcyBtb3JlIHNlbnNlIHRvIHB1dCB0aGUga2ZkIGNhbGxzIGlu IHRoZSBjb21tb24gZGV2aWNlCj4gcy9yIGNvZGUgcmF0aGVyIHRoYW4gaW4gdGhlIHNvYyBzcGVj aWZpYyBpcCBmdW5jdGlvbnMuICBDaGFuZ2UgaXM6Cj4gUmV2aWV3ZWQtYnk6IEFsZXggRGV1Y2hl ciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KPgo+Cj4+IFJlZ2FyZHMsCj4+Cj4+IFlvbmcK Pj4KPj4KPj4KPj4gT24gMjAxNy0wNy0wNiAwNTowNiBQTSwgQWxleCBEZXVjaGVyIHdyb3RlOgo+ Pj4gT24gTW9uLCBKdWwgMywgMjAxNyBhdCA1OjExIFBNLCBGZWxpeCBLdWVobGluZyA8RmVsaXgu S3VlaGxpbmdAYW1kLmNvbT4KPj4+IHdyb3RlOgo+Pj4+IEZyb206IFlvbmcgWmhhbyA8eW9uZy56 aGFvQGFtZC5jb20+Cj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBZb25nIFpoYW8gPHlvbmcuemhh b0BhbWQuY29tPgo+Pj4+IFJldmlld2VkLWJ5OiBGZWxpeCBLdWVobGluZyA8RmVsaXguS3VlaGxp bmdAYW1kLmNvbT4KPj4+IERvZXMgdGhpcyB3b3JrIHByb3Blcmx5IGZvciBtdWx0aXBsZSBHUFVz PyAgRS5nLiwgaWYgb25lIGlzIHN1c3BlbmRlZAo+Pj4gYW5kIGFub3RoZXIgaXMgbm90PyAgRS5n LiwgUFggbGFwdG9wcyB3aGVyZSB3ZSBydW50aW1lIHN1c3BlbmQgdGhlCj4+PiBkR1BVIHdoaWxl IHRoZSBBUFUgaXMgc3RpbGwgcnVubmluZy4KPj4+Cj4+PiBBbGV4Cj4+Pgo+Pj4+IC0tLQo+Pj4+ ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8IDcgKysrKysr Kwo+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Npay5jICAgICAgICAgICB8IDkg Ky0tLS0tLS0tCj4+Pj4gICAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVs ZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2RldmljZS5jCj4+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfZGV2aWNlLmMKPj4+PiBpbmRleCA1YjEyMjBmLi5iYzY5YjljIDEwMDY0NAo+Pj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+Pj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+Pj4+IEBAIC01Niw2ICs1 Niw4IEBACj4+Pj4gICAgI2luY2x1ZGUgPGxpbnV4L2Zpcm13YXJlLmg+Cj4+Pj4gICAgI2luY2x1 ZGUgImFtZGdwdV92Zl9lcnJvci5oIgo+Pj4+Cj4+Pj4gKyNpbmNsdWRlICJhbWRncHVfYW1ka2Zk LmgiCj4+Pj4gKwo+Pj4+ICAgIE1PRFVMRV9GSVJNV0FSRSgiYW1kZ3B1L3ZlZ2ExMF9ncHVfaW5m by5iaW4iKTsKPj4+PiAgICBNT0RVTEVfRklSTVdBUkUoImFtZGdwdS9yYXZlbl9ncHVfaW5mby5i aW4iKTsKPj4+Pgo+Pj4+IEBAIC0yMzk3LDYgKzIzOTksOCBAQCBpbnQgYW1kZ3B1X2RldmljZV9z dXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4gYm9vbCBzdXNwZW5kLCBib29sIGZi Y29uKQo+Pj4+ICAgICAgICAgICAgICAgICAgIGRybV9tb2Rlc2V0X3VubG9ja19hbGwoZGV2KTsK Pj4+PiAgICAgICAgICAgfQo+Pj4+Cj4+Pj4gKyAgICAgICBhbWRncHVfYW1ka2ZkX3N1c3BlbmQo YWRldik7Cj4+Pj4gKwo+Pj4+ICAgICAgICAgICAvKiB1bnBpbiB0aGUgZnJvbnQgYnVmZmVycyBh bmQgY3Vyc29ycyAqLwo+Pj4+ICAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGNydGMsICZk ZXYtPm1vZGVfY29uZmlnLmNydGNfbGlzdCwgaGVhZCkgewo+Pj4+ICAgICAgICAgICAgICAgICAg IHN0cnVjdCBhbWRncHVfY3J0YyAqYW1kZ3B1X2NydGMgPSB0b19hbWRncHVfY3J0YyhjcnRjKTsK Pj4+PiBAQCAtMjUzNyw2ICsyNTQxLDkgQEAgaW50IGFtZGdwdV9kZXZpY2VfcmVzdW1lKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4gYm9vbCByZXN1bWUsIGJvb2wgZmJjb24pCj4+Pj4gICAg ICAgICAgICAgICAgICAgICAgICAgICB9Cj4+Pj4gICAgICAgICAgICAgICAgICAgfQo+Pj4+ICAg ICAgICAgICB9Cj4+Pj4gKyAgICAgICByID0gYW1kZ3B1X2FtZGtmZF9yZXN1bWUoYWRldik7Cj4+ Pj4gKyAgICAgICBpZiAocikKPj4+PiArICAgICAgICAgICAgICAgcmV0dXJuIHI7Cj4+Pj4KPj4+ PiAgICAgICAgICAgLyogYmxhdCB0aGUgbW9kZSBiYWNrIGluICovCj4+Pj4gICAgICAgICAgIGlm IChmYmNvbikgewo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9j aWsuYwo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvY2lrLmMKPj4+PiBpbmRleCA2 Y2U5ZjgwLi4wMDYzOWJmIDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2Npay5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvY2lrLmMKPj4+ PiBAQCAtMTgyNSwyMSArMTgyNSwxNCBAQCBzdGF0aWMgaW50IGNpa19jb21tb25fc3VzcGVuZCh2 b2lkICpoYW5kbGUpCj4+Pj4gICAgewo+Pj4+ICAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2Rldmlj ZSAqYWRldiA9IChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqKWhhbmRsZTsKPj4+Pgo+Pj4+IC0gICAg ICAgYW1kZ3B1X2FtZGtmZF9zdXNwZW5kKGFkZXYpOwo+Pj4+IC0KPj4+PiAgICAgICAgICAgcmV0 dXJuIGNpa19jb21tb25faHdfZmluaShhZGV2KTsKPj4+PiAgICB9Cj4+Pj4KPj4+PiAgICBzdGF0 aWMgaW50IGNpa19jb21tb25fcmVzdW1lKHZvaWQgKmhhbmRsZSkKPj4+PiAgICB7Cj4+Pj4gLSAg ICAgICBpbnQgcjsKPj4+PiAgICAgICAgICAgc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSAo c3RydWN0IGFtZGdwdV9kZXZpY2UgKiloYW5kbGU7Cj4+Pj4KPj4+PiAtICAgICAgIHIgPSBjaWtf Y29tbW9uX2h3X2luaXQoYWRldik7Cj4+Pj4gLSAgICAgICBpZiAocikKPj4+PiAtICAgICAgICAg ICAgICAgcmV0dXJuIHI7Cj4+Pj4gLQo+Pj4+IC0gICAgICAgcmV0dXJuIGFtZGdwdV9hbWRrZmRf cmVzdW1lKGFkZXYpOwo+Pj4+ICsgICAgICAgcmV0dXJuIGNpa19jb21tb25faHdfaW5pdChhZGV2 KTsKPj4+PiAgICB9Cj4+Pj4KPj4+PiAgICBzdGF0aWMgYm9vbCBjaWtfY29tbW9uX2lzX2lkbGUo dm9pZCAqaGFuZGxlKQo+Pj4+IC0tCj4+Pj4gMS45LjEKPj4+Pgo+Pj4+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4gYW1kLWdmeCBtYWlsaW5nIGxp c3QKPj4+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+Pj4+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+PgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QK YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==