Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2752EC433DF for ; Wed, 20 May 2020 16:52:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC63E2065F for ; Wed, 20 May 2020 16:52:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC63E2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jbRwj-0005Ve-Rg; Wed, 20 May 2020 16:51:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jbRwi-0005VY-LU for xen-devel@lists.xenproject.org; Wed, 20 May 2020 16:51:56 +0000 X-Inumbo-ID: 3649bdb8-9aba-11ea-aa4d-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3649bdb8-9aba-11ea-aa4d-12813bfff9fa; Wed, 20 May 2020 16:51:55 +0000 (UTC) Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: LijN6eRsVk4qRDzaB7Cgb3Y+TEBp7oqqgC4EbXBnSwREU68jJYVQcphcAH/9A2p5QFEwV+DolS pMhk+65xjIeCPZSrhiCzVFGxGz0djXnPkZCeS6l024ecfS/Y9WcDn1diiLmauts5molnya+K5q np+TJTKs9ILt0odvu63bXafPvYpWY+EHxOHyqHYg7bhUxePviG3OBh6kPIoPcHWgsXN4NId9Bl ycUkP1uuc+0UVC/4y+T32Us93nfGHvKfJZ584+sYjVpKcTOzRrMxgMgCcnw9sXI1onq0pN7mGN boQ= X-SBRS: 2.7 X-MesageID: 18274377 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,414,1583211600"; d="scan'208";a="18274377" Subject: Re: [PATCH] VT-x: extend LBR Broadwell errata coverage To: Jan Beulich References: From: Andrew Cooper Message-ID: <7f5f70ff-7f30-b7db-eb51-c2f2df9ce58a@citrix.com> Date: Wed, 20 May 2020 17:51:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Kevin Tian , Jun Nakajima , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 20/05/2020 16:56, Jan Beulich wrote: > On 20.05.2020 16:07, Andrew Cooper wrote: >> On 20/05/2020 13:52, Jan Beulich wrote: >>> @@ -2895,15 +2897,26 @@ static void __init lbr_tsx_fixup_check(v >>> static void __init bdf93_fixup_check(void) >> Seeing as this is no longer just BDF93, how about ler_tsx_fixup_check() ? > I did consider renaming, and didn't do so just because this would > grow the patch size quite a bit. I don't see that as a problem. > I'm fine doing so, but with the > name you suggest, is this one really as directly TSX related as the > other one? I had thought of something like lbr_bdw_fixup_check(). The errata wording doesn't mention TSX, but the breakage manifests in the same way, with bits 61 and 62 clear but hardware expecting to see a canonicalised value on restore. Also, it is very specifically LER-from which gets clobbered, rather than any of the regular LBR registers. I'm not overly fussed what the naming is, but it oughtn't to include bdf93 any more, now the scope of the workaround has been extended. ~Andrew