From: "plaisthos (Code Review)" Date: Mon, 22 Jan 2024 12:45:12 +0000 References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <7ff1e5f7717b7ef3102ae50d125f9728c1424ce0-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="qAo/KWW2dWI="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix ssl unit tests on OpenSSL 1.0.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --qAo/KWW2dWI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/503?usp=3Demail to review the following change. Change subject: Fix ssl unit tests on OpenSSL 1.0.2 ...................................................................... Fix ssl unit tests on OpenSSL 1.0.2 OpenSSL 1.1.1 will initialise itself using clever linker magic. For OpenSSL 1.0.2 we need to manually initialise the library. For other unit tests just doing the OpenSSL_add_all_algorithms is enough but this unit test needs a more complete initialisation. Change-Id: I378081f391ad755d0a6fd5613de5c2a8bacc389a --- M tests/unit_tests/openvpn/test_ssl.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/03/503/1 diff --git a/tests/unit_tests/openvpn/test_ssl.c b/tests/unit_tests/openvpn= /test_ssl.c index fd2049f..d0c3df7 100644 --- a/tests/unit_tests/openvpn/test_ssl.c +++ b/tests/unit_tests/openvpn/test_ssl.c @@ -127,13 +127,13 @@ }; #if defined(ENABLE_CRYPTO_OPENSSL) - OpenSSL_add_all_algorithms(); + tls_init_lib(); #endif int ret =3D cmocka_run_group_tests_name("crypto tests", tests, NULL, N= ULL); #if defined(ENABLE_CRYPTO_OPENSSL) - EVP_cleanup(); + tls_free_lib(); #endif return ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/503?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I378081f391ad755d0a6fd5613de5c2a8bacc389a Gerrit-Change-Number: 503 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --qAo/KWW2dWI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

plaisthos would like flichtenheld to review this change.

Vi= ew Change

Fix ssl unit tests on OpenSSL 1.0.2

OpenSSL 1.1.1 will= initialise itself using clever linker magic. For
OpenSSL 1.0.2 we need = to manually initialise the library. For other
unit tests just doing the = OpenSSL_add_all_algorithms is enough but
this unit test needs a more com= plete initialisation.

Change-Id: I378081f391ad755d0a6fd5613de5c2a8ba= cc389a
---
M tests/unit_tests/openvpn/test_ssl.c
1 file changed, 2= insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:=
29418/openvpn refs/changes/03/503/1
diff --git a/tests/unit_tests/o=
penvpn/test_ssl.c b/tests/unit_tests/openvpn/test_ssl.c
ind= ex fd2049f..d0c3df7 100644
--- a/tests/unit_tests/openvpn/t= est_ssl.c
+++ b/tests/unit_tests/openvpn/test_ssl.c<= br>@@ -127,13 +127,13 @@
};

#if defined(ENABLE_CRYPTO_OPENSSL)
- OpenSSL_add_all_algorithms();
+ tls_init_lib();

#endif

int ret =3D cmocka_run_gr= oup_tests_name("crypto tests", tests, NULL, NULL);

#if defined(ENABLE_CRYPTO_OPENSSL)
- EVP_cleanup();
+ tls_free_lib();
#end= if

return ret;

To view, visit change 503. To unsubscribe, or for help writing ma= il filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I378081f391ad755d0a6fd5613de= 5c2a8bacc389a
Gerrit-Change-Number: 503
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--qAo/KWW2dWI=--