Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55884FA3741 for ; Mon, 31 Oct 2022 16:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231907AbiJaQkK (ORCPT ); Mon, 31 Oct 2022 12:40:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231894AbiJaQkG (ORCPT ); Mon, 31 Oct 2022 12:40:06 -0400 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B985273D for ; Mon, 31 Oct 2022 09:40:06 -0700 (PDT) Received: by mail-pg1-f181.google.com with SMTP id q1so11138933pgl.11 for ; Mon, 31 Oct 2022 09:40:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G5iO8KHmbbjpD0edAAD18XYUlbSGy4UU+ld7nxMCDFQ=; b=yiXkY0BHrlLcAP0pQRUp4NJCbYk4RxGiA00b4YJYy3U3LwBMLMf5wC3gztDt0vT8Iw rgkGaCZxux+3KxNkC7MNVAo5/qLc8yNcAaCyLOnuHEx+7BjQPS8IaCTKVDOmnIedcNZq JkBmLDrNg1ivZDeARPjs5VFlGDRR/LN59Qp5rxVww9FnOD9W689gbNNCrLTvTUWC3X8m Y1NoVakuk2p4TQdq3D7oMz/Q0lPhekfvwYDLbs5k90ApidzN2rbwrMWc8Ltkon7lPr8I +Vd6xbnxZGK/TnGKJ0NzgkMEQnLC6xa9VTfkOGxBLYRon0SWTPjgdKI+wbvCe2WeMlaz B8sA== X-Gm-Message-State: ACrzQf0U86c6jF3OQSZv8HF5pYu4JM/JT8JAYCV5mlZL4pYT52NPTorJ 1Swsg8HSRYkxF+szjF8Ix9bpag== X-Google-Smtp-Source: AMsMyM4wbIhY06SY2nUR74pUKGuIl5gTFPk+xpQFABfA9XZzwdh1qCxm1jXpjY9c4HML23XPnl7EdQ== X-Received: by 2002:a63:c146:0:b0:46f:c9e8:777d with SMTP id p6-20020a63c146000000b0046fc9e8777dmr4645744pgi.459.1667234405901; Mon, 31 Oct 2022 09:40:05 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id i63-20020a625442000000b0056be2a3c87csm4835445pfb.154.2022.10.31.09.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 09:40:05 -0700 (PDT) From: Kevin Hilman To: bchihi@baylibre.com, sean.wang@kernel.org, linus.walleij@linaro.org, matthias.bgg@gmail.com Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [v2, 0/2] Fix broken SET/CLR mode of a certain number of pins for MediaTek MT8385 SoC In-Reply-To: <20221021084708.1109986-1-bchihi@baylibre.com> References: <20221021084708.1109986-1-bchihi@baylibre.com> Date: Mon, 31 Oct 2022 09:40:04 -0700 Message-ID: <7h5yg02bh7.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Balsam, bchihi@baylibre.com writes: > From: Balsam CHIHI > > On MT8365, the SET/CLR of the mode is broken and some pins won't set or clear the modes correctly. > To fix this issue, we add a specific callback mt8365_set_clr_mode() for this specific SoC. > This callback uses the main R/W register to read/update/write the modes instead of using the SET/CLR register. > > This is the original patch series proposed by Fabien Parent . > "https://lore.kernel.org/linux-arm-kernel/20220530123425.689459-1-fparent@baylibre.com/" > > Changelog: > Changes in v2 : > - Rebase on top of 6.1.0-rc1-next-20221020 > - Delete MTK_PINCTRL_MODE_SET_CLR_BROKEN quirk > - Add mt8365_set_clr_mode() callback nit: subject of cover letter should also include "pinctrl: mediatek:" prefix. Also note that you're missing the word "PATCH" in all of the subjects. Tip: If you use `git format-patch`, you can just pass `-v2` on the cmdline and it will create the prefixes for you automatically. Kevin