From: Junio C Hamano Date: Thu, 25 Dec 2008 06:17:15 +0000 Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a Message-Id: <7vd4fgdbis.fsf@gitster.siamese.dyndns.org> List-Id: References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191507.11807.50794.stgit@vmbox.hanneseder.net> <1230053186.1447.9.camel@brick> In-Reply-To: (Krzysztof Halasa's message of "Wed, 24 Dec 2008 03:03:50 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Krzysztof Halasa Cc: Linus Torvalds , Harvey Harrison , =?utf-8?B?SMOla29uIEzDuHZkYWw=?= , Hannes Eder , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Krzysztof Halasa writes: > Linus Torvalds writes: > ... >> Another example of "common vs non-common" is this: >> >> if (0 <= x) >> do something.. >> >> is something that crazy people do (sadly, one of the crazy people taught >> the git maintainer C programming, so now even sane people do it). It's >> crazy because it's uncommon, which means that most people have to think >> about it A LOT MORE than about >> >> if (x >= 0) >> do something.. > > No. It's crazy not because it's uncommon, but because this is how we > have been taught in school. > > I don't know reasons for "0 >= x" but I know one for > if (0 = x) > do something.. > > It's because people sometimes write "=" instead of "=" and "0 = x" > doesn't make sense to gcc. It does not have anything to do with the assignment confusion. It is "textual order should reflect actual order" (aka "have number line in your head when you write your comparison conditional"): http://thread.gmane.org/gmane.comp.version-control.git/3903/focusA26 Even if it may make logical sense, I would not suggest using it when other people are not familiar with the convention, though.