From: Junio C Hamano Subject: Re: [PATCH 1/4] Always perfer annotated tags in git-describe. Date: Sun, 14 Jan 2007 13:36:28 -0800 Message-ID: <7vd55hffz7.fsf@assigned-by-dhcp.cox.net> References: <20070113222752.GA18011@spearce.org> <7v8xg5h19z.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Jan 15 19:31:12 2007 Return-path: Envelope-to: gcvg-git@m.gmane.org Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by lo.gmane.org with esmtp (Exim 4.50) id 1H6VWQ-0000o7-SD for gcvg-git@m.gmane.org; Mon, 15 Jan 2007 18:21:26 +0100 Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1H6V8C-0003eK-2R for gcvg-git@m.gmane.org; Mon, 15 Jan 2007 17:56:24 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbXANVge (ORCPT ); Sun, 14 Jan 2007 16:36:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751691AbXANVge (ORCPT ); Sun, 14 Jan 2007 16:36:34 -0500 Received: from fed1rmmtao09.cox.net ([68.230.241.30]:46741 "EHLO fed1rmmtao09.cox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbXANVge (ORCPT ); Sun, 14 Jan 2007 16:36:34 -0500 Received: from fed1rmimpo02.cox.net ([70.169.32.72]) by fed1rmmtao09.cox.net (InterMail vM.6.01.06.03 201-2131-130-104-20060516) with ESMTP id <20070114213633.EAMY18767.fed1rmmtao09.cox.net@fed1rmimpo02.cox.net>; Sun, 14 Jan 2007 16:36:33 -0500 Received: from assigned-by-dhcp.cox.net ([68.5.247.80]) by fed1rmimpo02.cox.net with bizsmtp id B9cq1W0011kojtg0000000; Sun, 14 Jan 2007 16:36:50 -0500 To: "Shawn O. Pearce" In-Reply-To: <7v8xg5h19z.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Sun, 14 Jan 2007 11:11:04 -0800") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > "Shawn O. Pearce" writes: > >> @@ -148,17 +149,17 @@ static void describe(const char *arg, int last_one) >> else >> all_matches = p; >> cur_match = p; >> + if (n->prio == 2) >> + continue; > > When you do not have _any_ annotated tag but you do have > lightweight tags, wouldn't this make the traversal go all the > way down to root? This is irrelevant now. Please ignore.