From: "cron2 (Code Review)" Date: Mon, 4 Aug 2025 09:15:55 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <803725a4a309dbf9553ed751899c9716113a504d-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="pKl4PjTmFwI="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Disable clang-format for some code parts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --pKl4PjTmFwI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#13) to the change originally created b= y flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/829?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Disable clang-format for some code parts ...................................................................... Disable clang-format for some code parts These do not come out better with clang-format, so leave them be. Change-Id: I4dd0c44982955f16ec4a3f167d4e6f3e9b4dbc11 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250804091027.13509-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 492.html Signed-off-by: Gert Doering --- M src/openvpn/ssl_common.h M src/tapctl/main.c 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/29/829/13 diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h index 90c0086..1fdc187 100644 --- a/src/openvpn/ssl_common.h +++ b/src/openvpn/ssl_common.h @@ -74,6 +74,7 @@ * * @{ */ +/* clang-format off */ #define S_ERROR (-2) /**< Error state. */ #define S_ERROR_PRE (-1) /**< Error state but try to send out alerts * before killing the keystore and moving @@ -104,7 +105,7 @@ #define S_GENERATED_KEYS 8 /**< The data channel keys have been gener= ated * The TLS session is fully authenticated * when reaching this state. */ - +/* clang-format on */ /* Note that earlier versions also had a S_OP_NORMAL state that was * virtually identical with S_ACTIVE and the code still assumes everything * >=3D S_ACTIVE to be fully operational */ diff --git a/src/tapctl/main.c b/src/tapctl/main.c index 82caeaf..0dec303 100644 --- a/src/tapctl/main.c +++ b/src/tapctl/main.c @@ -36,6 +36,7 @@ #endif +/* clang-format off */ const WCHAR title_string[] =3D _L(PACKAGE_NAME) L" " _L(PACKAGE_VERSION) ; @@ -110,6 +111,7 @@ L"\n" L"tapctl delete \n" ; +/* clang-format on */ /** -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/829?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4dd0c44982955f16ec4a3f167d4e6f3e9b4dbc11 Gerrit-Change-Number: 829 Gerrit-PatchSet: 13 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --pKl4PjTmFwI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #13 to the change originally c= reated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

Disable clang-format for some code parts

Thes= e do not come out better with clang-format,
so leave them be.

Cha= nge-Id: I4dd0c44982955f16ec4a3f167d4e6f3e9b4dbc11
Signed-off-by: Frank L= ichtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1386...= 296...>
Message-Id: <20250804091027.13509-1-gert@...1296...>URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg3= 2492.html
Signed-off-by: Gert Doering <gert@...1296...>
---
= M src/openvpn/ssl_common.h
M src/tapctl/main.c
2 files changed, 4 ins= ertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418=
/openvpn refs/changes/29/829/13
diff --git a/src/openvpn/ssl_common=
.h b/src/openvpn/ssl_common.h
index 90c0086..1fdc187 100644=
--- a/src/openvpn/ssl_common.h
+++ b/src/o= penvpn/ssl_common.h
@@ -74,6 +74,7 @@
*
* @{
*/
+/* clang-format off */
#define S_ER= ROR (-2) /**< Error state. */
#define S_ERR= OR_PRE (-1) /**< Error state but try to send out alerts * before killing the keystore and= moving
@@ -104,7 +105,7 @@
#define S_GENE= RATED_KEYS 8 /**< The data channel keys have been generated<= br> * The TLS session is fully auth= enticated
* when reachin= g this state. */
-
+/* clang-format on */
/* Note that earlier versions also had a S_OP_NORMAL state t= hat was
* virtually identical with S_ACTIVE and the code = still assumes everything
* >=3D S_ACTIVE to be fully o= perational */
diff --git a/src/tapctl/main.c b/src/tapctl/m= ain.c
index 82caeaf..0dec303 100644
--- a/s= rc/tapctl/main.c
+++ b/src/tapctl/main.c
@@= -36,6 +36,7 @@
#endif

=
+/* clang-format off= */
const WCHAR title_string[] =3D
_L= (PACKAGE_NAME) L" " _L(PACKAGE_VERSION)
;=
@@ -110,6 +111,7 @@
L"\n" L"tapctl delete <adapter GUID | adapter name>\n&quo= t;
;
+/* clang-format on */


/**


To view, visit change 829. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4dd0c44982955f16ec4a3f167d4= e6f3e9b4dbc11
Gerrit-Change-Number: 829
Gerrit-PatchSet: 13
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--pKl4PjTmFwI=--