Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCE1C433DB for ; Tue, 26 Jan 2021 13:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E6162255F for ; Tue, 26 Jan 2021 13:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404749AbhAZNkF (ORCPT ); Tue, 26 Jan 2021 08:40:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:35859 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392005AbhAZNjK (ORCPT ); Tue, 26 Jan 2021 08:39:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611668264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5j8pQllFKQxPrqWZ1anCyJsDg/+zpfGgGPYxYabCaU8=; b=VksebxE3q0WtHGsRmLNQ89MXTSCaA9C/+etCj9dQtwfXpENOc5Zhkh1YEitGC+jImbNa5Y SjA0odRfYatgQ005Um3Hb9Pqt60nMXF8YnI3B+nU0dAzu3kYVPMvLFDFMhW55u/tBROGGU aL8ZRloCT5EZJA7eq0Akizl1zyRMAR0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-OngGLZ2aPtyDubPMCgw2xQ-1; Tue, 26 Jan 2021 08:37:43 -0500 X-MC-Unique: OngGLZ2aPtyDubPMCgw2xQ-1 Received: by mail-ej1-f70.google.com with SMTP id p1so4924085ejo.4 for ; Tue, 26 Jan 2021 05:37:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5j8pQllFKQxPrqWZ1anCyJsDg/+zpfGgGPYxYabCaU8=; b=NPQ3MQEcLyaZcWhz/Zv0IUZf9g4BV+dg7jNuZOsoPLP4fJF8CE0m2Blc8SDuXvZDB2 5K95pxDKCvAouS9GsRxO2CVX49DFq5bfeEOJxzg8PsTWBELr1x4BJYupNiYUVz/e4nnh heztuZaeJGw0pWQ8jTDh3BnIw2iaA9irdPButnhM6EIrl1+Hbk/HaT+JxTI6cs5fDTlG ANDz4AUlJTpL5R68gVWQ7+D/d8SeVgp3miw/urJtximqJsdN2n3q2PtuTcRtxMv93Mou T+kib2RTYAVseOrlf1k5HTPe648ESYg6z6FQLzvVv1onEnqJS39t9ZWpErE2RffR4plC hNJg== X-Gm-Message-State: AOAM532YGynyX8f2UbIMzlCtnR/hlYi2aJiMoaBWwgPs7hBrQNgbxX/l Tj0YyzZrw18zyKeYq3BGxbrNM1IWxspGW6AyCj+Ij2B1NiJu7VWzpMS2rt9bVhQ7mQ8x61dSUsk u4pfqzJcfgF4Q X-Received: by 2002:a17:906:dbf2:: with SMTP id yd18mr3405952ejb.45.1611668261802; Tue, 26 Jan 2021 05:37:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgOSwhx7PScb9UCOX6vbEBbq/P7OBx6h3Jx7iIjwk1PADyZsfXUMbn6cWGh/XzSO50XoWU7w== X-Received: by 2002:a17:906:dbf2:: with SMTP id yd18mr3405938ejb.45.1611668261677; Tue, 26 Jan 2021 05:37:41 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id q22sm9747892ejx.3.2021.01.26.05.37.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jan 2021 05:37:40 -0800 (PST) To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20210112181041.356734-1-bgardon@google.com> <20210112181041.356734-25-bgardon@google.com> From: Paolo Bonzini Subject: Re: [PATCH 24/24] kvm: x86/mmu: Allow parallel page faults for the TDP MMU Message-ID: <8079ca49-d9fe-94ae-9e6c-ebe6e8e1035d@redhat.com> Date: Tue, 26 Jan 2021 14:37:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210112181041.356734-25-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/01/21 19:10, Ben Gardon wrote: > + if (is_tdp_mmu_root(vcpu->kvm, vcpu->arch.mmu->root_hpa)) > + kvm_mmu_lock_shared(vcpu->kvm); > + else > + kvm_mmu_lock(vcpu->kvm); Perhaps the better API would be kvm_mmu_lock/unlock_root; not exposing kvm_mmu_lock/unlock_shared and kvm_mmu_lock/unlock_exclusive at all, just like you use rwlock_needbreak directly in kvm_mmu_lock_needbreak. Paolo