From: "flichtenheld (Code Review)"
Date: Thu, 7 Aug 2025 15:53:29 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <809d7961e7471110745016662780b2773d51502d-EmailReplacePatchSet-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="Z9K9Qf3OdGY="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: t_client.sh: Do not
wait 3 seconds for OpenVPN to come up
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--Z9K9Qf3OdGY=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1139?usp=3Demail
to look at the new patch set (#2).
Change subject: t_client.sh: Do not wait 3 seconds for OpenVPN to come up
......................................................................
t_client.sh: Do not wait 3 seconds for OpenVPN to come up
On most machines 1 second should be quite enough. Given
that we run currently 23 tests on most t_client runs, this
makes over 40 seconds difference. Not nothing.
We keep the existing 30s maximum wait-time since sometimes
we want to do tests with intentionally slow servers.
Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8
Signed-off-by: Frank Lichtenheld
---
M tests/t_client.sh.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/39/1139/2
diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in
index 7a271b6..a49de40 100755
--- a/tests/t_client.sh.in
+++ b/tests/t_client.sh.in
@@ -377,13 +377,13 @@
$RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log &
sudopid=3D$!
- # Check if OpenVPN has initialized before continuing. It will check e=
very 3rd second up
+ # Check if OpenVPN has initialized before continuing. It will check e=
very second up
# to $ovpn_init_check times.
- ovpn_init_check=3D10
+ ovpn_init_check=3D30
ovpn_init_success=3D0
while [ $ovpn_init_check -gt 0 ];
do
- sleep 3 # Wait for OpenVPN to initialize and have had time to writ=
e the pid file
+ sleep 1 # Wait for OpenVPN to initialize and have had time to writ=
e the pid file
grep "Initialization Sequence Completed" $LOGDIR/$SUF:openvpn.log >=
/dev/null
if [ $? -eq 0 ]; then
ovpn_init_check=3D0
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1139?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8
Gerrit-Change-Number: 1139
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-MessageType: newpatchset
--Z9K9Qf3OdGY=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld uploaded patch set #2 to this change.
t_client.sh: Do not wait 3 seconds for OpenVPN to come up
=
On most machines 1 second should be quite enough. Given that we run curr=
ently 23 tests on most t_client runs, this makes over 40 seconds differe=
nce. Not nothing.
We keep the existing 30s maximum wait-time since s=
ometimes we want to do tests with intentionally slow servers.
Cha=
nge-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8 Signed-off-by: Frank L=
ichtenheld <frank@...2641...> --- M tests/t_client.sh.in 1 f=
ile changed, 3 insertions(+), 3 deletions(-)
diff --git a/tes=
ts/t_client.sh.in b/tests/t_client.sh.in index 7a271b6..a49=
de40 100755 --- a/tests/t_client.sh.in +++ =
b/tests/t_client.sh.in @@ -377,13 +377,13 @@ $RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:=
openvpn.log & sudopid=3D$! - # Check if OpenVPN has =
initialized before continuing. It will check every 3rd second up + # Check if OpenVPN has in=
itialized before continuing. It will check every second up # to $ovpn_init_check times. - ovpn_init_check=3D10 + ovpn_init_check=3D30 ovpn_init_s=
uccess=3D0 while [ $ovpn_init_check -gt 0 ]; do - =
sleep 3 # Wait for OpenVPN to initialize and have had time to write the pi=
d file + sleep =
1 # Wait for OpenVPN to initialize and have had time to write the pid file=
grep "Initialization Sequence Completed"=
$LOGDIR/$SUF:openvpn.log >/dev/null if [ $? -eq=
0 ]; then ovpn_init_check=3D0 =
To view, visit change 1139. To unsubscribe, or for help wri=
ting mail filters, visit set=
tings.