Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CD73C3DA79 for ; Mon, 15 Jan 2024 13:40:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A5A408753A; Mon, 15 Jan 2024 14:40:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="grUVoP2w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2409387186; Mon, 15 Jan 2024 14:40:31 +0100 (CET) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9091587559 for ; Mon, 15 Jan 2024 14:40:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=1744d57945=patrick.delaunay@foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40F8aUtr004759; Mon, 15 Jan 2024 14:40:25 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=/0Ci2/0LanhHZpnb5rx4II8xpoa+UzkODcMYRqHv48Y=; b=gr UVoP2wZGykHs8zuArQdnBtrQZ1LYWW/92r+3lKoi5/5XfUSxihy46HGbd4DgJw+q RaIyJFnSlH9uQiB8y5YE6HYlloUTcgCcs9WEB0UttOxrQiKP/PkeR2iRX22maBgz 46Z1UTeyYUOwgIknpkA4iBVvcXyWCt4MjwwYWI3r8dJLQcX+2c6eveL6rlYqccY5 IdLf5Y43lP5uWl3DIDyztmaQCsaiBTyU7IZDVJN9yKFcAl3UC/iS1rqOVB4MHK1f QjtO3yBmSeH4lFJmuRhDnuBXPkIOCFCoSjTYNiXu8KJe6D6zpT3lgjR2t9aeFR40 Mx82glKWiCVCAY7FJr+Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3vkma5runv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Jan 2024 14:40:25 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3DEDE100057; Mon, 15 Jan 2024 14:40:25 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 34726286A3B; Mon, 15 Jan 2024 14:40:25 +0100 (CET) Received: from [10.201.22.165] (10.201.22.165) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 15 Jan 2024 14:40:24 +0100 Message-ID: <80ce8fac-da35-436b-b5ab-e01be63762e1@foss.st.com> Date: Mon, 15 Jan 2024 14:40:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/12] stm32mp: activate the command stboard for stm32mp25 boards To: Patrice CHOTARD , CC: Igor Opaniuk , Marek Vasut , Oleksandr Suvorov , U-Boot STM32 , Simon Glass References: <20240115124657.39109-1-patrick.delaunay@foss.st.com> <20240115134642.10.I7e8d4ae242605f7c9d276a858f336d13681528d9@changeid> Content-Language: en-US From: Patrick DELAUNAY In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.22.165] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-05_08,2024-01-05_01,2023-05-22_02 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On 1/15/24 14:03, Patrice CHOTARD wrote: > > On 1/15/24 13:46, Patrick Delaunay wrote: >> Activate the command stboard for stm32mp25 STMicroelectronics boards, >> add the default used OTP identifier and the associated board identifier: >> - stm32mp25xx-ev1 = MB1936 >> - stm32mp25xx-dk = MB1605 >> >> Signed-off-by: Patrick Delaunay >> --- >> >> arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + >> board/st/common/Kconfig | 2 +- >> board/st/common/cmd_stboard.c | 2 ++ >> 3 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach-stm32mp/include/mach/stm32.h >> index 45c929aa605d..726c390977e3 100644 >> --- a/arch/arm/mach-stm32mp/include/mach/stm32.h >> +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h >> @@ -198,6 +198,7 @@ enum forced_boot_mode { >> #define BSEC_OTP_SERIAL 5 >> #define BSEC_OTP_RPN 9 >> #define BSEC_OTP_PKG 122 >> +#define BSEC_OTP_BOARD 246 >> #define BSEC_OTP_MAC 247 >> #endif >> >> diff --git a/board/st/common/Kconfig b/board/st/common/Kconfig >> index c1c254d07354..5efac658cf4d 100644 >> --- a/board/st/common/Kconfig >> +++ b/board/st/common/Kconfig >> @@ -1,7 +1,7 @@ >> config CMD_STBOARD >> bool "stboard - command for OTP board information" >> depends on ARCH_STM32MP >> - default y if TARGET_ST_STM32MP15x || TARGET_ST_STM32MP13x >> + default y if TARGET_ST_STM32MP25X || TARGET_ST_STM32MP15X || TARGET_ST_STM32MP13X > TARGET_ST_STM32MP15x or TARGET_ST_STM32MP15X ? ;-) > Internally, we use all our flags in uppercase, whereas at upstream there are some > camelcase as TARGET_ST_STM32MP15x or TARGET_ST_STM32MP13x > Thks, I don't see that the Simon patches was not merged. I will correct this part in V2 and also include the 2 Simon patches which rename the stm32mp config to avoid the same issue in futur. See series "Clean up of bad Kconfig options" https://patchwork.ozlabs.org/project/uboot/list/?series=339004&state=* => [v2,67/87] arm: Rename STM32MP13x https://patchwork.ozlabs.org/project/uboot/patch/20230129005903.74918-68-sjg@chromium.org/ => [v2,68/87] arm: Rename STM32MP15x https://patchwork.ozlabs.org/project/uboot/patch/20230129005903.74918-69-sjg@chromium.org/ >> help >> This compile the stboard command to >> read and write the board in the OTP. >> diff --git a/board/st/common/cmd_stboard.c b/board/st/common/cmd_stboard.c >> index 853ab78bbf16..cb103e69b369 100644 >> --- a/board/st/common/cmd_stboard.c >> +++ b/board/st/common/cmd_stboard.c >> @@ -49,7 +49,9 @@ static bool check_stboard(u16 board) >> 0x1298, >> 0x1341, >> 0x1497, >> + 0x1605, /* stm32mp25xx-dk */ >> 0x1635, >> + 0x1936, /* stm32mp25xx-ev1 */ >> }; >> >> for (i = 0; i < ARRAY_SIZE(st_board_id); i++)