From: bugtrack@alsa-project.org Subject: [ALSA - utils 0000318]: alsaconf: -bash: syntax error in conditional expression Date: Wed, 19 Jan 2005 16:44:25 +0100 Message-ID: <80f2f2f6507651fd9d3439cbdfc1396e@bugtrack.alsa-project.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bugtrack.alsa-project.org (gate.perex.cz [82.113.61.162]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id 8AB9626D for ; Wed, 19 Jan 2005 16:44:25 +0100 (MET) Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org A NOTE has been added to this issue. ====================================================================== ====================================================================== Reported By: Toralf Förster Assigned To: ====================================================================== Project: ALSA - utils Issue ID: 318 Category: alsaconf Reproducibility: always Severity: minor Priority: normal Status: new ====================================================================== Date Submitted: 05-31-2004 12:25 CEST Last Modified: 01-19-2005 16:44 CET ====================================================================== Summary: alsaconf: -bash: syntax error in conditional expression Description: The error above results from lines like: elif [ -f /etc/redhat-release -a `grep -c "Red Hat" /etc/redhat-release 2>/dev/null` -ne 0 ]; then instead it should be elif [[ -f /etc/redhat-release && `grep -c "Red Hat" /etc/redhat-release 2>/dev/null` -ne 0 ]; then notice the doubled '[[' and ']]' and '&&' instead of '-a', isn't it ? ====================================================================== ---------------------------------------------------------------------- jdthood - 01-19-05 15:36 ---------------------------------------------------------------------- You don't have to use double brackets. < elif [ -f /etc/redhat-release -a `grep -c "Red Hat" /etc/redhat-release 2>/dev/null` -ne 0 ]; then > elif [ -f /etc/redhat-release ] && [ "$(grep -c "Red Hat" /etc/redhat-release 2>/dev/null)" -ne "0" ]; then ---------------------------------------------------------------------- tiwai - 01-19-05 16:44 ---------------------------------------------------------------------- Even the second [] isn't necessary when you use grep -q. Issue History Date Modified Username Field Change ====================================================================== 05-31-04 12:25 Toralf Förster New Issue 01-19-05 15:36 jdthood Note Added: 0003288 01-19-05 16:44 tiwai Note Added: 0003292 ====================================================================== ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt