From: Felix Kuehling Subject: Re: [PATCH v2] drm/amdgpu: Fix KFD oversubscription by tracking queues correctly Date: Thu, 13 Jul 2017 17:16:24 -0400 Message-ID: <80fddf59-42ec-2ab2-e690-17316469008d@amd.com> References: <1499977419-19065-1-git-send-email-Jay.Cornwall@amd.com> <65ff9929-33db-2691-78c5-0924ec7bcf3a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <65ff9929-33db-2691-78c5-0924ec7bcf3a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-CA List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org UGVvcGxlIGRvbid0IHNlZW0gdG8gbGlrZSBjcm9zcy1jb21wb25lbnQgY2hhbmdlcyBpZiB0aGV5 IGNhbiBiZQphdm9pZGVkLiBJJ2QgcHJlZmVyIHNlcGFyYXRlIGNvbW1pdHMgZm9yIEtGRCwgcmFk ZW9uLCBhbWRncHUsIGFuZApmaW5hbGx5IHRoZSBrZ2Qya2ZkIGludGVyZmFjZS4KCldpdGggdGhh dCBmaXhlZCwgUmV2aWV3ZWQtYnk6IEZlbGl4IEt1ZWhsaW5nIDxGZWxpeC5LdWVobGluZ0BhbWQu Y29tPgoKT24gMTctMDctMTMgMDQ6MzYgUE0sIEFuZHJlcyBSb2RyaWd1ZXogd3JvdGU6Cj4KPiBS ZXZpZXdlZC1ieTogQW5kcmVzIFJvZHJpZ3VleiA8YW5kcmVzeDdAZ21haWwuY29tPgo+Cj4gT24g MjAxNy0wNy0xMyAwNDoyMyBQTSwgSmF5IENvcm53YWxsIHdyb3RlOgo+PiBUaGUgbnVtYmVyIG9m IGNvbXB1dGUgcXVldWVzIGF2YWlsYWJsZSB0byB0aGUgS0ZEIHdhcyBlcnJvbmVvdXNseQo+PiBj YWxjdWxhdGVkIGFzIDY0LiBPbmx5IHRoZSBmaXJzdCBNRUMgY2FuIGV4ZWN1dGUgY29tcHV0ZSBx dWV1ZXMgYW5kCj4+IGl0IGhhcyAzMiBxdWV1ZSBzbG90cy4KPj4KPj4gVGhpcyBjYXVzZWQgdGhl IG92ZXJzdWJzY3JpcHRpb24gbGltaXQgdG8gYmUgY2FsY3VsYXRlZCBpbmNvcnJlY3RseSwKPj4g bGVhZGluZyB0byBhIG1pc3NpbmcgY2hhaW5lZCBydW5saXN0IGNvbW1hbmQgYXQgdGhlIGVuZCBv ZiBhbgo+PiBvdmVyc3Vic2NyaWJlZCBydW5saXN0Lgo+Pgo+PiB2MjogUmVtb3ZlIHVudXNlZCBu dW1fbWVjIGZpZWxkIHRvIGF2b2lkIGR1cGxpY2F0ZSBsb2dpYwo+Pgo+PiBDaGFuZ2UtSWQ6IElj NGExMzljMDRiOGE2ZDAyNWZiYjgzMWEwYTY3ZTk4NzI4YmZlNDYxCj4+IFNpZ25lZC1vZmYtYnk6 IEpheSBDb3Jud2FsbCA8SmF5LkNvcm53YWxsQGFtZC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmQuYyAgICAgICAgICAgIHwgMyArLS0KPj4g ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZGV2aWNlLmMgICAgICAgICAgICAgICB8 IDQgLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVf bWFuYWdlci5jIHwgNyAtLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9pbmNsdWRlL2tn ZF9rZmRfaW50ZXJmYWNlLmggICAgICAgfCAzIC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9yYWRl b24vcmFkZW9uX2tmZC5jICAgICAgICAgICAgICAgICAgIHwgMSAtCj4+ICAgNSBmaWxlcyBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMTcgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkLmMKPj4gYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYW1ka2ZkLmMKPj4gaW5kZXggNzA2MGRhZi4uOGM3MTBm NyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2FtZGtm ZC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmQuYwo+ PiBAQCAtMTE2LDcgKzExNiw2IEBAIHZvaWQgYW1kZ3B1X2FtZGtmZF9kZXZpY2VfaW5pdChzdHJ1 Y3QKPj4gYW1kZ3B1X2RldmljZSAqYWRldikKPj4gICAgICAgaWYgKGFkZXYtPmtmZCkgewo+PiAg ICAgICAgICAgc3RydWN0IGtnZDJrZmRfc2hhcmVkX3Jlc291cmNlcyBncHVfcmVzb3VyY2VzID0g ewo+PiAgICAgICAgICAgICAgIC5jb21wdXRlX3ZtaWRfYml0bWFwID0gZ2xvYmFsX2NvbXB1dGVf dm1pZF9iaXRtYXAsCj4+IC0gICAgICAgICAgICAubnVtX21lYyA9IGFkZXYtPmdmeC5tZWMubnVt X21lYywKPj4gICAgICAgICAgICAgICAubnVtX3BpcGVfcGVyX21lYyA9IGFkZXYtPmdmeC5tZWMu bnVtX3BpcGVfcGVyX21lYywKPj4gICAgICAgICAgICAgICAubnVtX3F1ZXVlX3Blcl9waXBlID0g YWRldi0+Z2Z4Lm1lYy5udW1fcXVldWVfcGVyX3BpcGUsCj4+ICAgICAgICAgICAgICAgLmdwdXZt X3NpemUgPSAodWludDY0X3QpYW1kZ3B1X3ZtX3NpemUgPDwgMzAKPj4gQEAgLTE0MCw3ICsxMzks NyBAQCB2b2lkIGFtZGdwdV9hbWRrZmRfZGV2aWNlX2luaXQoc3RydWN0Cj4+IGFtZGdwdV9kZXZp Y2UgKmFkZXYpCj4+ICAgICAgICAgICAvKiBBY2NvcmRpbmcgdG8gbGludXgvYml0bWFwLmggd2Ug c2hvdWxkbid0IHVzZQo+PiBiaXRtYXBfY2xlYXIgaWYKPj4gICAgICAgICAgICAqIG5iaXRzIGlz IG5vdCBjb21waWxlIHRpbWUgY29uc3RhbnQKPj4gICAgICAgICAgICAqLwo+PiAtICAgICAgICBs YXN0X3ZhbGlkX2JpdCA9IGFkZXYtPmdmeC5tZWMubnVtX21lYwo+PiArICAgICAgICBsYXN0X3Zh bGlkX2JpdCA9IDEgLyogb25seSBmaXJzdCBNRUMgY2FuIGhhdmUgY29tcHV0ZSBxdWV1ZXMgKi8K Pj4gICAgICAgICAgICAgICAgICAgKiBhZGV2LT5nZngubWVjLm51bV9waXBlX3Blcl9tZWMKPj4g ICAgICAgICAgICAgICAgICAgKiBhZGV2LT5nZngubWVjLm51bV9xdWV1ZV9wZXJfcGlwZTsKPj4g ICAgICAgICAgIGZvciAoaSA9IGxhc3RfdmFsaWRfYml0OyBpIDwgS0dEX01BWF9RVUVVRVM7ICsr aSkKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2Uu Ywo+PiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2UuYwo+PiBpbmRleCAx Y2YwMGQ0Li45NWY5Mzk2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtm ZC9rZmRfZGV2aWNlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2Rl dmljZS5jCj4+IEBAIC00OTQsMTAgKzQ5NCw2IEBAIGJvb2wga2dkMmtmZF9kZXZpY2VfaW5pdChz dHJ1Y3Qga2ZkX2RldiAqa2ZkLAo+PiAgICAgICB9IGVsc2UKPj4gICAgICAgICAgIGtmZC0+bWF4 X3Byb2NfcGVyX3F1YW50dW0gPSBod3NfbWF4X2NvbmNfcHJvYzsKPj4gICAtICAgIC8qIFdlIG9u bHkgdXNlIHRoZSBmaXJzdCBNRUMgKi8KPj4gLSAgICBpZiAoa2ZkLT5zaGFyZWRfcmVzb3VyY2Vz Lm51bV9tZWMgPiAxKQo+PiAtICAgICAgICBrZmQtPnNoYXJlZF9yZXNvdXJjZXMubnVtX21lYyA9 IDE7Cj4+IC0KPj4gICAgICAgLyogY2FsY3VsYXRlIG1heCBzaXplIG9mIG1xZHMgbmVlZGVkIGZv ciBxdWV1ZXMgKi8KPj4gICAgICAgc2l6ZSA9IG1heF9udW1fb2ZfcXVldWVzX3Blcl9kZXZpY2Ug Kgo+PiAgICAgICAgICAgICAgIGtmZC0+ZGV2aWNlX2luZm8tPm1xZF9zaXplX2FsaWduZWQ7Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZGV2aWNlX3F1ZXVl X21hbmFnZXIuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVl dWVfbWFuYWdlci5jCj4+IGluZGV4IDc2MDc5ODkuLjMwNjE0NGYgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVfbWFuYWdlci5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVfbWFuYWdlci5j Cj4+IEBAIC04MiwxMyArODIsNiBAQCBzdGF0aWMgYm9vbCBpc19waXBlX2VuYWJsZWQoc3RydWN0 Cj4+IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sIGludCBtZWMsIGludCBwaXBlKQo+PiAgICAg ICByZXR1cm4gZmFsc2U7Cj4+ICAgfQo+PiAgIC11bnNpZ25lZCBpbnQgZ2V0X21lY19udW0oc3Ry dWN0IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0pCj4+IC17Cj4+IC0gICAgQlVHX09OKCFkcW0g fHwgIWRxbS0+ZGV2KTsKPj4gLQo+PiAtICAgIHJldHVybiBkcW0tPmRldi0+c2hhcmVkX3Jlc291 cmNlcy5udW1fbWVjOwo+PiAtfQo+PiAtCj4+ICAgdW5zaWduZWQgaW50IGdldF9xdWV1ZXNfbnVt KHN0cnVjdCBkZXZpY2VfcXVldWVfbWFuYWdlciAqZHFtKQo+PiAgIHsKPj4gICAgICAgQlVHX09O KCFkcW0gfHwgIWRxbS0+ZGV2KTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv aW5jbHVkZS9rZ2Rfa2ZkX2ludGVyZmFjZS5oCj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9pbmNs dWRlL2tnZF9rZmRfaW50ZXJmYWNlLmgKPj4gaW5kZXggYTRkMmZlZS4uMTA3OTRiMyAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9pbmNsdWRlL2tnZF9rZmRfaW50ZXJmYWNlLmgK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9pbmNsdWRlL2tnZF9rZmRfaW50ZXJmYWNlLmgK Pj4gQEAgLTEwNyw5ICsxMDcsNiBAQCBzdHJ1Y3Qga2dkMmtmZF9zaGFyZWRfcmVzb3VyY2VzIHsK Pj4gICAgICAgLyogQml0IG4gPT0gMSBtZWFucyBWTUlEIG4gaXMgYXZhaWxhYmxlIGZvciBLRkQu ICovCj4+ICAgICAgIHVuc2lnbmVkIGludCBjb21wdXRlX3ZtaWRfYml0bWFwOwo+PiAgIC0gICAg LyogbnVtYmVyIG9mIG1lYyBhdmFpbGFibGUgZnJvbSB0aGUgaGFyZHdhcmUgKi8KPj4gLSAgICB1 aW50MzJfdCBudW1fbWVjOwo+PiAtCj4+ICAgICAgIC8qIG51bWJlciBvZiBwaXBlcyBwZXIgbWVj ICovCj4+ICAgICAgIHVpbnQzMl90IG51bV9waXBlX3Blcl9tZWM7Cj4+ICAgZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2tmZC5jCj4+IGIvZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9yYWRlb25fa2ZkLmMKPj4gaW5kZXggNzE5ZWE1MS4uOGY4YzdjMSAxMDA2NDQKPj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fa2ZkLmMKPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fa2ZkLmMKPj4gQEAgLTI1MSw3ICsyNTEsNiBAQCB2b2lk IHJhZGVvbl9rZmRfZGV2aWNlX2luaXQoc3RydWN0IHJhZGVvbl9kZXZpY2UKPj4gKnJkZXYpCj4+ ICAgICAgIGlmIChyZGV2LT5rZmQpIHsKPj4gICAgICAgICAgIHN0cnVjdCBrZ2Qya2ZkX3NoYXJl ZF9yZXNvdXJjZXMgZ3B1X3Jlc291cmNlcyA9IHsKPj4gICAgICAgICAgICAgICAuY29tcHV0ZV92 bWlkX2JpdG1hcCA9IDB4RkYwMCwKPj4gLSAgICAgICAgICAgIC5udW1fbWVjID0gMSwKPj4gICAg ICAgICAgICAgICAubnVtX3BpcGVfcGVyX21lYyA9IDQsCj4+ICAgICAgICAgICAgICAgLm51bV9x dWV1ZV9wZXJfcGlwZSA9IDgsCj4+ICAgICAgICAgICAgICAgLmdwdXZtX3NpemUgPSAodWludDY0 X3QpcmFkZW9uX3ZtX3NpemUgPDwgMzAKPj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm eAo=