Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BB79C04A68 for ; Wed, 27 Jul 2022 07:24:25 +0000 (UTC) Received: from localhost ([::1]:42004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGbP6-0005tV-6z for qemu-devel@archiver.kernel.org; Wed, 27 Jul 2022 03:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGb76-0007sg-TZ for qemu-devel@nongnu.org; Wed, 27 Jul 2022 03:05:49 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:49126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGb6i-00060Q-T3 for qemu-devel@nongnu.org; Wed, 27 Jul 2022 03:05:41 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R541e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046049; MF=kangjie.xu@linux.alibaba.com; NM=1; PH=DS; RN=5; SR=0; TI=SMTPD_---0VKZsOAy_1658905515; Received: from 30.227.68.147(mailfrom:kangjie.xu@linux.alibaba.com fp:SMTPD_---0VKZsOAy_1658905515) by smtp.aliyun-inc.com; Wed, 27 Jul 2022 15:05:15 +0800 Message-ID: <810e4f2c-69bb-e2be-1faf-056549063fae@linux.alibaba.com> Date: Wed, 27 Jul 2022 15:05:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 08/16] vhost: add op to enable or disable a single vring To: Jason Wang References: <8bf7574d8e133d3fa7e8b09f4deb59369916774a.1658141552.git.kangjie.xu@linux.alibaba.com> <93985df7-7d5f-782e-10ed-7494f0806d22@linux.alibaba.com> From: Kangjie Xu Cc: qemu-devel@nongnu.org, hengqi@linux.alibaba.com, xuanzhuo@linux.alibaba.com, mst@redhat.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=115.124.30.133; envelope-from=kangjie.xu@linux.alibaba.com; helo=out30-133.freemail.mail.aliyun.com X-Spam_score_int: -98 X-Spam_score: -9.9 X-Spam_bar: --------- X-Spam_report: (-9.9 / 5.0 requ) BAYES_00=-1.9, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/7/27 12:55, Jason Wang 写道: > On Tue, Jul 26, 2022 at 2:39 PM Kangjie Xu wrote: >> >> 在 2022/7/26 11:49, Jason Wang 写道: >>> 在 2022/7/18 19:17, Kangjie Xu 写道: >>>> The interface to set enable status for a single vring is lacked in >>>> VhostOps, since the vhost_set_vring_enable_op will manipulate all >>>> virtqueues in a device. >>>> >>>> Resetting a single vq will rely on this interface. It requires a >>>> reply to indicate that the reset operation is finished, so the >>>> parameter, wait_for_reply, is added. >>> >>> The wait reply seems to be a implementation specific thing. Can we >>> hide it? >>> >>> Thanks >>> >> I do not hide wait_for_reply here because when stopping the queue, a >> reply is needed to ensure that the message has been processed and queue >> has been disabled. > This needs to be done at vhost-backend level instead of the general vhost code. > > E.g vhost-kernel or vDPA is using ioctl() which is synchronous. Yeah, I understand your concerns, will fix it in the next version. >> When restarting the queue, we do not need a reply, which is the same as >> what qemu does in vhost_dev_start(). >> >> So I add this parameter to distinguish the two cases. >> >> I think one alternative implementation is to add a interface in >> VhostOps: queue_reset(). In this way details can be hidden. What do you >> think of this solution? Does it look better? > Let me ask it differently, under which case can we call this function > with wait_for_reply = false? > > Thanks Cases when we do not need to wait until that the reply has been processed. Actually in dev_start(), or dev_stop(), they do not wait for replies when enabling/disabling vqs. Specifically, vhost_set_vring_enable() will call it with wait_for_reply = false. In our vq reset scenario, it should be synchronous because the driver need to modify queues after the device stop using the vq in the backend. Undefined errors will occur If the device is still using the queue when the driver is making modifications to it, Back to our implementation, we will not expose this parameter in the next version. Thanks. >> Thanks >> >>>> Signed-off-by: Kangjie Xu >>>> Signed-off-by: Xuan Zhuo >>>> --- >>>> include/hw/virtio/vhost-backend.h | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/include/hw/virtio/vhost-backend.h >>>> b/include/hw/virtio/vhost-backend.h >>>> index eab46d7f0b..7bddd1e9a0 100644 >>>> --- a/include/hw/virtio/vhost-backend.h >>>> +++ b/include/hw/virtio/vhost-backend.h >>>> @@ -81,6 +81,9 @@ typedef int (*vhost_set_backend_cap_op)(struct >>>> vhost_dev *dev); >>>> typedef int (*vhost_set_owner_op)(struct vhost_dev *dev); >>>> typedef int (*vhost_reset_device_op)(struct vhost_dev *dev); >>>> typedef int (*vhost_get_vq_index_op)(struct vhost_dev *dev, int idx); >>>> +typedef int (*vhost_set_single_vring_enable_op)(struct vhost_dev *dev, >>>> + int index, int enable, >>>> + bool wait_for_reply); >>>> typedef int (*vhost_set_vring_enable_op)(struct vhost_dev *dev, >>>> int enable); >>>> typedef bool (*vhost_requires_shm_log_op)(struct vhost_dev *dev); >>>> @@ -155,6 +158,7 @@ typedef struct VhostOps { >>>> vhost_set_owner_op vhost_set_owner; >>>> vhost_reset_device_op vhost_reset_device; >>>> vhost_get_vq_index_op vhost_get_vq_index; >>>> + vhost_set_single_vring_enable_op vhost_set_single_vring_enable; >>>> vhost_set_vring_enable_op vhost_set_vring_enable; >>>> vhost_requires_shm_log_op vhost_requires_shm_log; >>>> vhost_migration_done_op vhost_migration_done;