From: axie Subject: Re: [PATCH 1/4] drm/amdgpu: Optimization of critical section Date: Tue, 13 Jun 2017 02:29:17 -0400 Message-ID: <815cfedc-8eb8-37aa-e9f5-5882e9a5c950@amd.com> References: <1497299485-7337-1-git-send-email-AlexBin.Xie@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Alex Xie , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMjAxNy0wNi0xMiAwNzowMCBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBbSAxMi4w Ni4yMDE3IHVtIDIyOjMxIHNjaHJpZWIgQWxleCBYaWU6Cj4+IFRoaXMgcGF0Y2ggaXMgdG8gbW92 ZSBhIGxvb3Agb2YgdW5yZWYgQk9zIGFuZAo+PiBzZXZlcmFsIG1lbW9yeSBmcmVlIGZ1bmN0aW9u IGNhbGxzIG91dCBvZgo+PiBjcml0aWNhbCBzZWN0aW9ucy4KPj4KPj4gU2lnbmVkLW9mZi1ieTog QWxleCBYaWUgPEFsZXhCaW4uWGllQGFtZC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9ib19saXN0LmMgfCA1ICsrKystCj4+ICAgMSBmaWxlIGNoYW5n ZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2JvX2xpc3QuYyAKPj4gYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYm9fbGlzdC5jCj4+IGluZGV4IGE2NjQ5ODcuLjAyYzEz OGYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9ib19s aXN0LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2JvX2xpc3Qu Ywo+PiBAQCAtNzUsOSArNzUsMTIgQEAgc3RhdGljIHZvaWQgYW1kZ3B1X2JvX2xpc3RfZGVzdHJv eShzdHJ1Y3QgCj4+IGFtZGdwdV9mcHJpdiAqZnByaXYsIGludCBpZCkKPj4gICAgICAgICAgIC8q IEFub3RoZXIgdXNlciBtYXkgaGF2ZSBhIHJlZmVyZW5jZSB0byB0aGlzIGxpc3Qgc3RpbGwgKi8K Pj4gICAgICAgICAgIG11dGV4X2xvY2soJmxpc3QtPmxvY2spOwo+PiAgICAgICAgICAgbXV0ZXhf dW5sb2NrKCZsaXN0LT5sb2NrKTsKPj4gKyAgICAgICAgbXV0ZXhfdW5sb2NrKCZmcHJpdi0+Ym9f bGlzdF9sb2NrKTsKPj4gICAgICAgICAgIGFtZGdwdV9ib19saXN0X2ZyZWUobGlzdCk7Cj4+ICAg ICAgIH0KPj4gLSAgICBtdXRleF91bmxvY2soJmZwcml2LT5ib19saXN0X2xvY2spOwo+PiArICAg IGVsc2Ugewo+PiArICAgICAgICBtdXRleF91bmxvY2soJmZwcml2LT5ib19saXN0X2xvY2spOwo+ PiArICAgIH0KPgo+IFlvdSBjb3VsZCBtb3ZlIHRoZSB1bmxvY2sgb2YgYm9fbGlzdF9sb2NrIGV2 ZW4gYmVmb3JlIHRoZSBpZi4KPgo+IEJ1dCBzaW5jZSB5b3UgcG9pbnRlZCBpdCBvdXQgdGhlcmUg aXMgcXVpdGUgYSBidWcgaW4gdGhpcyBmdW5jdGlvbjoKPj4gICAgICAgICAgICAgICAgIC8qIEFu b3RoZXIgdXNlciBtYXkgaGF2ZSBhIHJlZmVyZW5jZSB0byB0aGlzIGxpc3QgCj4+IHN0aWxsICov Cj4+ICAgICAgICAgICAgICAgICBtdXRleF9sb2NrKCZsaXN0LT5sb2NrKTsKPj4gICAgICAgICAg ICAgICAgIG11dGV4X3VubG9jaygmbGlzdC0+bG9jayk7Cj4gTm90IHN1cmUgaWYgdGhhdCBpcyBz dGlsbCB1cCB0byBkYXRlLCBidXQgdGhhdCB1c2UgY2FzZSB1c2VkIHRvIGJlIAo+IGlsbGVnYWwg d2l0aCBtdXRleGVzLgpBcyBJIHVuZGVyc3RhbmQgdGhpcyBwaWVjZSBvZiBjb2RlLCB0aGVzZSBt dXRleF9sb2NrIGFuZCBtdXRleF91bmxvY2sgCnBhaXIgYXJlIHVzZWQgdG8gbWFrZSBzdXJlIGFs bCBvdGhlciB0YXNrcyBoYXZlIGZpbmlzaGVkCmFjY2VzcyBvZiB0aGUgYm8gbGlzdC4gQW5vdGhl ciBzaWRlIG9mIHRoaXMgc3RvcnkgaXMgaW4gZnVuY3Rpb24gCmFtZGdwdV9ib19saXN0X2dldC4g VGhlc2UgdHdvIHBpZWNlIG9mIGNvZGVzIHRvZ2V0aGVyIG1ha2Ugc3VyZQp3ZSBjYW4gc2FmZWx5 IGRlc3Ryb3kgYm8gbGlzdC4KCk90aGVyd2lzZSB3ZSBjYW4gZWFzaWx5IHNpbXBsaWZ5IHRoZXNl IGxvY2tpbmdzLgpMZXQgbWUgZ2l2ZSBhbiBleGFtcGxlIGhlcmUuCgpJbiBmdW5jdGlvbiBhbWRn cHVfYm9fbGlzdF9nZXQsIGFzc3VtaW5nIHdlIGNoYW5nZSB0aGUgY29kZSBsaWtlIHRoaXM6Ci4u LgogICAgIGRvd25fcmVhZCgmZnByaXYtPmJvX2xpc3RfbG9jayk7CiAgICAgcmVzdWx0ID0gaWRy X2ZpbmQoJmZwcml2LT5ib19saXN0X2hhbmRsZXMsIGlkKTsKICAgICB1cF9yZWFkKCZmcHJpdi0+ Ym9fbGlzdF9sb2NrKTsKICAgICAvKipMaW5lIDEuIFRhc2sgQSB3YXMgc2NoZWR1bGVkIGF3YXkg ZnJvbSBDUFUqKi8KICAgICBpZiAocmVzdWx0KQogICAgICAgICBtdXRleF9sb2NrKCZyZXN1bHQt PmxvY2spOwouLi4KCkluIGZ1bmN0aW9uIGFtZGdwdV9ib19saXN0X2Rlc3Ryb3ksIGFzc3VtaW5n IHdlIGNoYW5nZSB0aGUgY29kZSBsaWtlIHRoaXM6Ci4uLgogICAgIGRvd25fd3JpdGUoJmZwcml2 LT5ib19saXN0X2xvY2spOwogICAgIGxpc3QgPSBpZHJfcmVtb3ZlKCZmcHJpdi0+Ym9fbGlzdF9o YW5kbGVzLCBpZCk7CiAgICAgdXBfd3JpdGUoJmZwcml2LT5ib19saXN0X2xvY2spOwogICAgIGlm IChsaXN0KSB7CiAgICAgICAgIC8qIEFub3RoZXIgdXNlciBtYXkgaGF2ZSBhIHJlZmVyZW5jZSB0 byB0aGlzIGxpc3Qgc3RpbGwgKi8KICAgICAgICAgbXV0ZXhfbG9jaygmbGlzdC0+bG9jayk7CiAg ICAgICAgIG11dGV4X3VubG9jaygmbGlzdC0+bG9jayk7CiAgICAgICAgIGFtZGdwdV9ib19saXN0 X2ZyZWUobGlzdCk7CiAgICAgfQp9CgpXaGVuIHRhc2sgQSBpcyBydW5uaW5nIGluIGZ1bmN0aW9u IGFtZGdwdV9ib19saXN0X2dldCBpbiBsaW5lIDEsIENQVSAKc2NoZWR1bGVyIHRha2VzIENQVSBh d2F5IGZyb20gdGFzayBBLgpUaGVuIFRhc2sgQiBydW4gZnVuY3Rpb24gYW1kZ3B1X2JvX2xpc3Rf ZGVzdHJveS4gVGFzayBCIGNhbiBydW4gYWxsIHRoZSAKd2F5IHRvIGRlc3Ryb3kgYW5kIGZyZWUg bXV0ZXguCkxhdGVyIFRhc2sgQSBpcyBiYWNrIHRvIHJ1bi4gVGhlIG11dGV4IHJlc3VsdC0+bG9j ayBoYXMgYmVlbiBkZXN0cm95ZWQgCmJ5IHRhc2sgQi4gTm93IHRhc2sgQSB0cnkgdG8gbG9jayBh IG11dGV4CndoaWNoIGhhcyBiZWVuIGRlc3Ryb3llZCBhbmQgZnJlZWQuCgoKPgo+IENocmlzdGlh bi4KPgo+PiAgIH0KPj4gICAgIHN0YXRpYyBpbnQgYW1kZ3B1X2JvX2xpc3Rfc2V0KHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2LAo+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v YW1kLWdmeAo=