From: Dmitry Osipenko Subject: Re: [PATCH v4 3/6] partitions: Introduce NVIDIA Tegra Partition Table Date: Fri, 15 May 2020 05:02:40 +0300 Message-ID: <821ae388-07b2-5883-95b8-c551ddc7bdea@gmail.com> References: <20200515014143.12984-1-digetx@gmail.com> <20200515014143.12984-4-digetx@gmail.com> <055fc187-6181-6ccb-04a8-ab4324270ed7@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <055fc187-6181-6ccb-04a8-ab4324270ed7@infradead.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap , Jens Axboe , Thierry Reding , Jonathan Hunter , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , David Heidelberg , Peter Geis , Stephen Warren , Nicolas Chauvet , Ulf Hansson , Adrian Hunter , Billy Laws , =?UTF-8?Q?Nils_=c3=96stlund?= , Christoph Hellwig , Ard Biesheuvel , Davidlohr Bueso Cc: linux-tegra@vger.kernel.org, linux-block@vger.kernel.org, Andrey Danin , Gilles Grandou , Ryan Grachek , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi List-Id: linux-tegra@vger.kernel.org 15.05.2020 04:58, Randy Dunlap пишет: > On 5/14/20 6:41 PM, Dmitry Osipenko wrote: >> diff --git a/block/partitions/Kconfig b/block/partitions/Kconfig >> index 702689a628f0..2c1408cba1a6 100644 >> --- a/block/partitions/Kconfig >> +++ b/block/partitions/Kconfig >> @@ -268,3 +268,11 @@ config CMDLINE_PARTITION >> help >> Say Y here if you want to read the partition table from bootargs. >> The format for the command line is just like mtdparts. >> + >> +config TEGRA_PARTITION >> + bool "NVIDIA Tegra Partition support" if PARTITION_ADVANCED >> + default y if ARCH_TEGRA >> + depends on (ARCH_TEGRA && MMC_BLOCK) || COMPILE_TEST > > That looks odd. Such depends are more often like: > depends on MMC_BLOCK && (ARCH_TEGRA || COMPILE_TEST) > > but that's just my experience. If this works when ARCH_TEGRA and MMC_BLOCK > are not set and COMPILE_TEST is set, that's fine. Ah, right! It shouldn't work since mmc_bdev_to_card() will be undefined if MMC_BLOCK=n. Good catch, thank you! :)