Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D74C47255 for ; Mon, 11 May 2020 23:19:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF08E2070B for ; Mon, 11 May 2020 23:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZHvnmFQQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgEKXTY (ORCPT ); Mon, 11 May 2020 19:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725854AbgEKXTX (ORCPT ); Mon, 11 May 2020 19:19:23 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 989FEC061A0C for ; Mon, 11 May 2020 16:19:23 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id q24so8492088pjd.1 for ; Mon, 11 May 2020 16:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=S29KATHTxUWmSA7tfWs0BRVRkQ8uFZd0Fn2wGoLHaqk=; b=ZHvnmFQQCBHZu+zLbb0YdXZMfgdtr3mpME0J56J3a4pcm0J2ThTizdvKCwqjZXqEHp 8B595dxDuLz+zCp7B1htU6PCiyWtF63YnQRnswKHxRZj5FeRwy+DzhpYY094kam02mwl 4Evwrp4YkgLo/xa0RX2zZqpeQ3lL2pE81PXcnaZ3A7hUnN9eSEQJgT/Gx3Rck48RhPoY e7ooE3ylgNTQA9QIh9sHiI3A+NKylDqQQvafLVRiFcfUruAegSVyA83v1jhKnYUaxWHF L17UtlU1f1lVNRFDBe0fh63YMz1zCOe9kI10EpJu0t3u1q+OqKCiNvAFpfMV/u2m374P tg5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S29KATHTxUWmSA7tfWs0BRVRkQ8uFZd0Fn2wGoLHaqk=; b=DmT+BtB6ox5oDX8/9vgmWuVNfMjfk9dGl/nRFbMGX5sr4D35saxqJtQSrJPWKtJlbo bfBk7h1lJ5RCinvnBL+4NxDO0sKquTuoQ8NjLUPBIQ+cEGkF+V7P4YwToy2CylWOoBCC eOd98tukYY673qpbtGadpiQrIu7ak4pjxbOv2WGUjrHQO77UD7ij5nlCFWHTJNE86tlP 6dozrPjBydnCjYuvjw9QEXlpmik2o+gjA3W/yBhxQLr2HtxAzBZNXpIChM9R7FYm5Msu UGDt2V162aqvxyb8Q/O1MRt814hP/SsCLwA8MMByU6f2zlj7JxWQVozpS5DTVpELTVe3 2mKQ== X-Gm-Message-State: AGi0PuZ3DBMlZDpiYNMkT0mtrB6x+INpWfo/mSYck0/QSFe0r25LQGCB 6WYJp/vcEt37kG0gbMrW4VCLJHzv X-Google-Smtp-Source: APiQypIsDN0Q0l7lyJks1Zuo8NP7VfRFP0NeOaUm3PdykVyH0dRhO3eJf4/iT2YeiwEgqylO/XRWcg== X-Received: by 2002:a17:90a:f2ca:: with SMTP id gt10mr26307599pjb.160.1589239162656; Mon, 11 May 2020 16:19:22 -0700 (PDT) Received: from [10.230.188.43] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id q16sm127434pgm.91.2020.05.11.16.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 16:19:21 -0700 (PDT) Subject: Re: [PATCH net-next 1/4] net: dsa: allow drivers to request promiscuous mode on master To: Vladimir Oltean , andrew@lunn.ch, vivien.didelot@gmail.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org References: <20200511202046.20515-1-olteanv@gmail.com> <20200511202046.20515-2-olteanv@gmail.com> From: Florian Fainelli Message-ID: <8246ccc4-6ddf-be3c-6391-9a6a75e6c8a8@gmail.com> Date: Mon, 11 May 2020 16:19:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200511202046.20515-2-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 5/11/2020 1:20 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently DSA assumes that taggers don't mess with the destination MAC > address of the frames on RX. That is not always the case. Some DSA > headers are placed before the Ethernet header (ocelot), and others > simply mangle random bytes from the destination MAC address (sja1105 > with its incl_srcpt option). > > Currently the DSA master goes to promiscuous mode automatically when the > slave devices go too (such as when enslaved to a bridge), but in > standalone mode this is a problem that needs to be dealt with. > > So give drivers the possibility to signal that their tagging protocol > will get randomly dropped otherwise, and let DSA deal with fixing that. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian