From: "flichtenheld (Code Review)" Date: Wed, 1 Apr 2026 10:24:45 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <8270503395f6523d513b2956daa33cc825c31afc-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="WLpFqrOTgXM="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --WLpFqrOTgXM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1587?usp=3Demail ) Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certifica= te usage ...................................................................... Patch Set 3: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1587/comment/a6196a88_86a2feb6?usp=3D= email : PS3, Line 13: The bit counting in ANS.1 and of this method is a bit strange= and ASN File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1587/comment/8acc94f5_568890ee?usp=3D= email : PS3, Line 621: * case when its distribution will update to OpenSSL= 1.1 This comments seems very obsolete? Apparently even newest OpenSSL allows us= to make this check? The actual warning is probably fine since it just says= "future", but the comment could clearly use some update? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Gerrit-Change-Number: 1587 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 01 Apr 2026 10:24:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --WLpFqrOTgXM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

Patch set 3:Code-Review -1=

V= iew Change

2 comments:

  • Commit Message:

    • Patch Set #3, Line= 13: The bit counting i= n ANS.1 and of this method is a bit strange and

      ASN

    • File src/openvpn/ssl_verify_o= penssl.c:

      • Patch Set #3, Line 621: * case when its distribution will update to OpenSSL 1.1

        This comments seems very obsolete? Apparently even newest OpenSSL all= ows us to make this check? The actual warning is probably fine since it jus= t says "future", but the comment could clearly use some update?

    To view, visit change 1587. To unsubscribe, or for hel= p writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca0= 7d0285fe694f2
    Gerrit-Change-Number: 1587
    Gerrit-PatchSet: 3
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 10:24:45= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    = --WLpFqrOTgXM=--