From: "cron2 (Code Review)"
Date: Thu, 23 Jan 2025 15:54:58 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
gianmarco@...2726..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <82763c6d4a4fd9c8e305e4e612f72815147de223-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="z+g8nXueQSc="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move
generic event handling code in dedicated files
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: its_Giaan
Cc: flichtenheld , plaisthos , openvpn-devel
--z+g8nXueQSc=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/763?usp=3Demail )
Change subject: multiproto: move generic event handling code in dedicated f=
iles
......................................................................
Patch Set 12: Code-Review-1
(2 comments)
Patchset:
PS12:
much better and much easier reviewed now.
As discussed on IRC, the `multi_protocol_...()` function names are slightly=
confusing, and I suggest to use `multi_io_...()`, which is in line with th=
e `m->mtcp` to `m->m_multi_io` renaming and also the file names...
File src/openvpn/mtcp.c:
http://gerrit.openvpn.net/c/openvpn/+/763/comment/506eec5d_80c39ac0 :
PS10, Line 165: multi_tcp_context(struct multi_context *m, struct multi_ins=
tance *mi)
> made this static inline again and moved to multi_io. [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/763?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1e5a84969988e4f027a18658d4ab268c13fbf929
Gerrit-Change-Number: 763
Gerrit-PatchSet: 12
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: its_Giaan
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Thu, 23 Jan 2025 15:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: its_Giaan
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--z+g8nXueQSc=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, plaistho=
s.
Patch set 12:Code-Review -1
V=
iew Change
2 comments:
Patchset:
Patch Set #12:
much better and much easier reviewed now.=
p>
As discussed o=
n IRC, the `multi_protocol_...()` function names are slightly confusing, an=
d I suggest to use `multi_io_...()`, which is in line with the `m->mtcp`=
to `m->m_multi_io` renaming and also the file names...
File src/openvpn/mtcp.c:
Done
=
To view, visit change 763. To unsubscribe, or for help writing mail=
filters, visit settings=
.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1e5a84969988e4f027a18658d4a=
b268c13fbf929
Gerrit-Change-Number: 763
Gerrit-PatchSet: 12
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...=
726...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Thu, 23 Jan 2025 15:54:58=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: its_Giaan <gianmarco@...220...=
..2726...>
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--z+g8nXueQSc=--