Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62F0CC4345F for ; Fri, 3 May 2024 10:18:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.716344.1118465 (Exim 4.92) (envelope-from ) id 1s2pze-0007w7-PV; Fri, 03 May 2024 10:18:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 716344.1118465; Fri, 03 May 2024 10:18:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1s2pze-0007w0-Mi; Fri, 03 May 2024 10:18:18 +0000 Received: by outflank-mailman (input) for mailman id 716344; Fri, 03 May 2024 10:18:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1s2pze-0007vu-9R for xen-devel@lists.xenproject.org; Fri, 03 May 2024 10:18:18 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 746bb75d-0936-11ef-b4bb-af5377834399; Fri, 03 May 2024 12:18:15 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 587954EE0738; Fri, 3 May 2024 12:18:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 746bb75d-0936-11ef-b4bb-af5377834399 MIME-Version: 1.0 Date: Fri, 03 May 2024 12:18:15 +0200 From: Nicola Vetrini To: Jan Beulich Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Volodymyr Babchuk , Stefano Stabellini Subject: Re: [XEN PATCH v2 1/3] drivers: char: address violation of MISRA C Rule 20.7 In-Reply-To: <83741df3-b951-4351-88c1-2b7bb7b1e16e@suse.com> References: <3ae8aa13a5562440cf60e4b30f713e5b2f73c577.1714487169.git.nicola.vetrini@bugseng.com> <25f8aec2da7e963f80c12e23fc5f725a@bugseng.com> <83741df3-b951-4351-88c1-2b7bb7b1e16e@suse.com> Message-ID: <82c375da8e1144b150e73c265ae206d6@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-05-03 12:10, Jan Beulich wrote: > On 03.05.2024 09:29, Nicola Vetrini wrote: >> On 2024-05-01 21:57, Stefano Stabellini wrote: >>> On Tue, 30 Apr 2024, Nicola Vetrini wrote: >>>> MISRA C Rule 20.7 states: "Expressions resulting from the expansion >>>> of macro parameters shall be enclosed in parentheses". Therefore, >>>> some >>>> macro definitions should gain additional parentheses to ensure that >>>> all >>>> current and future users will be safe with respect to expansions >>>> that >>>> can possibly alter the semantics of the passed-in macro parameter. >>>> >>>> No functional chage. >>>> >>>> Signed-off-by: Nicola Vetrini >>> >>> Reviewed-by: Stefano Stabellini >>> >>> >>>> --- >>>> Changes in v2: >>>> - drop excess parentheses from val parameter. >>>> --- >>>> xen/drivers/char/omap-uart.c | 5 +++-- >>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/xen/drivers/char/omap-uart.c >>>> b/xen/drivers/char/omap-uart.c >>>> index 03b5b66e7acb..e0128225f927 100644 >>>> --- a/xen/drivers/char/omap-uart.c >>>> +++ b/xen/drivers/char/omap-uart.c >>>> @@ -48,8 +48,9 @@ >>>> /* System configuration register */ >>>> #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup >>>> is >>>> enabled */ >>>> >>>> -#define omap_read(uart, off) readl((uart)->regs + >>>> (off<>>> -#define omap_write(uart, off, val) writel((val), (uart)->regs + >>>> (off<>>> +#define omap_read(uart, off) readl((uart)->regs + ((off) << >>>> REG_SHIFT)) >>>> +#define omap_write(uart, off, val) writel(val, (uart)->regs + \ >>>> + ((off) << >>>> REG_SHIFT)) >>> >>> the alignment looks off but could be fixed on commit >>> >> >> Can you clarify what you mean here? I aligned readl and writeln and >> the >> operands in writel to avoid the line being too long. > > #define omap_write(uart, off, val) writel(val, \ > (uart)->regs + ((off) << > REG_SHIFT)) > > The main point being that before you start splitting an argument > following > another one on the same line, you'd move that argument to a new line. > > Jan Oh, ok. Didn't think of that. Thanks, can amend it -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)