From: "plaisthos (Code Review)" Date: Thu, 22 May 2025 13:08:05 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., max@...2606... Message-ID: <82d946ca2caca0e03dac6009921709e075bd30bf-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="wc5T0EQaDA8="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF Cc: flichtenheld , openvpn-devel --wc5T0EQaDA8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/1041?usp=3Demail ) Change subject: Use mbedtls_ssl_export_keying_material() ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: the cmake detection didn't work properly for me but we should also not use = that (see other comment) So I tested with replacing !HAVE_MBEDTLS_SSL_EXPORT_KEYING_MATERIAL defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT) in the source code to test this. I can confirm that the patch otherwise works. File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/1041/comment/93bf1992_f65e7263 : PS2, Line 305: check_symbol_exists(mbedtls_ssl_export_keying_material m= bedtls/ssl.h HAVE_MBEDTLS_SSL_EXPORT_KEYING_MATERIAL) shouldn't we rather rely on the mbed TLS configuration define MBEDTLS_SSL_K= EYING_MATERIAL_EXPORT to detect this? We have to do this cmake/configure.ac dance for the old apis since mbed TLS= doesn't have a proper define but to detect if the API is available using M= BEDTLS_SSL_KEYING_MATERIAL_EXPORT should work unless I am overlooking somet= hing. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1041?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1204bc2ff85952160a86f0b9d1caae90e5065bc4 Gerrit-Change-Number: 1041 Gerrit-PatchSet: 2 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: MaxF Gerrit-Comment-Date: Thu, 22 May 2025 13:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --wc5T0EQaDA8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: MaxF, flichtenheld.

Patch set 2:Code-Review -1=

V= iew Change

2 comments:

  • Patchset:

    • Patch Set #2:

      the cmake detection didn't work properl= y for me but we should also not use that (see other comment)

      So I tested with replaci= ng !HAVE_MBEDTLS_SSL_EXPORT_KEYING_MATERIAL
      defined(MBEDTLS_SSL_KEYING_= MATERIAL_EXPORT) in the source code to test this.

      I can confirm that the patch otherwise= works.

  • File CMak= eLists.txt:

    • Patch = Set #2, Line 305: c= heck_symbol_exists(mbedtls_ssl_export_keying_material mbedtls/ssl.h HAVE_MB= EDTLS_SSL_EXPORT_KEYING_MATERIAL)

      shouldn't we rather rely on the mbed TLS co= nfiguration define MBEDTLS_SSL_KEYING_MATERIAL_EXPORT to detect this?

      We have to do this= cmake/configure.ac dance for the old apis since mbed TLS doesn't have = a proper define but to detect if the API is available using MBEDTLS_SSL_KEY= ING_MATERIAL_EXPORT should work unless I am overlooking something.

    • =

To view, visit change 1041. To unsubscribe, or for help writi= ng mail filters, visit setti= ngs.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1204bc2ff85952160a86f0b9d1c= aae90e5065bc4
Gerrit-Change-Number: 1041
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Thu, 22 May 2025 13:08:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--wc5T0EQaDA8=--