From: "plaisthos (Code Review)" Date: Wed, 18 Jun 2025 09:12:08 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., rein.vanbaaren@...1435..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <82de1c9e35ed1b4615fedb040ae4b6d63421ebbb-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="lNuGNNUh0FM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: comododragon Cc: flichtenheld , openvpn-devel --lNuGNNUh0FM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: comododragon, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/1046?usp=3Demail ) Change subject: Added PQE to WolfSSL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You don't need to close/reopen to update your patch, you can just push the = change again. But here is the same comment that I had on the original versi= on of the patch: I feel this is the wrong approach. We are trying to avoid the NID dance. An= d it seems that wolfSSL already has a function int wolfSSL_CTX_set1_groups_list(WOLFSSL_CTX *ctx, const char *list) that has the same (better) functionality of its SSL_CTX_set1_groups_list Op= enSSL equivalent. So rather than doing this NID dance, I would prefer that = we use the proper function instead. Maybe wolfSSL upstream can also be convinced to map this to SSL_CTX_set1_gr= oups_list as well. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35 Gerrit-Change-Number: 1046 Gerrit-PatchSet: 1 Gerrit-Owner: comododragon Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: comododragon Gerrit-Comment-Date: Wed, 18 Jun 2025 09:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --lNuGNNUh0FM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: comododragon, flichtenheld.

View = Change

1 comment:

    =
  • Patchset:

    • Patch Set #1:

      You don't need to close/reopen to update you= r patch, you can just push the change again. But here is the same comment t= hat I had on the original version of the patch:

      I feel this is the wrong approach. We ar= e trying to avoid the NID dance. And it seems that wolfSSL already has a fu= nction

      int w= olfSSL_CTX_set1_groups_list(WOLFSSL_CTX *ctx, const char *list)

      that has the same (bette= r) functionality of its SSL_CTX_set1_groups_list OpenSSL equivalent. So rat= her than doing this NID dance, I would prefer that we use the proper functi= on instead.

      = Maybe wolfSSL upstream can also be convinced to map this to SSL_CTX_set1_gr= oups_list as well.

To view, visit change 1046. To uns= ubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef= 53090a6edbd35
Gerrit-Change-Number: 1046
Gerrit-PatchSet: 1
Gerrit-Owner: comododragon <rein.vanbaaren@= ...1435...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: comododragon <rein.vanbaa= ren@...1435...>
Gerrit-Comment-Date: Wed, 18 Jun 2025 09:12:08= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--lNuGNNUh0FM=--