Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89795C6FD1D for ; Thu, 30 Mar 2023 10:06:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F36728603E; Thu, 30 Mar 2023 12:06:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="wgvZTTb9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9B97886050; Thu, 30 Mar 2023 12:06:52 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D988285E33 for ; Thu, 30 Mar 2023 12:06:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=devarsht@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32UA6hEV018013; Thu, 30 Mar 2023 05:06:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680170803; bh=+Qg5XywDvZAN2JipRU8PeCLeO1fS1eYdQIqGP2ueV94=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=wgvZTTb9CcChl/lojM24xA4ASqWrnCT3SqIxuUixtyAxvC/iBDvrePS41eePsRzk7 fvd1IgHgrdq45vq4Q6+lsqoXgFj8AKRcnDIZjYxYb1+CXAJ4htTtT8t5ltSuku6SOJ htyh0JDnRL4D0CybgXqd3dOoj7vM+L8Ktm0e67fk= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32UA6hXu021983 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Mar 2023 05:06:43 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 30 Mar 2023 05:06:43 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 30 Mar 2023 05:06:43 -0500 Received: from [172.24.145.199] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32UA6e3D014376; Thu, 30 Mar 2023 05:06:41 -0500 Message-ID: <830f00f1-051f-2b25-b84d-e07cc91fe6d8@ti.com> Date: Thu, 30 Mar 2023 15:36:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 09/15] cmd: Makefile: Rule to compile bmp_cmd Content-Language: en-US To: Nikhil M Jain , , CC: , , References: <20230329120119.72886-1-n-jain1@ti.com> <20230329120119.72886-10-n-jain1@ti.com> From: Devarsh Thakkar In-Reply-To: <20230329120119.72886-10-n-jain1@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Nikhil, One more comment on this patch. On 29/03/23 17:31, Nikhil M Jain wrote: > Change rule to compile bmp_cmd when CONFIG_CMD_BMP is defined, in place > of bmp.c. > > Signed-off-by: Nikhil M Jain > --- > V4: > - No change > > V3 (patch introduced): > - Rule to compile bmp_cmd.c > > cmd/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/cmd/Makefile b/cmd/Makefile > index 36d2daf22a..c773acb1a1 100644 > --- a/cmd/Makefile > +++ b/cmd/Makefile > @@ -29,7 +29,7 @@ obj-$(CONFIG_CMD_BIND) += bind.o > obj-$(CONFIG_CMD_BINOP) += binop.o > obj-$(CONFIG_CMD_BLOBLIST) += bloblist.o > obj-$(CONFIG_CMD_BLOCK_CACHE) += blkcache.o > -obj-$(CONFIG_CMD_BMP) += bmp.o > +obj-$(CONFIG_CMD_BMP) += bmp_cmd.o > obj-$(CONFIG_CMD_BOOTCOUNT) += bootcount.o > obj-$(CONFIG_CMD_BOOTEFI) += bootefi.o > obj-$(CONFIG_CMD_BOOTMENU) += bootmenu.o > @@ -235,6 +235,7 @@ obj-$(CONFIG_$(SPL_)CMD_TLV_EEPROM) += tlv_eeprom.o > > # core command > obj-y += nvedit.o > +obj-y += read.o commit message doesnt describe above change, is it really required ? Regards Devarsh > > obj-$(CONFIG_CMD_BCM_EXT_UTILS) += broadcom/ >