From: "cron2 (Code Review)" Date: Thu, 19 Sep 2024 10:40:05 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <834cb3fdf6ce7b5c307debbc87dc4184bb6c0833-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="+bocEp9HGwc="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --+bocEp9HGwc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: Still not there - I think the code in `route.c` is much more complex than i= t needs to be. So with the new patch to `options.c`, we pass the to-be-use= d routing table ID to `add_route_to_option_list()`, so every route option a= lways(!) has a routing-table to be used (or 0). This should be sufficient. But then, we have a default table_id added in `init_route()`, a number of e= xtra flags (`RT_TABLE_DEFINED` for `r->flags`) etc., which is all not used = in the end because even without the flag, `table_id` would become 0 in `add= _route()` (by means of `r->table_id` being 0)...? So.. can we do this with half the code? Getting rid of all new DEFINEs, al= l new arguments and flags to `route_list` things, just storing the table id= in `struct route_ipv4` and `struct route_ipv6`)=3D -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 6 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Thu, 19 Sep 2024 10:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --+bocEp9HGwc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, plaisthos.

Patch set 6:Code-Review -1=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #6:

      Still not there - I think the code in `route.c= ` is much more complex than it needs to be. So with the new patch to `opti= ons.c`, we pass the to-be-used routing table ID to `add_route_to_option_lis= t()`, so every route option always(!) has a routing-table to be used (or 0)= . This should be sufficient.

      But then, we have a default table_id added in `init_route(= )`, a number of extra flags (`RT_TABLE_DEFINED` for `r->flags`) etc., wh= ich is all not used in the end because even without the flag, `table_id` wo= uld become 0 in `add_route()` (by means of `r->table_id` being 0)...?

      So.. can we do = this with half the code? Getting rid of all new DEFINEs, all new arguments= and flags to `route_list` things, just storing the table id in `struct rou= te_ipv4` and `struct route_ipv6`)=3D

To view, vis= it change= 524. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 6
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Comment-Date: Thu, 19 Sep 2024 10:40:05= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--+bocEp9HGwc=--