From: "ordex (Code Review)"
Date: Mon, 28 Jul 2025 11:39:36 +0000
In-Reply-To:
References:
Reply-To: antonio@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296...
Message-ID: <8354516a6b4379038941547c894ae8f0166745d5-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="UZa5Bp5AbZg="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dco: drop client
prefix after DCO PEER_FLOAT notification
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--UZa5Bp5AbZg=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1116?usp=3Demail )
Change subject: dco: drop client prefix after DCO PEER_FLOAT notification
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> These are 2 different problems: [=E2=80=A6]
After fixing problem 1) we should heck what remains of problem 2, because w=
e execute DCO commands always in the context of a known peer. We can't trul=
y jump from peer X to peer Y.
Also when doing a PEER_GET with id=3D-1 (dump all peers), we should not hav=
e any prefix set.
If we had one imho it was a leftover from the float (problem 1)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1116?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24
Gerrit-Change-Number: 1116
Gerrit-PatchSet: 2
Gerrit-Owner: ordex
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Mon, 28 Jul 2025 11:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--UZa5Bp5AbZg=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos. <=
/p>
View =
Change
1 comment:
After fixing problem 1) we should heck what remains=
of problem 2, because we execute DCO commands always in the context of a k=
nown peer. We can't truly jump from peer X to peer Y.
Also when doin=
g a PEER_GET with id=3D-1 (dump all peers), we should not have any prefix s=
et.
If we had one imho it was a leftover from the float (problem 1)
<=
/li>To view, visit change 1116. To unsubscribe, or for help w=
riting mail filters, visit s=
ettings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1ad5df0f6785ffe9becd9f83329=
a9335d1a36f24
Gerrit-Change-Number: 1116
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Mon, 28 Jul 2025 11:39:36=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--UZa5Bp5AbZg=--