Message-ID: <836b2603-38df-adea-c7c5-b5d1dfa8a97f@...1227...> Date: Wed, 13 Jul 2022 13:43:35 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220713083404.13227-1-kprovost@...2661...> <20220713083404.13227-2-kprovost@...2661...> From: Arne Schwabe In-Reply-To: <20220713083404.13227-2-kprovost@...2661...> Subject: Re: [Openvpn-devel] [PATCH] Handle exceeding 'max-clients' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Kristof Provost , openvpn-devel Am 13.07.22 um 10:34 schrieb Kristof Provost via Openvpn-devel: > From: Kristof Provost > > If 'max-clients' is set multi_create_instance() can return NULL (for any > client that would take us over the client limit). > > If mi is NULL we don't add it to the hash map, but we do potentially > dereference it to increment the session count. > Do not attempt to do so if 'mi == NULL'. Oops. This patch also becomes much easier to review with ignoring whitespace. Then the change is just moving the } Acked-By: Arne Schwabe