Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95EAC433DF for ; Wed, 27 May 2020 18:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2CE12084C for ; Wed, 27 May 2020 18:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391950AbgE0SVt (ORCPT ); Wed, 27 May 2020 14:21:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:46428 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391948AbgE0SVs (ORCPT ); Wed, 27 May 2020 14:21:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7691EAEB9; Wed, 27 May 2020 18:21:50 +0000 (UTC) Subject: Re: [PATCH 7/8] blk-mq: add blk_mq_all_tag_iter To: Christoph Hellwig Cc: linux-block@vger.kernel.org, John Garry , Bart Van Assche , Hannes Reinecke , Thomas Gleixner , Ming Lei References: <20200527180644.514302-1-hch@lst.de> <20200527180644.514302-8-hch@lst.de> From: Hannes Reinecke Message-ID: <8374b3ea-560a-117b-421e-a2f84401bbdb@suse.de> Date: Wed, 27 May 2020 20:21:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200527180644.514302-8-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 5/27/20 8:06 PM, Christoph Hellwig wrote: > From: Ming Lei > > Add a new blk_mq_all_tag_iter function to iterate over all allocated > scheduler tags and driver tags. This is more flexible than the existing > blk_mq_all_tag_busy_iter function as it allows the callers to do whatever > they want on allocated request instead of being limited to started > requests. > > It will be used to implement draining allocated requests on specified > hctx in this patchset. > > Signed-off-by: Ming Lei > [hch: switch from the two booleans to a more readable flags field and > consolidate the tags iter functions] > Signed-off-by: Christoph Hellwig > --- > block/blk-mq-tag.c | 46 +++++++++++++++++++++++++++++----------------- > block/blk-mq-tag.h | 2 ++ > 2 files changed, 31 insertions(+), 17 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer