From: "plaisthos (Code Review)" Date: Mon, 11 Dec 2023 13:59:24 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <83cc725ebcc53a91061c9f8b43e1793105cec162-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="svqHCS6ciE8="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --svqHCS6ciE8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/471?usp=3Demail ) Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 1: (6 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/471/comment/0db70bef_074e855b : PS1, Line 560: "test_ssl" > Those are sorted alphabetically Done http://gerrit.openvpn.net/c/openvpn/+/471/comment/e741cdb3_5a0aaaff : PS1, Line 675: target_sources(test_ssl PRIVATE > also sorted alphabetically I sorted them like the other ones that include mock files and have the test= /mock files first and not strictly alphabetical which would have put them a= t the end. File tests/unit_tests/openvpn/mock_management.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/5b10dbd9_9e007792 : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. > Copy & paste error? Or intentional? Done File tests/unit_tests/openvpn/mock_ssl_dependencies.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/979d7c62_638080d7 : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. > intentional? Done http://gerrit.openvpn.net/c/openvpn/+/471/comment/96b5a578_3c274b81 : PS1, Line 24: /* Minimal set of mocked management function/globals to get u= nit tests to > "management" is probably copy&paste Done File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/8b19f7d6_6a5c48d6 : PS1, Line 8: * Copyright (C) 2016-2021 Fox Crypto B.V. > probably not intentional Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 11 Dec 2023 13:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --svqHCS6ciE8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

View C= hange

6 comments:

    =
  • File CMakeLists.txt:

    • Patch Set #1, Line 560: "test_ssl"

      Those are sorted alphabetically

      Done

    • = Patch Set #1, Line 675: target_sources(test_ssl PRIVATE

      also sorted alph= abetically

      I sorted them like the other ones that include mock files and ha= ve the test/mock files first and not strictly alphabetical which would have= put them at the end.

  • Patch Set #1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.= V. <openvpn@...2507...>

    Copy & paste error?= Or intentional?

    Done

  • Patch Set #1, Line 8: * Copyright (C) 2017-2021 Fox Cry= pto B.V. <openvpn@...2507...>

    intentional?

    Done=

  • Patch Set #1, Line 24: /* Minimal set of mocked management function/globals to g= et unit tests to

    "management" is probably c= opy&paste

    Done

  • <= p>File tests/unit_tests/openvpn/test_ssl.c:

    • Patch Set #1, Line 8: * Copyright (C) 2016-2021 Fox Crypto B.V. <ope= nvpn@...2507...>

      probably not intentional

      Done

      =
  • To view, visit change 471. To unsubscribe, or for help wr= iting mail filters, visit se= ttings.

    <= div itemscope itemprop=3D"action" itemtype=3D"http://schema.org/ViewAction"= >
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c= 77ba0d6fa3381
    Gerrit-Change-Number: 471
    Gerrit-PatchSet: 1
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Mon, 11 Dec 2023 13:59:24= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
    Gerrit-MessageType: comment
    --svqHCS6ciE8=--