From: "plaisthos (Code Review)" Date: Thu, 16 May 2024 11:12:38 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., reynir@...2756... Message-ID: <83f4ecf305fd13824fc7188d8c072d012b7f9b6c-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9NhhiY1JRug="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Only schedule_exit() once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: reynir Cc: flichtenheld , openvpn-devel --9NhhiY1JRug= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, reynir. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/555?usp=3Demail ) Change subject: Only schedule_exit() once ...................................................................... Patch Set 3: (1 comment) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/555/comment/e98ba825_8fe5fe4e : PS1, Line 529: reset_coarse_timers(c); > I am not sure what the above three function calls do and if we should sti= ll call them. reset_coarse_timers ensures that newly scheduled timer actually is taken in= to account. `update_time` updates now for that. And tls_set_single_session= in typical OpenVPN fashion ensure that no renegotion can happy by using a = completely different feature of setting the session into a mode where no re= negotiation can happen. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661 Gerrit-Change-Number: 555 Gerrit-PatchSet: 3 Gerrit-Owner: reynir Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: reynir Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: reynir Gerrit-Comment-Date: Thu, 16 May 2024 11:12:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: reynir Gerrit-MessageType: comment --9NhhiY1JRug= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, reynir.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/forward.c:

    • Patch Set #1, Line 529:= reset_coarse_timers(c)= ;

      I am not sure what the above three function calls d= o and if we should still call them.

      reset_coarse_timers ensures that newly = scheduled timer actually is taken into account. `update_time` updates now f= or that. And tls_set_single_session in typical OpenVPN fashion ensure that= no renegotion can happy by using a completely different feature of setting= the session into a mode where no renegotiation can happen.

To view, visit change 555. To unsubscribe, or for help writing mail f= ilters, visit settings.<= /p>

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9457f005f4ba970502e6b667d9d= c4299a588d661
Gerrit-Change-Number: 555
Gerrit-PatchSet: 3
Gerrit-Owner: reynir <reynir@...2756...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: reynir <reynir@...2756...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: reynir <reynir@...2756...= >
Gerrit-Comment-Date: Thu, 16 May 2024 11:12:38= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: reynir <reynir@...2800...= ...>
Gerrit-MessageType: comment
--9NhhiY1JRug=--