Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E878AC433DF for ; Wed, 5 Aug 2020 14:55:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A82E23332 for ; Wed, 5 Aug 2020 14:55:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2O01jM/k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A82E23332 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WuG3XTRiAsCgWBpwG1GrMk8SW0j2MqnVMst9WkDaKAE=; b=2O01jM/ktRfrkuBG0tmkrp4+f wT+E5Nov9ODJWtawHmk8b0SCqD2GTqgH5klwOCZujPfe3SQEf3zyELxXKA4YaKriWVdnQvvEqH1vB 8D5P7qSNIKoRall4tqR0FwONv0CmOzJBp7ypxAaBtafZsV4gS7mAdwsw+NvLopG80ckvcD5qZM4GX wtmxvF3HGD/vrvYXc69cetm+ltK5+1R5oq/nT/rACmTkEZHbycnntjzlR+vVhlrCIJAL5nuOHLzia q3FPicGb/8DeiBBEISwmo5H0+2rVBz0AYdEPDpQ+/hP63DtNFykylZ2SfjsM+/22UZQKakUikxgo8 EK+Af/w/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3Knx-0003Up-U3; Wed, 05 Aug 2020 14:54:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3Knv-0003UE-63 for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 14:54:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 942F01045; Wed, 5 Aug 2020 07:54:01 -0700 (PDT) Received: from [10.37.12.82] (unknown [10.37.12.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5BC673F7D7; Wed, 5 Aug 2020 07:53:54 -0700 (PDT) Subject: Re: [PATCH v7 09/25] coresight: etm3x: allow etm3x to be built as a module To: mike.leach@linaro.org References: <20200805025458.2978-1-tingwei@codeaurora.org> <20200805025458.2978-10-tingwei@codeaurora.org> <83abb52f-4c3b-9b50-4053-84343d75eeb3@arm.com> From: Suzuki K Poulose Message-ID: <83fb1eef-dc60-f3af-e041-e7795b9cc593@arm.com> Date: Wed, 5 Aug 2020 15:58:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_105407_363277_F18C1036 X-CRM114-Status: GOOD ( 29.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, kim.phillips@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, coresight@lists.linaro.org, rdunlap@infradead.org, ykaukab@suse.de, linux@armlinux.org.uk, jinlmao@codeaurora.org, tingwei@codeaurora.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/05/2020 01:54 PM, Mike Leach wrote: > Hi, > > On Wed, 5 Aug 2020 at 12:05, Suzuki K Poulose wrote: >> >> On 08/05/2020 03:54 AM, Tingwei Zhang wrote: >>> From: Kim Phillips >>> >>> Allow to build coresight-etm3x as a module, for ease of development. >>> >>> - Kconfig becomes a tristate, to allow =m >>> - append -core to source file name to allow module to >>> be called coresight-etm3x by the Makefile >>> - add an etm_remove function, for module unload >>> - add a MODULE_DEVICE_TABLE for autoloading on boot >>> >>> Cc: Mathieu Poirier >>> Cc: Leo Yan >>> Cc: Alexander Shishkin >>> Cc: Randy Dunlap >>> Cc: Suzuki K Poulose >>> Cc: Greg Kroah-Hartman >>> Cc: Russell King >>> Signed-off-by: Kim Phillips >>> Signed-off-by: Tingwei Zhang >>> Reviewed-by: Mike Leach >>> bool "CoreSight Embedded Trace Macrocell 4.x driver" >>> depends on ARM64 >>> diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile >>> index 19497d1d92bf..d619cfd0abd8 100644 >>> --- a/drivers/hwtracing/coresight/Makefile >>> +++ b/drivers/hwtracing/coresight/Makefile >>> @@ -11,7 +11,8 @@ obj-$(CONFIG_CORESIGHT_SINK_TPIU) += coresight-tpiu.o >>> obj-$(CONFIG_CORESIGHT_SINK_ETBV10) += coresight-etb10.o >>> obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o \ >>> coresight-replicator.o >>> -obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o coresight-etm-cp14.o \ >>> +obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o >>> +coresight-etm3x-y := coresight-etm3x-core.o coresight-etm-cp14.o \ >>> coresight-etm3x-sysfs.o >>> obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \ >>> coresight-etm4x-sysfs.o >>> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c >>> similarity index 97% >>> rename from drivers/hwtracing/coresight/coresight-etm3x.c >>> rename to drivers/hwtracing/coresight/coresight-etm3x-core.c >>> index bf22dcfd3327..82b333c40006 100644 >>> --- a/drivers/hwtracing/coresight/coresight-etm3x.c >>> +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c >>> @@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id) >>> return ret; >>> } >>> >>> +static int __exit etm_remove(struct amba_device *adev) >>> +{ >>> + struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev); >>> + >>> + etm_perf_symlink(drvdata->csdev, false); >>> + >>> + if (--etm_count == 0) { >> >> Could there be multiple instances of remove running in parallel ? I >> believe we need some sort of a protection here to avoid racing. >> >> Or even better, I would recommend leaving the notifiers registered >> at module_init and removed at the cleanup of the module, just like >> we are doing for etm4x driver, and get rid of this silly scheme. > > I would agree that this needs addressing but this is an independent > problem that could be better served by a separate patchset, rather I agree that it is an independent problem, but this series makes it more exposed, i.e, calling the probe/remove at runtime in any order. So, pushing this series before that is fixed is going to cause trouble, if they both end up in different releases. > than add feature creep to this set. The same schema is used in the CTI > driver as well and needs fixing there. > >> Like here : >> >> https://lkml.kernel.org/r/20200729051310.18436-1-saiprakash.ranjan@codeaurora.org >> > > This conflicts with the init / exit fns created for module loading in > the etm4x part of this set.. > > A decision needs to be made on which set gets applied first - my view > is that the module set could go first, then a set fixing the PM > registration issues for all three affected drivers to be applied next. I think we should do the opposite. Fixing the hotplug is fairly straight forward, and need not block on this large series. Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel