From: "flichtenheld (Code Review)" Date: Mon, 26 May 2025 09:54:45 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, antonio@...2726..., gert@...1296... Message-ID: <84229678ef8ca7dd8c42558da105529b6c410592-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="snb4Tc2NWDo="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --snb4Tc2NWDo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/791?usp=3Demail ) Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 18: (3 comments) File src/openvpn/buffer.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/6892fcb6_41f2daaf : PS18, Line 850: } while (c); > it should not do that Why? http://gerrit.openvpn.net/c/openvpn/+/791/comment/18dc39e2_b722d6bf : PS18, Line 915: && c !=3D 127)) /* allow ascii non-control and = UTF-8, consider DEL to be a control */ > this is ugly, but I guess the best way to fix it is to manually move the = comment before the if() lin [=E2=80=A6] Yes. File src/openvpn/console_builtin.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/e785d1b2_41139a46 : PS18, Line 74: msg(M_WARN | M_ERRNO, "get_console_input_win32(): un= expected error"); > the extra spaces around `foo|bar` are not really to my liking ("this belo= ngs together" vibes) Interestingly one of the things we can't configure in clang-format. The spa= ce around binary operators is not optional. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 18 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: ordex Gerrit-Comment-Date: Mon, 26 May 2025 09:54:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --snb4Tc2NWDo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, ordex, plaisthos.

View C= hange

3 comments:

    =
  • File src/openvpn/buffer.c:

  • File src/op= envpn/console_builtin.c:

      Patch Set #18, Line 74: msg(M_WARN | M_ERRNO, "get_console_input_win32(): unexp= ected error");

      the extra spaces around `foo|bar`= are not really to my liking ("this belongs together" vibes)

      Inte= restingly one of the things we can't configure in clang-format. The spa= ce around binary operators is not optional.

To vi= ew, visit change 791. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b= 8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 18
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: ordex <antonio@...2726...= >
Gerrit-Comment-Date: Mon, 26 May 2025 09:54:45= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--snb4Tc2NWDo=--