From: Marek Vasut Date: Tue, 3 Mar 2020 13:12:45 +0100 Subject: [PATCH] arm: socfpga: arria10: Add save_boot_params() In-Reply-To: References: <20200226190144.65467-1-ley.foon.tan@intel.com> Message-ID: <84249240-be6e-e43b-3117-e71d7d2b8fb2@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 3/3/20 10:14 AM, Ley Foon Tan wrote: > On Mon, Mar 2, 2020 at 6:40 PM Marek Vasut wrote: >> >> On 3/2/20 8:20 AM, Tan, Ley Foon wrote: >> Hi, >> >> [...] >> >>>> On 2/26/20 8:01 PM, Ley Foon Tan wrote: >>>> [...] >>>>> +#define BOOTROM_SHARED_MEM_ADDR >>>> (CONFIG_SYS_INIT_RAM_ADDR + 0x40000 \ >>>>> + - 0x800) >>>>> +#define RST_STATUS_SHARED_ADDR >>>> (BOOTROM_SHARED_MEM_ADDR + 0x438) >>>> >>>> Are all these magic values needed or is there some more descriptive macro >>>> name available for them ? >>> 0x40000 is onchip ram size and 0x800 is 2KB size. >>> I can convert these to 2 macos. >> >> Aren't those already defined in include/configs/socfpga_common.h ? > socfpga_common.h have this: > #define CONFIG_SYS_INIT_RAM_SIZE (0x40000 - CONFIG_SYS_SPL_MALLOC_SIZE) > > But, we can't use it here. Why ? [...]